From: Andy Shevchenko <andy@kernel.org>
To: Andrei Coardos <aboutphysycs@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
zhang.lyra@gmail.com, baolin.wang@linux.alibaba.com,
orsonzhai@gmail.com, brgl@bgdev.pl, linus.walleij@linaro.org,
Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call
Date: Mon, 17 Jul 2023 17:05:53 +0300 [thread overview]
Message-ID: <ZLVKwadaVM+0kxWw@smile.fi.intel.com> (raw)
In-Reply-To: <20230717121004.5205-1-aboutphysycs@gmail.com>
On Mon, Jul 17, 2023 at 03:10:04PM +0300, Andrei Coardos wrote:
> The platform_set_drvdata() call was never used, ever since the driver was
> originally added.
> It looks like this copy+paste left-over. Possibly the author copied from a
> driver that had this line, but also had a remove hook.
Reviewed-by: Andy Shevchenko <andy@kernel.org>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-07-17 14:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-17 12:10 [PATCH] gpio: eic-sprd: remove unneeded platform_set_drvdata() call Andrei Coardos
2023-07-17 14:05 ` Andy Shevchenko [this message]
2023-07-20 6:39 ` Baolin Wang
2023-07-29 14:07 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLVKwadaVM+0kxWw@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=baolin.wang@linux.alibaba.com \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=orsonzhai@gmail.com \
--cc=zhang.lyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.