All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Marczykowski-Górecki" <marmarek@invisiblethingslab.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Doug Goldstein <cardoe@cardoe.com>,
	Stefano Stabellini <sstabellini@kernel.org>,
	"committers@xenproject.org" <committers@xenproject.org>
Subject: Re: [PATCH] automation: avoid duplicated builds of staging branch
Date: Mon, 17 Jul 2023 16:08:38 +0200	[thread overview]
Message-ID: <ZLVLaPeyOwDYYUXL@mail-itl> (raw)
In-Reply-To: <cf7ac648-dbef-80bb-986b-3fe0daef855a@citrix.com>

[-- Attachment #1: Type: text/plain, Size: 1649 bytes --]

On Mon, Jul 17, 2023 at 02:14:14PM +0100, Andrew Cooper wrote:
> On 17/07/2023 2:09 pm, Marek Marczykowski-Górecki wrote:
> > "staging" branch is mirrored (automatically or manually) to several
> > repositories. Avoid building it several times to not waste runner
> > resources.
> >
> > Signed-off-by: Marek Marczykowski-Górecki <marmarek@invisiblethingslab.com>
> > ---
> >  .gitlab-ci.yml | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> > index c8bd7519d5fb..c3b05e32636b 100644
> > --- a/.gitlab-ci.yml
> > +++ b/.gitlab-ci.yml
> > @@ -2,6 +2,12 @@ stages:
> >    - build
> >    - test
> >  
> > +workflow:
> > +  rules:
> > +    - if: '$CI_COMMIT_REF_NAME == "staging" && $CI_PROJECT_NAMESPACE != "xen-project"'
> > +      when: never
> > +    - when: always
> 
> If we're doing this for staging, we should include staging-* and
> stable-*.  They're all the same from this point of view.
> 
> However, this does need double checking with the committers who use
> gitlab regularly (CC'd).  This doesn't happen to interfere with my
> commit workflow (I use a separate branch called for-staging), but I
> can't talk for others.

I'd like to avoid broad patterns like staging-* or stable-* here, I'm
pretty sure people do use branches like staging-X.Y-something. While it
would be possible to exclude them by listing exact names, I'm not sure
if it's worth it, given the push frequency to them (few times a month)
and those being mirrored to less repositories (only FuSa fork?).

-- 
Best Regards,
Marek Marczykowski-Górecki
Invisible Things Lab

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  reply	other threads:[~2023-07-17 14:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 13:09 [PATCH] automation: avoid duplicated builds of staging branch Marek Marczykowski-Górecki
2023-07-17 13:14 ` Andrew Cooper
2023-07-17 14:08   ` Marek Marczykowski-Górecki [this message]
2023-07-21 23:42     ` Stefano Stabellini
2023-07-22  0:07       ` Marek Marczykowski-Górecki
2023-07-22  0:14         ` Stefano Stabellini
2023-07-22  0:24           ` Marek Marczykowski-Górecki
2023-07-22  0:49             ` Stefano Stabellini
2023-07-22  1:00               ` Marek Marczykowski-Górecki
2023-07-22  1:18                 ` Stefano Stabellini
2023-07-24  8:27                   ` Oleksii
2023-07-24 20:58                     ` Stefano Stabellini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLVLaPeyOwDYYUXL@mail-itl \
    --to=marmarek@invisiblethingslab.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=cardoe@cardoe.com \
    --cc=committers@xenproject.org \
    --cc=sstabellini@kernel.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.