All of lore.kernel.org
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: AtariDreams via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
	AtariDreams <83477269+AtariDreams@users.noreply.github.com>,
	Seija Kijin <doremylover123@gmail.com>
Subject: Re: [PATCH] Prefer fgetc over fgets where possible
Date: Mon, 17 Jul 2023 16:14:36 -0400	[thread overview]
Message-ID: <ZLWhLH2xRq20jFFY@nand.local> (raw)
In-Reply-To: <pull.1550.git.git.1689608291732.gitgitgadget@gmail.com>

On Mon, Jul 17, 2023 at 03:38:11PM +0000, AtariDreams via GitGitGadget wrote:
> ---
>     Prefer fgetc over fgets where possible
>
>     fputc is meant for single characters, fputs is for strings. We are
>     better off inserting sole \n characters as characters, not whole
>     strings.
>
>     Signed-off-by: Seija Kijin doremylover123@gmail.com

I tend to agree with Junio's assessment that adding churn here isn't
strictly necessary / worth it, but if we do end up taking this patch,
note that the subject should reference `fputc()` and `fputs()` instead
of `fgetc()` and `fgets()`.

Taylor

  parent reply	other threads:[~2023-07-17 20:14 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-17 15:38 [PATCH] Prefer fgetc over fgets where possible AtariDreams via GitGitGadget
2023-07-17 16:51 ` Junio C Hamano
2023-07-17 20:14 ` Taylor Blau [this message]
2024-12-18  1:16 ` [PATCH v2] " AreaZR via GitGitGadget

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZLWhLH2xRq20jFFY@nand.local \
    --to=me@ttaylorr.com \
    --cc=83477269+AtariDreams@users.noreply.github.com \
    --cc=doremylover123@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.