Re: [Intel-xe] [PATCH] drm/xe/execlist: Log when using execlist submission

[Rodrigo Vivi <rodrigo.vivi@intel.com>]

On Wed, Jul 19, 2023 at 06:57:07PM +0000, Francois Dugast wrote:
> Make explicit in the log that execlist submission is used to prevent from
> silently using it over GuC submission.
> 
> Signed-off-by: Francois Dugast <francois.dugast@intel.com>
> ---
>  drivers/gpu/drm/xe/xe_execlist.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/xe/xe_execlist.c b/drivers/gpu/drm/xe/xe_execlist.c
> index 3aec37985f32..541f82387bb5 100644
> --- a/drivers/gpu/drm/xe/xe_execlist.c
> +++ b/drivers/gpu/drm/xe/xe_execlist.c
> @@ -318,9 +318,12 @@ static int execlist_engine_init(struct xe_engine *e)
>  {
>  	struct drm_gpu_scheduler *sched;
>  	struct xe_execlist_engine *exl;
> +	struct xe_device *xe = gt_to_xe(e->gt);
>  	int err;
>  
> -	XE_BUG_ON(xe_device_guc_submission_enabled(gt_to_xe(e->gt)));
> +	XE_BUG_ON(xe_device_guc_submission_enabled(xe));

this bug_on shouldn't be here. if we have this bizarre case where we are trying
to enable execlist bug guc submission is enabled, we should put an error message
and exit gracefully, without knocking the system out. (Same for every other BUG_ONs)

But not part of this patch goal, I know...

> +
> +	drm_info(&xe->drm, "Enabling execlist submission (GuC submission disabled)\n");


Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  
>  	exl = kzalloc(sizeof(*exl), GFP_KERNEL);
>  	if (!exl)
> -- 
> 2.34.1
>