From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 58EC8EB64DA for ; Thu, 20 Jul 2023 10:29:39 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B19B110E59F; Thu, 20 Jul 2023 10:29:38 +0000 (UTC) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) by gabe.freedesktop.org (Postfix) with ESMTPS id A1F4C10E5A2 for ; Thu, 20 Jul 2023 10:29:36 +0000 (UTC) Received: by mail-wm1-x32b.google.com with SMTP id 5b1f17b1804b1-3fc03d990daso1013895e9.1 for ; Thu, 20 Jul 2023 03:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1689848975; x=1690453775; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=55ldkBN7Z9rmeZAoOny3CqxP4h68H/R8XHjCRpEpvaM=; b=To/aqJ+AR8e5dWEecXLmVyKzJv7p/eXCLLd8C+JTITCgvgX10gO3bPy9mTfjfApmKC pxsQe0Zi0t9ZTJKAnnPaXOSY+2KgC+undQtxxu7OXKGlWVpCoprWFOsxf+W4mnSLiDLC pAgi2NsmcZku6fKLA/jCVUWBjUWpmQMelRwLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689848975; x=1690453775; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=55ldkBN7Z9rmeZAoOny3CqxP4h68H/R8XHjCRpEpvaM=; b=P+vUcpdlE8gLBYC4zZgUxhOMYYnlfttBjaH/LKEGvvQFavdHgl+8xynujy0KtAQ60J VkKHYuOHTTxvTBj4b6aRXJd0AQ0IoG4IbMA8MFzaSSou2vsSKXvjxIJ1bp7B0EIhm2a7 VLXQ6JfM0GulyGPkGTtrf/L/x0LbL5WfuCZRmd29l55bS9YVAYdGTdL/N+UgVsFMnGZn uo94pqx9LBpjtxwI13l0BsDknBcnGk9FB6IUufVbeeb/Jabt4szwgbOyt5dDYJ8ISh7M 4Y9DG4eP/ye+uRtq7maN9QP69PgqE0WCpjHtf9a+Ax9P7SQtAHjaibGKWz17PiKyHEcb XHMw== X-Gm-Message-State: ABy/qLblKx1PLjeeN7XA84MuwF1YMMU80q6OK2HgC66C7t96bvy50GBN k0rtxdsTcomj/aNQCk0xttBKzg== X-Google-Smtp-Source: APBJJlGt+6m30H+euMcgCia5xz8EHhxIYsHnKz/Fj04bqSKh9ChxaTbMBvaixRVxb9X8NJRNSY8UQQ== X-Received: by 2002:a05:600c:354f:b0:3fa:9587:8fc1 with SMTP id i15-20020a05600c354f00b003fa95878fc1mr1968458wmq.1.1689848974989; Thu, 20 Jul 2023 03:29:34 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id f14-20020a7bcd0e000000b003fc01f7b415sm3582137wmj.39.2023.07.20.03.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 03:29:34 -0700 (PDT) Date: Thu, 20 Jul 2023 12:29:32 +0200 From: Daniel Vetter To: Oded Gabbay Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers Message-ID: Mail-Followup-To: Oded Gabbay , Tomer Tayar , Arnd Bergmann , Ohad Sharabi , Arnd Bergmann , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Dafna Hirschfeld , Ofir Bitton References: <20230609120636.3969045-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 6.3.0-2-amd64 X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Arnd Bergmann , Ohad Sharabi , Arnd Bergmann , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Dafna Hirschfeld , Tomer Tayar , Ofir Bitton Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote: > On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar wrote: > > > > On 09/06/2023 15:06, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Two functions got added with normal prototypes for debugfs, but not > > > alternative when building without it: > > > > > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init': > > > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration] > > > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration] > > > > > > Add stubs for these as well. > > > > > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later") > > > Signed-off-by: Arnd Bergmann > > > > Thanks, > > Reviewed-by: Tomer Tayar > > Thanks, > Applied to -fixes. As requested applied to drm-fixes, hopeful for the next one your drm-misc account issue is fixed. -Daniel > Oded > > > > > --- > > > drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h > > > index d92ba2e30e310..2f027d5a82064 100644 > > > --- a/drivers/accel/habanalabs/common/habanalabs.h > > > +++ b/drivers/accel/habanalabs/common/habanalabs.h > > > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void) > > > { > > > } > > > > > > +static inline int hl_debugfs_device_init(struct hl_device *hdev) > > > +{ > > > + return 0; > > > +} > > > + > > > +static inline void hl_debugfs_device_fini(struct hl_device *hdev) > > > +{ > > > +} > > > + > > > static inline void hl_debugfs_add_device(struct hl_device *hdev) > > > { > > > } > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCEF0EB64DC for ; Thu, 20 Jul 2023 10:29:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231328AbjGTK3q (ORCPT ); Thu, 20 Jul 2023 06:29:46 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231370AbjGTK3l (ORCPT ); Thu, 20 Jul 2023 06:29:41 -0400 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 289FF199A for ; Thu, 20 Jul 2023 03:29:36 -0700 (PDT) Received: by mail-wm1-x32e.google.com with SMTP id 5b1f17b1804b1-3fbb634882dso1043495e9.0 for ; Thu, 20 Jul 2023 03:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; t=1689848975; x=1690453775; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:from:to:cc:subject:date:message-id:reply-to; bh=55ldkBN7Z9rmeZAoOny3CqxP4h68H/R8XHjCRpEpvaM=; b=To/aqJ+AR8e5dWEecXLmVyKzJv7p/eXCLLd8C+JTITCgvgX10gO3bPy9mTfjfApmKC pxsQe0Zi0t9ZTJKAnnPaXOSY+2KgC+undQtxxu7OXKGlWVpCoprWFOsxf+W4mnSLiDLC pAgi2NsmcZku6fKLA/jCVUWBjUWpmQMelRwLE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689848975; x=1690453775; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:mail-followup-to:message-id:subject:cc:to :from:date:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=55ldkBN7Z9rmeZAoOny3CqxP4h68H/R8XHjCRpEpvaM=; b=MZZHa6dXJ3m/J8j9gm2qWVDthDjrTsMzaqE2jLeaA/zVb8Lmyh4/ClyOzv/PzQ+51L syWIUE7vj99V3HVm6/QehPUViTCOV3Zsms/jUrt4x2UYDktSHe1TY8yUcY7QrnfaFWIs tGQ/sOgmFCkRMtI4TBg752u3vSFjy3ZhaerdjAbnlUwg/ACUnZ50GoAYmxgwvTwK1d09 X6b3Y6MyYy+nsjqxmOKkvgArXXlWj6ZeBXADslpoCj9I5Rv0zEONc7jQ1oh+zL56D74o uEqAPeS2bDJoXs6MC7D2C9C5eaH50m+ep5idxWdNsTlxU72jDuorFr3wl0DepEM8389e oUcw== X-Gm-Message-State: ABy/qLYlFAWDo8vd/qe/kBSb+64uFS7vGJZ2XQNvqjXe0ZTdq4zg4z5k n5sEks4KmOb8LsKSHKaArddIFUEJCVw/iSA0qTc= X-Google-Smtp-Source: APBJJlGt+6m30H+euMcgCia5xz8EHhxIYsHnKz/Fj04bqSKh9ChxaTbMBvaixRVxb9X8NJRNSY8UQQ== X-Received: by 2002:a05:600c:354f:b0:3fa:9587:8fc1 with SMTP id i15-20020a05600c354f00b003fa95878fc1mr1968458wmq.1.1689848974989; Thu, 20 Jul 2023 03:29:34 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:57f4:0:efd0:b9e5:5ae6:c2fa]) by smtp.gmail.com with ESMTPSA id f14-20020a7bcd0e000000b003fc01f7b415sm3582137wmj.39.2023.07.20.03.29.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 20 Jul 2023 03:29:34 -0700 (PDT) Date: Thu, 20 Jul 2023 12:29:32 +0200 From: Daniel Vetter To: Oded Gabbay Cc: Tomer Tayar , Arnd Bergmann , Ohad Sharabi , Arnd Bergmann , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Dafna Hirschfeld , Ofir Bitton Subject: Re: [PATCH] accel/habanalabs: add more debugfs stub helpers Message-ID: Mail-Followup-To: Oded Gabbay , Tomer Tayar , Arnd Bergmann , Ohad Sharabi , Arnd Bergmann , "linux-kernel@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , Dafna Hirschfeld , Ofir Bitton References: <20230609120636.3969045-1-arnd@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Operating-System: Linux phenom 6.3.0-2-amd64 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jun 11, 2023 at 12:50:31PM +0300, Oded Gabbay wrote: > On Fri, Jun 9, 2023 at 4:37 PM Tomer Tayar wrote: > > > > On 09/06/2023 15:06, Arnd Bergmann wrote: > > > From: Arnd Bergmann > > > > > > Two functions got added with normal prototypes for debugfs, but not > > > alternative when building without it: > > > > > > drivers/accel/habanalabs/common/device.c: In function 'hl_device_init': > > > drivers/accel/habanalabs/common/device.c:2177:14: error: implicit declaration of function 'hl_debugfs_device_init'; did you mean 'hl_debugfs_init'? [-Werror=implicit-function-declaration] > > > drivers/accel/habanalabs/common/device.c:2305:9: error: implicit declaration of function 'hl_debugfs_device_fini'; did you mean 'hl_debugfs_remove_file'? [-Werror=implicit-function-declaration] > > > > > > Add stubs for these as well. > > > > > > Fixes: 553311fc7b76e ("accel/habanalabs: expose debugfs files later") > > > Signed-off-by: Arnd Bergmann > > > > Thanks, > > Reviewed-by: Tomer Tayar > > Thanks, > Applied to -fixes. As requested applied to drm-fixes, hopeful for the next one your drm-misc account issue is fixed. -Daniel > Oded > > > > > --- > > > drivers/accel/habanalabs/common/habanalabs.h | 9 +++++++++ > > > 1 file changed, 9 insertions(+) > > > > > > diff --git a/drivers/accel/habanalabs/common/habanalabs.h b/drivers/accel/habanalabs/common/habanalabs.h > > > index d92ba2e30e310..2f027d5a82064 100644 > > > --- a/drivers/accel/habanalabs/common/habanalabs.h > > > +++ b/drivers/accel/habanalabs/common/habanalabs.h > > > @@ -3980,6 +3980,15 @@ static inline void hl_debugfs_fini(void) > > > { > > > } > > > > > > +static inline int hl_debugfs_device_init(struct hl_device *hdev) > > > +{ > > > + return 0; > > > +} > > > + > > > +static inline void hl_debugfs_device_fini(struct hl_device *hdev) > > > +{ > > > +} > > > + > > > static inline void hl_debugfs_add_device(struct hl_device *hdev) > > > { > > > } > > > > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch