From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 2/4] ALSA: ac97: Use the standard snd_ctl_add_followers() helper
Date: Thu, 20 Jul 2023 12:35:22 +0200 [thread overview]
Message-ID: <ZLkN6jK5Gw19ZNqU@ugly> (raw)
In-Reply-To: <20230720082554.31891-3-tiwai@suse.de>
On Thu, Jul 20, 2023 at 10:25:52AM +0200, Takashi Iwai wrote:
>+ err = snd_ctl_add_followers(ac97->bus->card, kctl, followers);
>+ if (err < 0)
>+ return err;
>
> return 0;
>
this seems a bit pointless - you could just
return snd_ctl_add_followers(...
directly.
(more instances may be affected, but i don't see it due to little diff
context.)
> }
regards
next prev parent reply other threads:[~2023-07-20 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 8:25 [PATCH 0/4] ALSA: Cleanup with snd_ctl_add_followers() Takashi Iwai
2023-07-20 8:25 ` [PATCH 1/4] ALSA: vmaster: Add snd_ctl_add_followers() helper Takashi Iwai
2023-07-20 8:25 ` [PATCH 2/4] ALSA: ac97: Use the standard " Takashi Iwai
2023-07-20 10:35 ` Oswald Buddenhagen [this message]
2023-07-20 10:59 ` Takashi Iwai
2023-07-20 8:25 ` [PATCH 3/4] ALSA: ca0106: " Takashi Iwai
2023-07-20 8:25 ` [PATCH 4/4] ALSA: ice1712: " Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLkN6jK5Gw19ZNqU@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.