From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH for-8.1] scripts/git-submodule.sh: Don't rely on non-POSIX 'read' behaviour
Date: Thu, 20 Jul 2023 17:04:33 +0100 [thread overview]
Message-ID: <ZLlbEV7ZsaRiwXgo@redhat.com> (raw)
In-Reply-To: <20230720153038.1587196-1-peter.maydell@linaro.org>
On Thu, Jul 20, 2023 at 04:30:38PM +0100, Peter Maydell wrote:
> The POSIX definition of the 'read' utility requires that you
> specify the variable name to set; omitting the name and
> having it default to 'REPLY' is a bashism. If your system
> sh is dash, then it will print an error message during build:
>
> qemu/pc-bios/s390-ccw/../../scripts/git-submodule.sh: 106: read: arg count
>
> Specify the variable name explicitly.
>
> Fixes: fdb8fd8cb915647b ("git-submodule: allow partial update of .git-submodule-status")
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
> scripts/git-submodule.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé <berrange@redhat.com>
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-07-20 16:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 15:30 [PATCH for-8.1] scripts/git-submodule.sh: Don't rely on non-POSIX 'read' behaviour Peter Maydell
2023-07-20 16:04 ` Daniel P. Berrangé [this message]
2023-07-21 9:11 ` Philippe Mathieu-Daudé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLlbEV7ZsaRiwXgo@redhat.com \
--to=berrange@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.