From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Alicja Michalska <ahplka19@gmail.com>
Cc: linux-kernel@vger.kernel.org, robbarnes@google.com,
lalithkraj@google.com, rrangel@chromium.org, bleung@chromium.org,
groeck@chromium.org, chrome-platform@lists.linux.dev
Subject: Re: [PATCH] platform/chrome: cros_ec_lpc: Add DMI definition for post-Skylake machines running custom Coreboot builds
Date: Fri, 21 Jul 2023 14:39:05 +0800 [thread overview]
Message-ID: <ZLooCXV11JCdWOdK@google.com> (raw)
In-Reply-To: <ZLm3G5G6/gmLZwkn@tora>
On Fri, Jul 21, 2023 at 12:37:15AM +0200, Alicja Michalska wrote:
> ChromeOS EC LPC lacks DMI match for newer machines, which
> use "Google" DMI_SYS_VENDOR as opposed to "GOOGLE" in older models.
I'm confused about the sentence as it looks irrelevant to the patch.
> This patch adds DMI definition for MrChomebox's custom Coreboots builds,
> which we (Chrultrabook Project) are using.
s/This patch adds/Add/. Search "imperative mood" in [1].
Looks like a typo: s/MrChomebox/MrChromebox/.
If you get chance to send next version, please shorten the commit title.
I guess "platform/chrome: cros_ec_lpc: Add DMI match for MrChromebox" should
be quite explicit.
[1]: https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> + /* DMI doesn't match modern machines running custom firmware */
Remove the line.
> + {
> + /* MrChromebox's firmware */
> + .matches = {
> + DMI_MATCH(DMI_BIOS_VENDOR, "coreboot"),
> + DMI_MATCH(DMI_BIOS_VERSION, "MrChromebox-"),
> + },
> + },
Put the block after "A small number of non-Chromebook/box machines also use
the ChromeOS EC"[2].
[2]: https://elixir.bootlin.com/linux/v6.4/source/drivers/platform/chrome/cros_ec_lpc.c#L533
next prev parent reply other threads:[~2023-07-21 6:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-20 22:37 [PATCH] platform/chrome: cros_ec_lpc: Add DMI definition for post-Skylake machines running custom Coreboot builds Alicja Michalska
2023-07-21 6:39 ` Tzung-Bi Shih [this message]
2023-07-21 17:13 ` Alicja Michalska
2023-07-21 17:28 ` Brian Norris
2023-07-21 18:11 ` Alicja Michalska
2023-07-27 18:30 ` Raul Rangel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLooCXV11JCdWOdK@google.com \
--to=tzungbi@kernel.org \
--cc=ahplka19@gmail.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=lalithkraj@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robbarnes@google.com \
--cc=rrangel@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.