From: Andy Shevchenko <andy@kernel.org>
To: Andrei Coardos <aboutphysycs@gmail.com>
Cc: linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
brgl@bgdev.pl, linus.walleij@linaro.org,
Alexandru Ardelean <alex@shruggie.ro>
Subject: Re: [PATCH] gpio: lp873x: remove unnecessary call to platform_set_drvdata()
Date: Fri, 21 Jul 2023 13:20:39 +0300 [thread overview]
Message-ID: <ZLpb99Trx5+4iMCS@smile.fi.intel.com> (raw)
In-Reply-To: <20230721094343.25741-1-aboutphysycs@gmail.com>
On Fri, Jul 21, 2023 at 12:43:43PM +0300, Andrei Coardos wrote:
> This function call was found to be unnecessary as there is no equivalent
> platform_get_drvdata() call to access the private data of the driver.
> Also, the private data is defined in this driver, so there is no risk of
> it being accessed outside of this driver file.
Wrong version of the patch. Use -v<X>, where <X> is a number.
> Reviewed-by: Alexandru Ardelean <alex@shruggie.ro>
> Signed-off-by: Andrei Coardos <aboutphysycs@gmail.com>
> ---
There is no changelog. What has been changed? What's the difference to v1
if this is assumed v2?
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-07-21 10:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-21 9:43 [PATCH] gpio: lp873x: remove unnecessary call to platform_set_drvdata() Andrei Coardos
2023-07-21 10:20 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZLpb99Trx5+4iMCS@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=aboutphysycs@gmail.com \
--cc=alex@shruggie.ro \
--cc=brgl@bgdev.pl \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.