From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Fri, 21 Jul 2023 10:13:46 -0700 Subject: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory In-Reply-To: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jul 21, 2023, Paolo Bonzini wrote: > On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > > u64 flags = args->flags; > > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > > + > > I think it should be always allowed. The outcome would just be "never have > a hugepage" if thp is not enabled in the kernel. I don't have a strong preference. My thinking was that userspace would probably rather have an explicit error, as opposed to silently running with a misconfigured setup. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f202.google.com (mail-yb1-f202.google.com [209.85.219.202]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0EB9627F00 for ; Fri, 21 Jul 2023 17:13:48 +0000 (UTC) Received: by mail-yb1-f202.google.com with SMTP id 3f1490d57ef6-d064a458dd5so267754276.1 for ; Fri, 21 Jul 2023 10:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=saEUf4445sfHkPWRX975heL8zENfXcs3PgCyCgvEVdQjEpNK/pp+iAjdHt4YEb3A4E Wx6AMp1fx4AxdUC7quE/wuY8PzajpllFI1PSVxa0GJ6TCvZZ95BwZYWsRgoM01BQ4SqE g1i1UMNIUCRiN6vVjQF+QtV7pxLVFxnr+vtjGFTshuCRS/R0Np16E0/qf+bH5mnx7XFz ZsljdMjRbBLWTIazxQedjqyAevMpWeXTTd8MiT3v+VX/sBebfo66Po7WIiS0jw2kNrZS H5psY9S7R0h0zicR7miAPapKCtbYppPvDwh7bNN96b+Zux6kO9omgHgr2n7bbHvjHh23 55GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=YCNNdkdZWrA2i29KDqCoOP9nXD7l/dE1tHJvBAF7MubS4Cll9ECJqN7/RcEQEakNhE KKM+rHur2r47t8GDhbw5HuUtANF6guvs/Z1JpzOW9jv9p4r0E/zPRxwPGZQ6eZWtmKw3 +T6ueHNzhmSpQIjFBKiiJBHxkUzfXmpmMEiEbR+/I7d2h8p3u6Z6oDnddSXjdsC07pNx 9wG3EIlT5qVJEFTzuTKxY47g3HMh56Be9veArNa2U7mVS/TnRGM2E9hh6EdWiU/ershG XFxZ8xV2I/PNt28+CPge5b/mtwn1JS+2ExI+WiZ5EQ8VPB1L7oALeGVa7mHRtumSUEAu tC3w== X-Gm-Message-State: ABy/qLYMlel0BSw7JBrMjmKqBTcQf1K06D8F6Os65g33hNMclvTzixtS tb91/AWaCO78IDS4bY3Sj7FWq3tfXfE= X-Google-Smtp-Source: APBJJlHTu6oxQip7Fs57WKX81frcXYslN0cZxNmgdAvx9eWDlCTFu1+cjXODNvw8IvlIlsVUOd7h6YXth7Y= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:a28f:0:b0:c6e:fe1a:3657 with SMTP id c15-20020a25a28f000000b00c6efe1a3657mr16139ybi.3.1689959627795; Fri, 21 Jul 2023 10:13:47 -0700 (PDT) Date: Fri, 21 Jul 2023 10:13:46 -0700 In-Reply-To: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Message-ID: Subject: Re: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="us-ascii" On Fri, Jul 21, 2023, Paolo Bonzini wrote: > On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > > u64 flags = args->flags; > > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > > + > > I think it should be always allowed. The outcome would just be "never have > a hugepage" if thp is not enabled in the kernel. I don't have a strong preference. My thinking was that userspace would probably rather have an explicit error, as opposed to silently running with a misconfigured setup. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F1CB4EB64DD for ; Fri, 21 Jul 2023 17:13:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=oSHfT4O3tUTD1XeVOTULRwSGhVMBNRI0+NbQepTQahk=; b=nZbxdLAzwEG07fxaRxsko5ucGu zrs0v1Hqc0Mi5ltPdKu/I6VPyWGrimfEqOjp2fKWnVQaZBd289NBbwMjEuAeTQ+lG0Ez7peGgGuq3 lQ5KDal1f2MjlpWPvp4BSTmOZW33teOpuHDvENH9Iz8s8iiSBkkycFK2KEpRf6KAQZ8FTnl5hvfu0 5xB6nCgLweL5O5gZkxPTA6AZ54NAiewVLjV9olj6lGugQjb3U43bu8lt+nKgwCwsr6r4VnmoJXP0p iZ9zm99Z03024cDG7H3uGRTOYA4fBMCfU8mpq355qUTljKQNFQW0fAuFtPs+MtwjKgGIqWrlO9zK2 QMENZhgQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMthR-00EjJS-0d; Fri, 21 Jul 2023 17:13:53 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMthO-00EjHG-0c for linux-riscv@lists.infradead.org; Fri, 21 Jul 2023 17:13:51 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-583a4015791so5041017b3.1 for ; Fri, 21 Jul 2023 10:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=saEUf4445sfHkPWRX975heL8zENfXcs3PgCyCgvEVdQjEpNK/pp+iAjdHt4YEb3A4E Wx6AMp1fx4AxdUC7quE/wuY8PzajpllFI1PSVxa0GJ6TCvZZ95BwZYWsRgoM01BQ4SqE g1i1UMNIUCRiN6vVjQF+QtV7pxLVFxnr+vtjGFTshuCRS/R0Np16E0/qf+bH5mnx7XFz ZsljdMjRbBLWTIazxQedjqyAevMpWeXTTd8MiT3v+VX/sBebfo66Po7WIiS0jw2kNrZS H5psY9S7R0h0zicR7miAPapKCtbYppPvDwh7bNN96b+Zux6kO9omgHgr2n7bbHvjHh23 55GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=Sx/r6ecTqDmcmLD+bh98y2KBNKTD1J82a29qPVVJXX4b7dyim4Epd45H6VznUpiqct fNl2l5lMjROnC5fNGlwbeqc+18mTI48puJmm5s33lwIY7O7kZBD4kida6SMmdVmwgWgg rTSBymSaaVYi6XuBuGrRAX9ZmWgBQN8xjz6rgrzthA3/7AFhGidz4iPcq4dedks5JXkW elay50XqsbUqXCRsZbePNfuIURtNfmM/XEjDPOaUbjg/QOf58JJTQ7UUSA7yVGgcqClP gq/EWkZGSQ8waZxFvm1FgThy/ZeoEaeeZyLGfujkbs4Pgg1NSAOm5kAIL6e/rs3vu41O v/zg== X-Gm-Message-State: ABy/qLYgoR0ROIi3I5QNzh0qjgQvqNIFmc7vHrXMXIRV2b3rtOf7OleT i+rxQnXxKqzCdn5l+2ol5hemrPqXkIM= X-Google-Smtp-Source: APBJJlHTu6oxQip7Fs57WKX81frcXYslN0cZxNmgdAvx9eWDlCTFu1+cjXODNvw8IvlIlsVUOd7h6YXth7Y= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:a28f:0:b0:c6e:fe1a:3657 with SMTP id c15-20020a25a28f000000b00c6efe1a3657mr16139ybi.3.1689959627795; Fri, 21 Jul 2023 10:13:47 -0700 (PDT) Date: Fri, 21 Jul 2023 10:13:46 -0700 In-Reply-To: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Message-ID: Subject: Re: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_101350_228873_67ED8D74 X-CRM114-Status: GOOD ( 10.77 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Fri, Jul 21, 2023, Paolo Bonzini wrote: > On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > > u64 flags = args->flags; > > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > > + > > I think it should be always allowed. The outcome would just be "never have > a hugepage" if thp is not enabled in the kernel. I don't have a strong preference. My thinking was that userspace would probably rather have an explicit error, as opposed to silently running with a misconfigured setup. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EC706EB64DC for ; Fri, 21 Jul 2023 17:14:43 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=saEUf444; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R6x4f33ZHz3c6H for ; Sat, 22 Jul 2023 03:14:42 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=saEUf444; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::114a; helo=mail-yw1-x114a.google.com; envelope-from=3y7y6zaykdfwm84hd6aiiaf8.6igfchorjj6-78pfcmnm.itf45m.ila@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yw1-x114a.google.com (mail-yw1-x114a.google.com [IPv6:2607:f8b0:4864:20::114a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R6x3h4Yg5z3brc for ; Sat, 22 Jul 2023 03:13:51 +1000 (AEST) Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-569e7aec37bso22523387b3.2 for ; Fri, 21 Jul 2023 10:13:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=saEUf4445sfHkPWRX975heL8zENfXcs3PgCyCgvEVdQjEpNK/pp+iAjdHt4YEb3A4E Wx6AMp1fx4AxdUC7quE/wuY8PzajpllFI1PSVxa0GJ6TCvZZ95BwZYWsRgoM01BQ4SqE g1i1UMNIUCRiN6vVjQF+QtV7pxLVFxnr+vtjGFTshuCRS/R0Np16E0/qf+bH5mnx7XFz ZsljdMjRbBLWTIazxQedjqyAevMpWeXTTd8MiT3v+VX/sBebfo66Po7WIiS0jw2kNrZS H5psY9S7R0h0zicR7miAPapKCtbYppPvDwh7bNN96b+Zux6kO9omgHgr2n7bbHvjHh23 55GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=O7EdTWPEYl4rXbSBW1ewH0P2xvHgn4SF5Er4l0+BqQ8zzY6A41sGI2rfH/IPzaiW90 b0RWbzQP1QCjLtrRLhLHh6NvUQl55dJI965TLI7mY5KWZn+mN9b5jGi7yetAqYTWmnI3 YZpCkBDwPf+83J7ZTLmaLuhqGuElYKBfr6fqsAlSgdGk17tYpaJ8TMOuJpApEfEAT2GH Yx3hF/Rpy4TvZR/8OPm9fEbA5CBAtlCVO+EuGXq46lKjuAizO/BrWbhVM01yOZ7/fJ0c BNxqhqKUNURCRerHHxVUw0nyZKhXJPjtu3hP+GcPpiKE21X0nrkLFSkN2vkegQCm7SEy acnw== X-Gm-Message-State: ABy/qLZSG+ZeLIntUkSQHit+KqHf9opUSuMWvs3WlXm8Qwchpn28MEEb aa1RzPjNU2JwfzK5k1CfumBjyGX6j48= X-Google-Smtp-Source: APBJJlHTu6oxQip7Fs57WKX81frcXYslN0cZxNmgdAvx9eWDlCTFu1+cjXODNvw8IvlIlsVUOd7h6YXth7Y= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:a28f:0:b0:c6e:fe1a:3657 with SMTP id c15-20020a25a28f000000b00c6efe1a3657mr16139ybi.3.1689959627795; Fri, 21 Jul 2023 10:13:47 -0700 (PDT) Date: Fri, 21 Jul 2023 10:13:46 -0700 In-Reply-To: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Message-ID: Subject: Re: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory From: Sean Christopherson To: Paolo Bonzini Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , Yu Zhang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Paul Moore , Marc Zyngier , Huacai Chen , James Morris , "Matthew Wilcox \(Oracle\)" , Wang , Fuad Tabba , Jarkko Sakkinen , "Serge E. Hallyn" , Maciej Szmigiero , Albert Ou , Vlastimil Babka , Michael Roth , Ackerley Tng , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Quentin Perret , linux-mips@vger.kernel.org, Oliver Upton , linux-s ecurity-module@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Liam Merwick , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, "Kirill A . Shutemov" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jul 21, 2023, Paolo Bonzini wrote: > On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > > u64 flags = args->flags; > > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > > + > > I think it should be always allowed. The outcome would just be "never have > a hugepage" if thp is not enabled in the kernel. I don't have a strong preference. My thinking was that userspace would probably rather have an explicit error, as opposed to silently running with a misconfigured setup. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 21158EB64DC for ; Fri, 21 Jul 2023 17:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=MST0CezCQhu062PWX2Nb1Y5m3+m9/BL186F7WmNrboo=; b=UhH+7Tttrqy6UNtRYDQciLrr23 ytEl3teDxJMlh0D4itvZL7a4qSPPpSUap1RXZn3IK/mYMGVh7p9Y0hsYj/AHseKbc0xUnbFNXPetn LZvn8ulZoixKDP/EQrtOKkeRNMl9ieSYVy/TS91u1pTnhgzBY8+exAHfizW5fH0+Fo9VHT54hFeV2 Y5RBlRlSiWHqFfXb/qnEMg1uaCcPuD9Vh9TkmMfS7xneIOfxLraL2SsRjA+IAg1MdQMOu/5fQxZf+ LT2UyP65ue5/Wu8Sa1Wn1JruHznoXnrKrUxM4KNF4jdaZKSoK7nobBNqKLwQdTHTSOeubOpFV9UqV iHvWeifw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMthR-00EjJl-2P; Fri, 21 Jul 2023 17:13:53 +0000 Received: from mail-yw1-x1149.google.com ([2607:f8b0:4864:20::1149]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMthN-00EjHF-2w for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 17:13:51 +0000 Received: by mail-yw1-x1149.google.com with SMTP id 00721157ae682-569e7aec37bso22523427b3.2 for ; Fri, 21 Jul 2023 10:13:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=saEUf4445sfHkPWRX975heL8zENfXcs3PgCyCgvEVdQjEpNK/pp+iAjdHt4YEb3A4E Wx6AMp1fx4AxdUC7quE/wuY8PzajpllFI1PSVxa0GJ6TCvZZ95BwZYWsRgoM01BQ4SqE g1i1UMNIUCRiN6vVjQF+QtV7pxLVFxnr+vtjGFTshuCRS/R0Np16E0/qf+bH5mnx7XFz ZsljdMjRbBLWTIazxQedjqyAevMpWeXTTd8MiT3v+VX/sBebfo66Po7WIiS0jw2kNrZS H5psY9S7R0h0zicR7miAPapKCtbYppPvDwh7bNN96b+Zux6kO9omgHgr2n7bbHvjHh23 55GA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689959628; x=1690564428; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=7shZuEDiffXRYK22UXnQcffVUND6wfTW4U7DmHj+BWc=; b=j5Y6gRC+rNd64/gb0DQkfdmUSPmkUXuldzbUSp0wK+rcFdKEHs8s9woi+Q76pG5hz2 Y3jlUl6B/rBWHaaArl55wzJ86wPo6k3w3EztOEeoJKtngFn0pP8YIfF7hbOk+jSwXIcu Z+a8gjGb5M5f6ZVX254VSPNEt/OcXne+l3tyOJybobw4LHdtDW8MhV3UZudneD/AjCRi x3OhXd9h3AXKWXwgnOUyyMoaXwAktNSCU2Pu239QA70yQlDlrJmLt2hH5gCQtZiw6apF ZlQ1+jmE7T3JxY3ZxoV0giIRNzr2uM9hJnbKkHcsMM9hNnA6wUQ0EIPMoMxn0z1kdzsb Pwew== X-Gm-Message-State: ABy/qLYCjsXX2N4/ZQPYmbd7ZZK2qYMeORkVALC6q/35VmPJEPbOw1Zm LzRBAjoi0fFTG6CBA87OSLK4Y0f71mU= X-Google-Smtp-Source: APBJJlHTu6oxQip7Fs57WKX81frcXYslN0cZxNmgdAvx9eWDlCTFu1+cjXODNvw8IvlIlsVUOd7h6YXth7Y= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a25:a28f:0:b0:c6e:fe1a:3657 with SMTP id c15-20020a25a28f000000b00c6efe1a3657mr16139ybi.3.1689959627795; Fri, 21 Jul 2023 10:13:47 -0700 (PDT) Date: Fri, 21 Jul 2023 10:13:46 -0700 In-Reply-To: <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-14-seanjc@google.com> <84a908ae-04c7-51c7-c9a8-119e1933a189@redhat.com> Message-ID: Subject: Re: [RFC PATCH v11 13/29] KVM: Add transparent hugepage support for dedicated guest memory From: Sean Christopherson To: Paolo Bonzini Cc: Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_101349_950646_3EEE8E94 X-CRM114-Status: GOOD ( 12.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Jul 21, 2023, Paolo Bonzini wrote: > On 7/19/23 01:44, Sean Christopherson wrote: > > @@ -413,6 +454,9 @@ int kvm_gmem_create(struct kvm *kvm, struct kvm_create_guest_memfd *args) > > u64 flags = args->flags; > > u64 valid_flags = 0; > > + if (IS_ENABLED(CONFIG_TRANSPARENT_HUGEPAGE)) > > + valid_flags |= KVM_GUEST_MEMFD_ALLOW_HUGEPAGE; > > + > > I think it should be always allowed. The outcome would just be "never have > a hugepage" if thp is not enabled in the kernel. I don't have a strong preference. My thinking was that userspace would probably rather have an explicit error, as opposed to silently running with a misconfigured setup. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel