From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Fri, 21 Jul 2023 10:42:58 -0700 Subject: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory In-Reply-To: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Jul 21, 2023, Xiaoyao Li wrote: > On 7/21/2023 11:05 PM, Xiaoyao Li wrote: > > On 7/19/2023 7:44 AM, Sean Christopherson wrote: > > > @@ -6255,12 +6298,17 @@ int kvm_init(unsigned vcpu_size, unsigned > > > vcpu_align, struct module *module) > > > ????? if (r) > > > ????????? goto err_async_pf; > > > +??? r = kvm_gmem_init(); > > > +??? if (r) > > > +??????? goto err_gmem; > > > + > > > ????? kvm_chardev_ops.owner = module; > > > ????? kvm_preempt_ops.sched_in = kvm_sched_in; > > > ????? kvm_preempt_ops.sched_out = kvm_sched_out; > > > ????? kvm_init_debug(); > > > +??? kvm_gmem_init(); > > > > why kvm_gmem_init() needs to be called again? by mistake? > > I'm sure it's a mistake. Yeah, definitely a bug. > I'm testing the gmem QEMU with this series. SW_PROTECTED_VM gets stuck in a > loop in early OVMF code due to two shared page of OVMF get zapped and > re-mapped infinitely. Removing the second call of kvm_gmem_init() can solve > the issue, though I'm not sure about the reason. Not worth investigating unless you want to satiate your curiosity :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 00CBC27F00 for ; Fri, 21 Jul 2023 17:43:00 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-c8f360a07a2so2020444276.2 for ; Fri, 21 Jul 2023 10:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=Kleh8QpsTsNUhesVcFKaorRemH2b7oCPrjs/EZvvDbSIhnU646cwazqZifDUNyxi+Q 5JqV9CUAW8QaG2YIfQCin1qnHve1MgXICSxbyDPLV8MjQRP2Kpasi9pL5sbB8O7UYjBa jgRp3U3UDnkkD6e19TR7wMGjHPVEilwKuPvhlll1BPS6C8DVpWehyFU2WczctGneBM1v 8h/JnmhFLy8tlfXVq6NzVrFmSK26MkEiOaRidvtVK6eqi9qhd/VP0gDfCAxADqhE52gi 5Uc2vJ9HkSFyp91F1M5r9W96Us+3KtG0sWvhTTO0jFsQ1GbEx81tOU6Kjmmi3SIi/0Fk yy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=j7nnhVvAwV2ocLBtXnIjxF2TdpGP0v2gcPuSEKDHBz9lVvLyBruwZMgEIFIlBILolX aag9I8NlPvk3WnHVamkM/2fSs46TO+6VflU8jYmI4Ym4RplOSd2mKQorykIQSY7FpPT4 yXNp4XelHm2KVbh9CdtE/KSLGrYaa05qNWEIDhOA/wTliaatwDR3w9ZI76CBOIiER0ZU Fc3YcmdCnXYcJYC1sqrHe+o3UeGoaVsvPOejs4JYy+f5/OS4WGWUln8t3PUQrLteB5Eg lecwIwYZUxNwmeIJ09fonTzanY1fL6kQ3PBBohlRg8a4HzP2TLZun83DDw+/jCDA4NY1 HsNw== X-Gm-Message-State: ABy/qLYV5zlrXYTWXJ8QuegCq6zP66Y4yFTqdDYBWVlMl0/P/sM0ZqRB N5AbpCDQX0MdvAlWEaNka09gtqkf8C8= X-Google-Smtp-Source: APBJJlE/aF1pYHHKoAMy1+E4aY5+aL4FeQDb+p2ML0zhZVvr/Ah+OV80Lx1tRjSoeSb0qOhWhlHbRbztBVY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10cd:b0:c1c:df23:44ee with SMTP id w13-20020a05690210cd00b00c1cdf2344eemr19665ybu.0.1689961379855; Fri, 21 Jul 2023 10:42:59 -0700 (PDT) Date: Fri, 21 Jul 2023 10:42:58 -0700 In-Reply-To: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Message-ID: Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Jul 21, 2023, Xiaoyao Li wrote: > On 7/21/2023 11:05 PM, Xiaoyao Li wrote: > > On 7/19/2023 7:44 AM, Sean Christopherson wrote: > > > @@ -6255,12 +6298,17 @@ int kvm_init(unsigned vcpu_size, unsigned > > > vcpu_align, struct module *module) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (r) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto err_async= _pf; > > > +=C2=A0=C2=A0=C2=A0 r =3D kvm_gmem_init(); > > > +=C2=A0=C2=A0=C2=A0 if (r) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto err_gmem; > > > + > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_chardev_ops.owner =3D module; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_preempt_ops.sched_in =3D kvm_sched= _in; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_preempt_ops.sched_out =3D kvm_sche= d_out; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_init_debug(); > > > +=C2=A0=C2=A0=C2=A0 kvm_gmem_init(); > >=20 > > why kvm_gmem_init() needs to be called again? by mistake? >=20 > I'm sure it's a mistake. Yeah, definitely a bug. > I'm testing the gmem QEMU with this series. SW_PROTECTED_VM gets stuck in= a > loop in early OVMF code due to two shared page of OVMF get zapped and > re-mapped infinitely. Removing the second call of kvm_gmem_init() can sol= ve > the issue, though I'm not sure about the reason. Not worth investigating unless you want to satiate your curiosity :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8E4C4C00528 for ; Fri, 21 Jul 2023 17:43:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=o5Fp0pkDkvWzDsbDw8quGaMQJDwBiKx/d1CoTBG5JR8=; b=WzrQ++6Xo3C3uEMDPxWaCDLj0o OT40h0CWrYFkeFbMfYw4OQCtQalyJUrg7sHfL+eCTFi5tarRY9LpiB4iDrOZBIxrBqIuocKS1KUfN tRByjksJLFoV7T/uqWvMnF9Nm/uSvHdeXXvh+6SRNEfcwjF8QQVyJ48exyhoaTGWx8xKJZqoZG4WU mnK9KAK7ZMYOnncwerZ1xmo1mGPDK6m034e4u5lNw0ZU6nTIIFDsBpffsPBJRUw9ROrKL3K+uUxbM c3zubPknk/FMWyHN0A9U3QHBf5laNzApEWNk90uJaOY1iFwMVcHBzwq37KLVZOgLNYmQb+B8FD/r0 KEQGiudA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMu9f-00Em6W-26; Fri, 21 Jul 2023 17:43:03 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMu9c-00Em5A-3C for linux-riscv@lists.infradead.org; Fri, 21 Jul 2023 17:43:02 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d00a63fcdefso1470335276.3 for ; Fri, 21 Jul 2023 10:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=Kleh8QpsTsNUhesVcFKaorRemH2b7oCPrjs/EZvvDbSIhnU646cwazqZifDUNyxi+Q 5JqV9CUAW8QaG2YIfQCin1qnHve1MgXICSxbyDPLV8MjQRP2Kpasi9pL5sbB8O7UYjBa jgRp3U3UDnkkD6e19TR7wMGjHPVEilwKuPvhlll1BPS6C8DVpWehyFU2WczctGneBM1v 8h/JnmhFLy8tlfXVq6NzVrFmSK26MkEiOaRidvtVK6eqi9qhd/VP0gDfCAxADqhE52gi 5Uc2vJ9HkSFyp91F1M5r9W96Us+3KtG0sWvhTTO0jFsQ1GbEx81tOU6Kjmmi3SIi/0Fk yy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=kIe++xNGOoqRP5BX3v5pZFF22goiwkVivxY7xNrPl4JB0qm4bW9b0hJ4d1eNUmUS9r 8FQBfaLD8BnVlJQAAOjglCSA29K8vLBHoRDXlgMI1q0EPRjulZv1hgVXlzh1DJtkNSVn tcJjoA9EpftqPad2/QnWnI9RIYusU/bysQg+jfMHssgBBEDSpEuVj0sDkgo2pVmzi9CY FdvGrSPReMojbGwXTEEmDUNfydEx2xBpjDnt/ylUYq170Y2M2hfAB1i01A48Ohu07QEp 8lKrA4oyk3n/N0TT72QxUVwFXu0+xnUAOcObclyfOFDOal55v0024usKYQYWpUpBzEbs qMcg== X-Gm-Message-State: ABy/qLbid9zujYC8g5iJPezFaMp23UqF6KMkDSYLWx92QXSDRYbPDf2u g86iu9+1OSqoJI4lzdwxepFXKMt7yWg= X-Google-Smtp-Source: APBJJlE/aF1pYHHKoAMy1+E4aY5+aL4FeQDb+p2ML0zhZVvr/Ah+OV80Lx1tRjSoeSb0qOhWhlHbRbztBVY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10cd:b0:c1c:df23:44ee with SMTP id w13-20020a05690210cd00b00c1cdf2344eemr19665ybu.0.1689961379855; Fri, 21 Jul 2023 10:42:59 -0700 (PDT) Date: Fri, 21 Jul 2023 10:42:58 -0700 In-Reply-To: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Message-ID: Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_104301_026978_7622388B X-CRM114-Status: GOOD ( 12.27 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdWwgMjEsIDIwMjMsIFhpYW95YW8gTGkgd3JvdGU6Cj4gT24gNy8yMS8yMDIzIDEx OjA1IFBNLCBYaWFveWFvIExpIHdyb3RlOgo+ID4gT24gNy8xOS8yMDIzIDc6NDQgQU0sIFNlYW4g Q2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiA+IEBAIC02MjU1LDEyICs2Mjk4LDE3IEBAIGludCBr dm1faW5pdCh1bnNpZ25lZCB2Y3B1X3NpemUsIHVuc2lnbmVkCj4gPiA+IHZjcHVfYWxpZ24sIHN0 cnVjdCBtb2R1bGUgKm1vZHVsZSkKPiA+ID4gwqDCoMKgwqDCoCBpZiAocikKPiA+ID4gwqDCoMKg wqDCoMKgwqDCoMKgIGdvdG8gZXJyX2FzeW5jX3BmOwo+ID4gPiArwqDCoMKgIHIgPSBrdm1fZ21l bV9pbml0KCk7Cj4gPiA+ICvCoMKgwqAgaWYgKHIpCj4gPiA+ICvCoMKgwqDCoMKgwqDCoCBnb3Rv IGVycl9nbWVtOwo+ID4gPiArCj4gPiA+IMKgwqDCoMKgwqAga3ZtX2NoYXJkZXZfb3BzLm93bmVy ID0gbW9kdWxlOwo+ID4gPiDCoMKgwqDCoMKgIGt2bV9wcmVlbXB0X29wcy5zY2hlZF9pbiA9IGt2 bV9zY2hlZF9pbjsKPiA+ID4gwqDCoMKgwqDCoCBrdm1fcHJlZW1wdF9vcHMuc2NoZWRfb3V0ID0g a3ZtX3NjaGVkX291dDsKPiA+ID4gwqDCoMKgwqDCoCBrdm1faW5pdF9kZWJ1ZygpOwo+ID4gPiAr wqDCoMKgIGt2bV9nbWVtX2luaXQoKTsKPiA+IAo+ID4gd2h5IGt2bV9nbWVtX2luaXQoKSBuZWVk cyB0byBiZSBjYWxsZWQgYWdhaW4/IGJ5IG1pc3Rha2U/Cj4gCj4gSSdtIHN1cmUgaXQncyBhIG1p c3Rha2UuCgpZZWFoLCBkZWZpbml0ZWx5IGEgYnVnLgoKPiBJJ20gdGVzdGluZyB0aGUgZ21lbSBR RU1VIHdpdGggdGhpcyBzZXJpZXMuIFNXX1BST1RFQ1RFRF9WTSBnZXRzIHN0dWNrIGluIGEKPiBs b29wIGluIGVhcmx5IE9WTUYgY29kZSBkdWUgdG8gdHdvIHNoYXJlZCBwYWdlIG9mIE9WTUYgZ2V0 IHphcHBlZCBhbmQKPiByZS1tYXBwZWQgaW5maW5pdGVseS4gUmVtb3ZpbmcgdGhlIHNlY29uZCBj YWxsIG9mIGt2bV9nbWVtX2luaXQoKSBjYW4gc29sdmUKPiB0aGUgaXNzdWUsIHRob3VnaCBJJ20g bm90IHN1cmUgYWJvdXQgdGhlIHJlYXNvbi4KCk5vdCB3b3J0aCBpbnZlc3RpZ2F0aW5nIHVubGVz cyB5b3Ugd2FudCB0byBzYXRpYXRlIHlvdXIgY3VyaW9zaXR5IDotKQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0 CmxpbnV4LXJpc2N2QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2B618EB64DD for ; Fri, 21 Jul 2023 17:43:54 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=Kleh8Qps; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4R6xkJ4rPHz3cWQ for ; Sat, 22 Jul 2023 03:43:52 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=Kleh8Qps; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::b4a; helo=mail-yb1-xb4a.google.com; envelope-from=3o8o6zaykdeiwierngksskpi.gsqpmry1ttg-hizpmwxw.s3pefw.svk@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yb1-xb4a.google.com (mail-yb1-xb4a.google.com [IPv6:2607:f8b0:4864:20::b4a]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4R6xjL0l25z3c5H for ; Sat, 22 Jul 2023 03:43:01 +1000 (AEST) Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-c8f360a07a2so2020447276.2 for ; Fri, 21 Jul 2023 10:43:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=Kleh8QpsTsNUhesVcFKaorRemH2b7oCPrjs/EZvvDbSIhnU646cwazqZifDUNyxi+Q 5JqV9CUAW8QaG2YIfQCin1qnHve1MgXICSxbyDPLV8MjQRP2Kpasi9pL5sbB8O7UYjBa jgRp3U3UDnkkD6e19TR7wMGjHPVEilwKuPvhlll1BPS6C8DVpWehyFU2WczctGneBM1v 8h/JnmhFLy8tlfXVq6NzVrFmSK26MkEiOaRidvtVK6eqi9qhd/VP0gDfCAxADqhE52gi 5Uc2vJ9HkSFyp91F1M5r9W96Us+3KtG0sWvhTTO0jFsQ1GbEx81tOU6Kjmmi3SIi/0Fk yy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=Hy4hps6AnZz8YRkd49WDgTitPfe5kYyJhiMzP7KF2hbQzNdnhBLpU5QmzDjMoRnCLE /TAqYUbnp7zeY1mzxtEOoADc6X9Dz49zuSEVoiwVF8Dov6qLp9lzvxEVpwhYN30xCThg mh27J/bPmqRoT7RkyE9HEuydL2A2Xgrl6cJaYbxW1BXIs03mXry8oVwm4gT4W84tF2rM Jld4k+ULKSOwG3vpO5GycdIq2jvgNResQwKbmbIkJxdqofRJaxYwMtITaxOsQmnaDh+g FlTR6F+fDfFOXHfBe1MJMHEy0AE7xhO7jZrNhsv2lvNWEw/axfn0v3Fu8LnG4H5NgDYl ROxA== X-Gm-Message-State: ABy/qLY6lTsBLVdbW57MbQtU/m3D9myoPizJtmFuCfcdJyhExkprlR/R HSIX5aG30Edkl+ESrkuxhjwt1DaXle8= X-Google-Smtp-Source: APBJJlE/aF1pYHHKoAMy1+E4aY5+aL4FeQDb+p2ML0zhZVvr/Ah+OV80Lx1tRjSoeSb0qOhWhlHbRbztBVY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10cd:b0:c1c:df23:44ee with SMTP id w13-20020a05690210cd00b00c1cdf2344eemr19665ybu.0.1689961379855; Fri, 21 Jul 2023 10:42:59 -0700 (PDT) Date: Fri, 21 Jul 2023 10:42:58 -0700 In-Reply-To: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Message-ID: Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory From: Sean Christopherson To: Xiaoyao Li Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, David Hildenbrand , Yu Zhang , linux-kernel@vger.kernel.org, linux-mm@kvack.org, Chao Peng , linux-riscv@lists.infradead.org, Isaku Yamahata , Paul Moore , Marc Zyngier , Huacai Chen , James Morris , "Matthew Wilcox \(Oracle\)" , Wang , Fuad Tabba , Jarkko Sakkinen , "Serge E. Hallyn" , Maciej Szmigiero , Albert Ou , Vlastimil Babka , Michael Roth , Ackerley Tng , Paul Walmsley , kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, Quentin Perret , Liam Merwick , linux-mips@vger.kernel.org, Oliver Upton , linux-security-module@vger.kernel.org, Palmer Dabbelt , kvm-riscv@lists.infradead.org, Anup Patel , linux-fsdevel@vger.kernel.org, Paolo Bonzini , Andrew Morton , Vishal Annapurve , linuxppc-dev@lists.ozlabs.org, "Kirill A . Shutemov" Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Fri, Jul 21, 2023, Xiaoyao Li wrote: > On 7/21/2023 11:05 PM, Xiaoyao Li wrote: > > On 7/19/2023 7:44 AM, Sean Christopherson wrote: > > > @@ -6255,12 +6298,17 @@ int kvm_init(unsigned vcpu_size, unsigned > > > vcpu_align, struct module *module) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 if (r) > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto err_async= _pf; > > > +=C2=A0=C2=A0=C2=A0 r =3D kvm_gmem_init(); > > > +=C2=A0=C2=A0=C2=A0 if (r) > > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 goto err_gmem; > > > + > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_chardev_ops.owner =3D module; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_preempt_ops.sched_in =3D kvm_sched= _in; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_preempt_ops.sched_out =3D kvm_sche= d_out; > > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 kvm_init_debug(); > > > +=C2=A0=C2=A0=C2=A0 kvm_gmem_init(); > >=20 > > why kvm_gmem_init() needs to be called again? by mistake? >=20 > I'm sure it's a mistake. Yeah, definitely a bug. > I'm testing the gmem QEMU with this series. SW_PROTECTED_VM gets stuck in= a > loop in early OVMF code due to two shared page of OVMF get zapped and > re-mapped infinitely. Removing the second call of kvm_gmem_init() can sol= ve > the issue, though I'm not sure about the reason. Not worth investigating unless you want to satiate your curiosity :-) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 94341EB64DD for ; Fri, 21 Jul 2023 17:43:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=wHT84azzzg7lmRg4GxvtnxbHbeRbG8MZArV66i/Tou0=; b=kQoyoQo0h3N8BM/7BJwZUCK1JX UfKha0ofAIKb/kdcPcBHepiJ4Z0RhaEUCI3JQytQU3OOLwxsn5lRoK7KKoLaS4IXFQ71apqLWqoyI /xFAZxZVFO80NNdNooKffYe83zhacnLqV56bI+quTGE0dkesu96iUbDkADmN2TH5e3h7scBqK7Uai Br55DLSGiTS1U24ZU/aEOrruisn6Fln79IYc8J2Z7nMCpO0rtiwJPlpaXDkUxFo9fCQGYx2/cEBYz 78TekJnA3CzCp4Be577pX3Ai3mqnbcCdv9jne5G8VVGe94G3M22f5lGCAamCVZTX5Inish2aytrG7 NSyeWIUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qMu9h-00Em7Y-20; Fri, 21 Jul 2023 17:43:05 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qMu9d-00Em57-0u for linux-arm-kernel@lists.infradead.org; Fri, 21 Jul 2023 17:43:03 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d00a63fcdefso1470332276.3 for ; Fri, 21 Jul 2023 10:43:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=Kleh8QpsTsNUhesVcFKaorRemH2b7oCPrjs/EZvvDbSIhnU646cwazqZifDUNyxi+Q 5JqV9CUAW8QaG2YIfQCin1qnHve1MgXICSxbyDPLV8MjQRP2Kpasi9pL5sbB8O7UYjBa jgRp3U3UDnkkD6e19TR7wMGjHPVEilwKuPvhlll1BPS6C8DVpWehyFU2WczctGneBM1v 8h/JnmhFLy8tlfXVq6NzVrFmSK26MkEiOaRidvtVK6eqi9qhd/VP0gDfCAxADqhE52gi 5Uc2vJ9HkSFyp91F1M5r9W96Us+3KtG0sWvhTTO0jFsQ1GbEx81tOU6Kjmmi3SIi/0Fk yy7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689961380; x=1690566180; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=7DBmD+NWofmGocm5Vnh+WkykM6ONviwwjpnheMJOIK8=; b=WoxTy5+qGJ22GiIZ4uK7SM+VNe+SPumnpmU1lmmPerQZgNKJm5UJPPTyMHDEl4g8bi m9lkBFwbDrDkvkxRJl4xFzl+Fh0UmTtfUdCyXyutPg4HYgqqBEREWbA12jkBswBF646p 1DvwLvQqb7ExOkv3tLH5yZfmmnaGa6Hf+CTiWcFlqTczFHctDmvKHv5Y2JqbgLsXq9IM b6NZTWWygd7aNarzbhsEtl8v5fo3Qxvb8rdM99Ko8ut0H4A6F4WucPTNkMvTqnDEFAje uJGrrO4S5YU3+DOlZMDB72axr/PsbgVjj3L+IanOkc9wYhiaiGCH9lncK/P6joP8Jda9 eyxw== X-Gm-Message-State: ABy/qLYCpduxQlCjA8Bhkup21y/n1SH+wxXa/meJoeZm0hz7t1UFUxl2 xhbPQw6JGQ+E/3JPJDehnJ7XCnEsDp4= X-Google-Smtp-Source: APBJJlE/aF1pYHHKoAMy1+E4aY5+aL4FeQDb+p2ML0zhZVvr/Ah+OV80Lx1tRjSoeSb0qOhWhlHbRbztBVY= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:10cd:b0:c1c:df23:44ee with SMTP id w13-20020a05690210cd00b00c1cdf2344eemr19665ybu.0.1689961379855; Fri, 21 Jul 2023 10:42:59 -0700 (PDT) Date: Fri, 21 Jul 2023 10:42:58 -0700 In-Reply-To: <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Mime-Version: 1.0 References: <20230718234512.1690985-1-seanjc@google.com> <20230718234512.1690985-13-seanjc@google.com> <29baac45-7736-a28c-3b2d-2a6e45171b8b@intel.com> Message-ID: Subject: Re: [RFC PATCH v11 12/29] KVM: Add KVM_CREATE_GUEST_MEMFD ioctl() for guest-specific backing memory From: Sean Christopherson To: Xiaoyao Li Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , "Matthew Wilcox (Oracle)" , Andrew Morton , Paul Moore , James Morris , "Serge E. Hallyn" , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, Chao Peng , Fuad Tabba , Jarkko Sakkinen , Yu Zhang , Vishal Annapurve , Ackerley Tng , Maciej Szmigiero , Vlastimil Babka , David Hildenbrand , Quentin Perret , Michael Roth , Wang , Liam Merwick , Isaku Yamahata , "Kirill A . Shutemov" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230721_104301_321255_4ADB4341 X-CRM114-Status: GOOD ( 13.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBKdWwgMjEsIDIwMjMsIFhpYW95YW8gTGkgd3JvdGU6Cj4gT24gNy8yMS8yMDIzIDEx OjA1IFBNLCBYaWFveWFvIExpIHdyb3RlOgo+ID4gT24gNy8xOS8yMDIzIDc6NDQgQU0sIFNlYW4g Q2hyaXN0b3BoZXJzb24gd3JvdGU6Cj4gPiA+IEBAIC02MjU1LDEyICs2Mjk4LDE3IEBAIGludCBr dm1faW5pdCh1bnNpZ25lZCB2Y3B1X3NpemUsIHVuc2lnbmVkCj4gPiA+IHZjcHVfYWxpZ24sIHN0 cnVjdCBtb2R1bGUgKm1vZHVsZSkKPiA+ID4gwqDCoMKgwqDCoCBpZiAocikKPiA+ID4gwqDCoMKg wqDCoMKgwqDCoMKgIGdvdG8gZXJyX2FzeW5jX3BmOwo+ID4gPiArwqDCoMKgIHIgPSBrdm1fZ21l bV9pbml0KCk7Cj4gPiA+ICvCoMKgwqAgaWYgKHIpCj4gPiA+ICvCoMKgwqDCoMKgwqDCoCBnb3Rv IGVycl9nbWVtOwo+ID4gPiArCj4gPiA+IMKgwqDCoMKgwqAga3ZtX2NoYXJkZXZfb3BzLm93bmVy ID0gbW9kdWxlOwo+ID4gPiDCoMKgwqDCoMKgIGt2bV9wcmVlbXB0X29wcy5zY2hlZF9pbiA9IGt2 bV9zY2hlZF9pbjsKPiA+ID4gwqDCoMKgwqDCoCBrdm1fcHJlZW1wdF9vcHMuc2NoZWRfb3V0ID0g a3ZtX3NjaGVkX291dDsKPiA+ID4gwqDCoMKgwqDCoCBrdm1faW5pdF9kZWJ1ZygpOwo+ID4gPiAr wqDCoMKgIGt2bV9nbWVtX2luaXQoKTsKPiA+IAo+ID4gd2h5IGt2bV9nbWVtX2luaXQoKSBuZWVk cyB0byBiZSBjYWxsZWQgYWdhaW4/IGJ5IG1pc3Rha2U/Cj4gCj4gSSdtIHN1cmUgaXQncyBhIG1p c3Rha2UuCgpZZWFoLCBkZWZpbml0ZWx5IGEgYnVnLgoKPiBJJ20gdGVzdGluZyB0aGUgZ21lbSBR RU1VIHdpdGggdGhpcyBzZXJpZXMuIFNXX1BST1RFQ1RFRF9WTSBnZXRzIHN0dWNrIGluIGEKPiBs b29wIGluIGVhcmx5IE9WTUYgY29kZSBkdWUgdG8gdHdvIHNoYXJlZCBwYWdlIG9mIE9WTUYgZ2V0 IHphcHBlZCBhbmQKPiByZS1tYXBwZWQgaW5maW5pdGVseS4gUmVtb3ZpbmcgdGhlIHNlY29uZCBj YWxsIG9mIGt2bV9nbWVtX2luaXQoKSBjYW4gc29sdmUKPiB0aGUgaXNzdWUsIHRob3VnaCBJJ20g bm90IHN1cmUgYWJvdXQgdGhlIHJlYXNvbi4KCk5vdCB3b3J0aCBpbnZlc3RpZ2F0aW5nIHVubGVz cyB5b3Ugd2FudCB0byBzYXRpYXRlIHlvdXIgY3VyaW9zaXR5IDotKQoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5n IGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5p bmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=