From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:906:2484:b0:98d:b2f5:1316 with SMTP id e4csp26909ejb; Tue, 25 Jul 2023 11:37:17 -0700 (PDT) X-Google-Smtp-Source: APBJJlFHgkKvejJOdKAHVN6ZutURQ0OZ0pj2cxaPS8OTj12R0TtwmD1o1CLXcd5nOJ5LfBGQKNEA X-Received: by 2002:a05:6358:88d:b0:135:5da6:d303 with SMTP id m13-20020a056358088d00b001355da6d303mr12881969rwj.5.1690310236724; Tue, 25 Jul 2023 11:37:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1690310236; cv=none; d=google.com; s=arc-20160816; b=G23xxD83uvqa3kQirRbobH0Pyw2JqON0voJcbqV7eqYL2IeBHKXNJVx8J7ViQtDYjU o6rn5Ee377GtzTqO5XJe8jNwSTbO60A6De8jBo4oN0tgXusfUau7dgIpTM7TM5QwxxoQ B/HcwD7rLDdyvrGLbROxuvKcKtCsCfgUBqlyxm7S9+PmQCVjFDDRMQFo9rXLSntdtp6u sWWhmttYwvtI5Y5F5K4M4eesh0/0fPrw9j7CwF6bs0FqzoE1c1Xq75lEsAdmliE+oI+C /JTwG4tS/gKe3wg1d4YcLkTzzACBbkPuVMMrrm5HUhWkTa02z1ZogPbZTirM2V+I6Z1a +FZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=sender:errors-to:reply-to:list-subscribe:list-help:list-post :list-archive:list-unsubscribe:list-id:precedence:user-agent :in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :dkim-signature; bh=SzycErlJrf/u1fYB3xTO9GVxHed6fEJoe+Em7YJNPyo=; fh=zLQERmDA5TGOuXtIamHC2vUF6ncw0A4+dsMvQHS1arc=; b=yAIdCRhr/F5XKcz4sTxHcvoitASu6isw2NznG/jcRHz7YDxjx01Is4vKZQtHC+7Wv0 jp0c2KBBBIirlR+Izcf/Lv7p5z85Oy/NbYWUcwk9pnijlf0FNdeqqBICYheWkgV0aw/D 90f3MPxygxrcorpGMGbntUuTB5+xGkfwEZJAGs0rmseXg/sXxfV1Awg/oNGdZlT8XNus gGMa+fMqUkZysNuRefmni0SA0z7Bqv3Cf9FEVq+/G54j2pRiBVhcDJJxkHlYHpBiFLGl 2iNV0mxxChSb/jlLLxWzIRohaNe6uSHzzQeMtnm1jQafAlzRTGtrcA5ZCwurribN5OEX Ps+A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RDsYMQaq; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id g22-20020ac87f56000000b0040349a5a1acsi6807957qtk.134.2023.07.25.11.37.16 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 25 Jul 2023 11:37:16 -0700 (PDT) Received-SPF: pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=RDsYMQaq; spf=pass (google.com: domain of qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOMtr-0006B6-JE; Tue, 25 Jul 2023 14:36:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOMtp-0006AR-JU for qemu-devel@nongnu.org; Tue, 25 Jul 2023 14:36:46 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOMtn-0000Ld-Ta for qemu-devel@nongnu.org; Tue, 25 Jul 2023 14:36:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690310203; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SzycErlJrf/u1fYB3xTO9GVxHed6fEJoe+Em7YJNPyo=; b=RDsYMQaqVtjhTnb3yrtkdBhA1qB7exezkA9EGIMkqO93pWK5gR5r/EUY4W4BQktNNs7O45 is4waWlH+E9Rk4knssQaIVEeeGvJrzMb9rkD0XS+1Sxv6Knf00gZUHbXyJKR2k1s1+ETrl r2ztjo1Oj6zh42srIb2+pxtezuXXtTw= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-631-x2FbUYyeOtiTz8UNJm8R1g-1; Tue, 25 Jul 2023 14:36:40 -0400 X-MC-Unique: x2FbUYyeOtiTz8UNJm8R1g-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 82B79857FF8; Tue, 25 Jul 2023 18:36:39 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.133]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 98CFA2166B25; Tue, 25 Jul 2023 18:36:37 +0000 (UTC) Date: Tue, 25 Jul 2023 19:36:35 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: John Snow Cc: qemu-devel@nongnu.org, =?utf-8?Q?C=C3=A9dric?= Le Goater , Hanna Reitz , Ani Sinha , Cleber Rosa , Wainer dos Santos Moschetta , qemu-arm@nongnu.org, qemu-block@nongnu.org, Andrew Jeffery , Joel Stanley , Kevin Wolf , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= , Beraldo Leal , Peter Maydell , "Michael S. Tsirkin" Subject: Re: [PATCH v2 6/6] python/machine: remove unused sock_dir argument Message-ID: References: <20230725180337.2937292-1-jsnow@redhat.com> <20230725180337.2937292-7-jsnow@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 Received-SPF: pass client-ip=170.10.129.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=unavailable autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-devel-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: dgeuuy7plBtc On Tue, Jul 25, 2023 at 02:33:36PM -0400, John Snow wrote: > On Tue, Jul 25, 2023 at 2:26 PM Daniel P. Berrangé wrote: > > > > On Tue, Jul 25, 2023 at 02:03:37PM -0400, John Snow wrote: > > > By using a socketpair for all of the sockets managed by the VM class and > > > its extensions, we don't need the sock_dir argument anymore, so remove > > > it. > > > > > > We only added this argument so that we could specify a second, shorter > > > temporary directory for cases where the temp/log dirs were "too long" as > > > a socket name on macOS. We don't need it for this class now. In one > > > case, avocado testing takes over responsibility for creating an > > > appropriate sockdir. > > > > > > Signed-off-by: John Snow > > > --- > > > python/qemu/machine/machine.py | 18 ------------------ > > > python/qemu/machine/qtest.py | 5 +---- > > > tests/avocado/acpi-bits.py | 5 +---- > > > tests/avocado/avocado_qemu/__init__.py | 2 +- > > > tests/avocado/machine_aspeed.py | 5 ++++- > > > tests/qemu-iotests/iotests.py | 2 +- > > > tests/qemu-iotests/tests/copy-before-write | 3 +-- > > > 7 files changed, 9 insertions(+), 31 deletions(-) > > > > Reviewed-by: Daniel P. Berrangé > > > > Thanks! > > I don't know if we want this for *this* cycle or not, it's "only > testing code" and it should hopefully be harmless. If it makes the > tests more reliable, it might be worth it. I don't have strong > feelings one way or the other, we've lived without it for so long > as-is. > > I'll see what Peter says. Although it does affect end users, the biggest impact is our own CI. Once the release is out it would help CI on stable trees, but the big win is CI on master. I'd verge towards skipping this during freeze and applying to master after release. Then propose cherry-pick to stable once it has had some soak time in our real CI. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|