From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7B9FDC0015E for ; Wed, 26 Jul 2023 15:11:28 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qOfMj-0003ud-Nw; Wed, 26 Jul 2023 10:19:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOfKA-0002aw-RK for qemu-devel@nongnu.org; Wed, 26 Jul 2023 10:17:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qOfK8-0000IK-P2 for qemu-devel@nongnu.org; Wed, 26 Jul 2023 10:17:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1690381026; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=kBLljprdxgJv4fIBNdNVazaz3wYEc+mOpWfZdoDVsfI=; b=dYPwcz83AUYbIhZAN26r3tY6gq1NGz6XVK87am0ZegRyiNxviBoC6xWdp0br1WVNUwJNYA 8YK+/OwiQr7CiTJChrI0WNaSs8Ab2ZMg87Bw339v+FGQRecd+Zxm5BZ+2csCNOUogqfXqp /Z45x+fdw7/UyjBP0mdLIePRmk8YOtw= Received: from mimecast-mx02.redhat.com (66.187.233.73 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-624-yPMOVY0dM-GEZuqeQgbKIQ-1; Wed, 26 Jul 2023 10:17:05 -0400 X-MC-Unique: yPMOVY0dM-GEZuqeQgbKIQ-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8BBC73C147E6; Wed, 26 Jul 2023 14:17:04 +0000 (UTC) Received: from redhat.com (unknown [10.42.28.52]) by smtp.corp.redhat.com (Postfix) with ESMTPS id D56A2492B01; Wed, 26 Jul 2023 14:17:03 +0000 (UTC) Date: Wed, 26 Jul 2023 15:17:01 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= To: Peter Maydell Cc: quintela@redhat.com, qemu-devel@nongnu.org, richard.henderson@linaro.org Subject: Re: How to tame CI? Message-ID: References: <87fs5aho6e.fsf@secure.mitica> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/2.2.9 (2022-11-12) X-Scanned-By: MIMEDefang 3.1 on 10.11.54.9 Received-SPF: pass client-ip=170.10.133.124; envelope-from=berrange@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Wed, Jul 26, 2023 at 02:00:03PM +0100, Peter Maydell wrote: > On Wed, 26 Jul 2023 at 13:06, Juan Quintela wrote: > > To make things easier, this is the part that show how it breaks (this is > > the gcov test): > > > > 357/423 qemu:block / io-qcow2-copy-before-write ERROR 6.38s exit status 1 > > >>> PYTHON=/builds/juan.quintela/qemu/build/pyvenv/bin/python3 MALLOC_PERTURB_=44 /builds/juan.quintela/qemu/build/pyvenv/bin/python3 /builds/juan.quintela/qemu/build/../tests/qemu-iotests/check -tap -qcow2 copy-before-write --source-dir /builds/juan.quintela/qemu/tests/qemu-iotests --build-dir /builds/juan.quintela/qemu/build/tests/qemu-iotests > > ――――――――――――――――――――――――――――――――――――― ✀ ――――――――――――――――――――――――――――――――――――― > > stderr: > > --- /builds/juan.quintela/qemu/tests/qemu-iotests/tests/copy-before-write.out > > +++ /builds/juan.quintela/qemu/build/scratch/qcow2-file-copy-before-write/copy-before-write.out.bad > > @@ -1,5 +1,21 @@ > > -.... > > +...F > > +====================================================================== > > +FAIL: test_timeout_break_snapshot (__main__.TestCbwError) > > +---------------------------------------------------------------------- > > +Traceback (most recent call last): > > + File "/builds/juan.quintela/qemu/tests/qemu-iotests/tests/copy-before-write", line 210, in test_timeout_break_snapshot > > + self.assertEqual(log, """\ > > +AssertionError: 'wrot[195 chars]read 1048576/1048576 bytes at offset 0\n1 MiB,[46 chars]c)\n' != 'wrot[195 chars]read failed: Permission denied\n' > > + wrote 524288/524288 bytes at offset 0 > > + 512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > + wrote 524288/524288 bytes at offset 524288 > > + 512 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > ++ read failed: Permission denied > > +- read 1048576/1048576 bytes at offset 0 > > +- 1 MiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec) > > + > > This iotest failing is an intermittent that I've seen running > pullreqs on master. I tend to see it on the s390 host. I > suspect a race condition somewhere where it fails if the host > is heavily loaded. Since it is known flakey, we should just commit the change --- a/tests/qemu-iotests/tests/copy-before-write +++ b/tests/qemu-iotests/tests/copy-before-write @@ -1,5 +1,5 @@ #!/usr/bin/env python3 -# group: auto backup +# group: backup # # Copyright (c) 2022 Virtuozzo International GmbH # and if someone wants to re-enable it, they get the job of fixing its reliability first. With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|