From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from alsa0.perex.cz (alsa0.perex.cz [77.48.224.243]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 34CD6C001DC for ; Wed, 26 Jul 2023 16:29:31 +0000 (UTC) Received: from alsa1.perex.cz (alsa1.perex.cz [207.180.221.201]) (using TLSv1.2 with cipher ADH-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa0.perex.cz (Postfix) with ESMTPS id F1B1783A; Wed, 26 Jul 2023 18:28:38 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa0.perex.cz F1B1783A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=alsa-project.org; s=default; t=1690388969; bh=97MgdinZzeqLR7dKFXO0MmcsC1rkrqiXpSbNH2kGwTI=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-Id: List-Archive:List-Help:List-Owner:List-Post:List-Subscribe: List-Unsubscribe:From; b=KHvMoawCIJLhhVDIFjr1EprURjnOX8e9h4ojzN9jYYBSJNOnXUgAmKyZcMJE+2OLd uNCsJNSHppZZMse3LW3Y0V+f63lQrmBBRl00N1HGl157fX50eN6cRaukV9jLqJJ2pe LW2FvJH1Izw4BPdfSeyJuOOIpo8FMqGweEOPaqDs= Received: by alsa1.perex.cz (Postfix, from userid 50401) id 24DC3F801F5; Wed, 26 Jul 2023 18:28:11 +0200 (CEST) Received: from mailman-core.alsa-project.org (mailman-core.alsa-project.org [10.254.200.10]) by alsa1.perex.cz (Postfix) with ESMTP id C89F5F8019B; Wed, 26 Jul 2023 18:28:07 +0200 (CEST) Received: by alsa1.perex.cz (Postfix, from userid 50401) id 3055FF8019B; Wed, 26 Jul 2023 18:27:59 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by alsa1.perex.cz (Postfix) with ESMTPS id 364C1F80149 for ; Wed, 26 Jul 2023 18:27:53 +0200 (CEST) DKIM-Filter: OpenDKIM Filter v2.11.0 alsa1.perex.cz 364C1F80149 Authentication-Results: alsa1.perex.cz; dkim=pass (2048-bit key, unprotected) header.d=intel.com header.i=@intel.com header.a=rsa-sha256 header.s=Intel header.b=kYkO2hIK DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1690388875; x=1721924875; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=97MgdinZzeqLR7dKFXO0MmcsC1rkrqiXpSbNH2kGwTI=; b=kYkO2hIKTGSONdISTxqM11qhIZTe8TuRYAN7c56Tqywz/CqbaOJqMmac 3dJ7ZjdzJDmRRMMPRwyosPTqINjSQBWzG4sEx028z+dByUe3DYHcp3rl/ 1ENrqV0OskRCNa/pKSltzY9hpk1NfrrAjK+fVxyu/UetRDMmvISzNP3tO pS37hoSfC4kou1PkJt5eqTrP9nd7RGru5jeARukORTY4PG0610FWuI6Uc mULCv0PffSLzfRszgovh7bzQwlLSJizoUM9jKbSs+ulqGyhVysupuvS3e 86+y+/lJSzRHg7odM4eh4FkX91X/HYjh4IrYcjiFeosy39nR3y2jRrQ1+ A==; X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="352968315" X-IronPort-AV: E=Sophos;i="6.01,232,1684825200"; d="scan'208";a="352968315" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 26 Jul 2023 09:27:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10783"; a="796643250" X-IronPort-AV: E=Sophos;i="6.01,232,1684825200"; d="scan'208";a="796643250" Received: from smile.fi.intel.com ([10.237.72.54]) by fmsmga004.fm.intel.com with ESMTP; 26 Jul 2023 09:27:46 -0700 Received: from andy by smile.fi.intel.com with local (Exim 4.96) (envelope-from ) id 1qOhMW-00EzwV-0U; Wed, 26 Jul 2023 19:27:44 +0300 Date: Wed, 26 Jul 2023 19:27:43 +0300 From: Andy Shevchenko To: Brent Lu Cc: alsa-devel@alsa-project.org, Cezary Rojewski , Pierre-Louis Bossart , Liam Girdwood , Peter Ujfalusi , Bard Liao , Ranjani Sridharan , Kai Vehmanen , Mark Brown , Jaroslav Kysela , Takashi Iwai , linux-kernel@vger.kernel.org, Ajye Huang , Yong Zhi , Terry Cheong , Uday M Bhat , Mac Chiang , "Dharageswari . R" , Kuninori Morimoto , ye xingchen Subject: Re: [PATCH v2 1/2] ASoC: Intel: maxim-common: get codec number from ACPI Message-ID: References: <20230726140848.2267568-1-brent.lu@intel.com> <20230726140848.2267568-2-brent.lu@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230726140848.2267568-2-brent.lu@intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Message-ID-Hash: Y5J54EFJ2VKGY6I6A7O62XCTGUVFVJQB X-Message-ID-Hash: Y5J54EFJ2VKGY6I6A7O62XCTGUVFVJQB X-MailFrom: andriy.shevchenko@linux.intel.com X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-alsa-devel.alsa-project.org-0; header-match-alsa-devel.alsa-project.org-1; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.8 Precedence: list List-Id: "Alsa-devel mailing list for ALSA developers - http://www.alsa-project.org" Archived-At: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: On Wed, Jul 26, 2023 at 10:08:47PM +0800, Brent Lu wrote: > Implement a helper function to get number of codecs from ACPI > subsystem to remove the need of quirk flag in machine driver. ... > +void max_98390_dai_link(struct snd_soc_dai_link *link) > +{ > + unsigned int num_codecs = get_num_codecs(MAX_98390_ACPI_HID); > + > + link->codecs = max_98390_components; > + > + switch (num_codecs) { > + case 2: > + case 4: > + link->num_codecs = num_codecs; > + break; > + default: > + pr_err("invalid codec number %d for %s\n", num_codecs, > + MAX_98390_ACPI_HID); I believe you have struct device pointer available, use dev_err(). > + break; > + } > + > + link->init = max_98390_init; > + link->ops = &max_98390_ops; > +} ... > +void max_98390_set_codec_conf(struct snd_soc_card *card) > { > + unsigned int num_codecs = get_num_codecs(MAX_98390_ACPI_HID); > + > + card->codec_conf = max_98390_codec_conf; > + > + switch (num_codecs) { > + case 2: > + case 4: > + card->num_configs = num_codecs; > + break; > + default: > + pr_err("invalid codec number %d for %s\n", num_codecs, > + MAX_98390_ACPI_HID); Ditto. > + break; > } > } -- With Best Regards, Andy Shevchenko