From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Nicolin Chen <nicolinc@nvidia.com>,
kevin.tian@intel.com, yi.l.liu@intel.com, joro@8bytes.org,
will@kernel.org, robin.murphy@arm.com, shuah@kernel.org,
linux-kernel@vger.kernel.org, iommu@lists.linux.dev,
kvm@vger.kernel.org, linux-kselftest@vger.kernel.org,
mjrosato@linux.ibm.com, farman@linux.ibm.com
Subject: Re: [PATCH v8 1/4] vfio: Do not allow !ops->dma_unmap in vfio_pin/unpin_pages()
Date: Wed, 26 Jul 2023 14:38:56 -0300 [thread overview]
Message-ID: <ZMFaMCpLHi2S6UOi@nvidia.com> (raw)
In-Reply-To: <20230726113349.3dc1382c.alex.williamson@redhat.com>
On Wed, Jul 26, 2023 at 11:33:49AM -0600, Alex Williamson wrote:
> On Mon, 24 Jul 2023 12:47:04 -0700
> Nicolin Chen <nicolinc@nvidia.com> wrote:
>
> > A driver that doesn't implement ops->dma_unmap shouldn't be allowed to do
> > vfio_pin/unpin_pages(), though it can use vfio_dma_rw() to access an iova
> > range. Deny !ops->dma_unmap cases in vfio_pin/unpin_pages().
> >
> > Suggested-by: Kevin Tian <kevin.tian@intel.com>
> > Reviewed-by: Kevin Tian <kevin.tian@intel.com>
> > Reviewed-by: Yi Liu <yi.l.liu@intel.com>
> > Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>
> > Signed-off-by: Nicolin Chen <nicolinc@nvidia.com>
> > ---
> > drivers/vfio/vfio_main.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> I assume these go through iommufd.
Yep, I think it is next up, thanks
Jason
next prev parent reply other threads:[~2023-07-26 17:38 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 19:47 [PATCH v8 0/4] cover-letter: Add IO page table replacement support Nicolin Chen
2023-07-24 19:47 ` [PATCH v8 1/4] vfio: Do not allow !ops->dma_unmap in vfio_pin/unpin_pages() Nicolin Chen
2023-07-26 17:33 ` Alex Williamson
2023-07-26 17:38 ` Jason Gunthorpe [this message]
2023-07-24 19:47 ` [PATCH v8 2/4] iommufd: Add iommufd_access_replace() API Nicolin Chen
2023-07-26 14:30 ` Jason Gunthorpe
2023-07-26 20:50 ` Nicolin Chen
2023-07-26 23:36 ` Jason Gunthorpe
2023-07-27 2:59 ` Nicolin Chen
2023-07-27 7:30 ` Nicolin Chen
2023-07-27 12:03 ` Jason Gunthorpe
2023-07-27 19:04 ` Nicolin Chen
2023-07-28 3:45 ` Tian, Kevin
2023-07-28 4:43 ` Nicolin Chen
2023-07-28 6:20 ` Tian, Kevin
2023-07-28 12:28 ` Jason Gunthorpe
2023-07-28 12:27 ` Jason Gunthorpe
2023-07-24 19:47 ` [PATCH v8 3/4] iommufd/selftest: Add IOMMU_TEST_OP_ACCESS_REPLACE_IOAS coverage Nicolin Chen
2023-07-26 17:04 ` Jason Gunthorpe
2023-07-24 19:47 ` [PATCH v8 4/4] vfio: Support IO page table replacement Nicolin Chen
2023-07-26 17:04 ` Jason Gunthorpe
2023-07-26 17:34 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMFaMCpLHi2S6UOi@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=farman@linux.ibm.com \
--cc=iommu@lists.linux.dev \
--cc=joro@8bytes.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=mjrosato@linux.ibm.com \
--cc=nicolinc@nvidia.com \
--cc=robin.murphy@arm.com \
--cc=shuah@kernel.org \
--cc=will@kernel.org \
--cc=yi.l.liu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.