From: Peter Xu <peterx@redhat.com>
To: hongmianquan <hongmianquan@bytedance.com>
Cc: qemu-devel@nongnu.org, philmd@linaro.org, david@redhat.com,
Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] memory: avoid updating ioeventfds for some address_space
Date: Wed, 26 Jul 2023 13:45:40 -0400 [thread overview]
Message-ID: <ZMFbxFnv82AWlzLD@x1n> (raw)
In-Reply-To: <20230725112037.1762608-1-hongmianquan@bytedance.com>
On Tue, Jul 25, 2023 at 07:20:37PM +0800, hongmianquan wrote:
> When updating ioeventfds, we need to iterate all address spaces,
> but some address spaces do not register eventfd_add|del call when
> memory_listener_register() and they do nothing when updating ioeventfds.
> So we can skip these AS in address_space_update_ioeventfds().
>
> The overhead of memory_region_transaction_commit() can be significantly
> reduced. For example, a VM with 8 vhost net devices and each one has
> 64 vectors, can reduce the time spent on memory_region_transaction_commit by 20%.
>
> Signed-off-by: hongmianquan <hongmianquan@bytedance.com>
Reviewed-by: Peter Xu <peterx@redhat.com>
Should be for 8.2, though. Please always copy Paolo for memory related
patches. I hope Paolo can see this.
--
Peter Xu
next prev parent reply other threads:[~2023-07-26 18:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-25 11:20 [PATCH] memory: avoid updating ioeventfds for some address_space hongmianquan
2023-07-26 17:45 ` Peter Xu [this message]
2023-07-27 3:59 ` [External] " hongmainquan
2023-07-27 12:53 ` Peter Xu
2023-07-27 13:23 ` hongmainquan
2023-07-27 14:36 ` Peter Xu
2023-07-27 15:01 ` hongmainquan
-- strict thread matches above, loose matches on Subject: below --
2023-07-25 8:53 hongmianquan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMFbxFnv82AWlzLD@x1n \
--to=peterx@redhat.com \
--cc=david@redhat.com \
--cc=hongmianquan@bytedance.com \
--cc=pbonzini@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.