From: Brian Norris <briannorris@chromium.org>
To: Dmitry Antipov <dmantipov@yandex.ru>
Cc: Kalle Valo <kvalo@kernel.org>,
linux-wireless@vger.kernel.org, lvc-project@linuxtesting.org
Subject: Re: [PATCH 2/5] wifi: mwifiex: drop BUG_ON() from TX error handling
Date: Wed, 26 Jul 2023 12:22:36 -0700 [thread overview]
Message-ID: <ZMFyfJrDa5jwI6Ep@google.com> (raw)
In-Reply-To: <20230726072114.51964-2-dmantipov@yandex.ru>
On Wed, Jul 26, 2023 at 10:20:53AM +0300, Dmitry Antipov wrote:
> Remove 'BUG_ON()' from 'mwifiex_process_sta_txpd()' and
> 'mwifiex_process_uap_txpd()'. In case of insufficient
> headrom, issue warning and return NULL, which should be
> gracefully handled in 'mwifiex_process_tx()'. Also mark
> error handling branches with 'unlikely()' and simplify
> error messages (there is no need to use formatted output
> to print the value which is known to be zero).
>
> Signed-off-by: Dmitry Antipov <dmantipov@yandex.ru>
You already sent a version of this patch, and I already gave you
feedback:
https://lore.kernel.org/all/ZJ3lyIQy7GPbA9YL@google.com/
You didn't respond to or integrate that feedback.
Brian
next prev parent reply other threads:[~2023-07-26 19:22 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-26 7:20 [PATCH 1/5] wifi: mwifiex: fix memory leak in mwifiex_histogram_read() Dmitry Antipov
2023-07-26 7:20 ` [PATCH 2/5] wifi: mwifiex: drop BUG_ON() from TX error handling Dmitry Antipov
2023-07-26 19:22 ` Brian Norris [this message]
2023-07-26 7:20 ` [PATCH 3/5] wifi: mwifiex: cleanup private data structures Dmitry Antipov
2023-07-26 7:20 ` [PATCH 4/5] wifi: mwifiex: handle possible sscanf() errors Dmitry Antipov
2023-07-26 7:20 ` [PATCH 5/5] wifi: mwifiex: handle possible mwifiex_write_reg() errors Dmitry Antipov
2023-07-26 19:24 ` [PATCH 1/5] wifi: mwifiex: fix memory leak in mwifiex_histogram_read() Brian Norris
2023-07-28 8:43 ` [PATCH 1/5] [v2] " Dmitry Antipov
2023-07-28 8:43 ` [PATCH 2/2] [v2] wifi: mwifiex: cleanup TX error handling Dmitry Antipov
2023-08-01 17:55 ` Brian Norris
2023-08-02 11:45 ` [lvc-project] " Antipov, Dmitriy
2023-08-02 16:07 ` [PATCH 1/5] [v3] wifi: mwifiex: fix memory leak in mwifiex_histogram_read() Dmitry Antipov
2023-08-02 16:07 ` [PATCH 2/5] [v3] wifi: mwifiex: cleanup private data structures Dmitry Antipov
2023-08-02 16:07 ` [PATCH 3/5] [v3] wifi: mwifiex: handle possible sscanf() errors Dmitry Antipov
2023-08-02 16:07 ` [PATCH 4/5] [v3] wifi: mwifiex: handle possible mwifiex_write_reg() errors Dmitry Antipov
2023-08-02 16:07 ` [PATCH 5/5] [v3] wifi: mwifiex: drop BUG_ON from TX paths Dmitry Antipov
2023-08-08 19:58 ` Brian Norris
2023-08-21 15:56 ` [PATCH 1/5] [v3] wifi: mwifiex: fix memory leak in mwifiex_histogram_read() Kalle Valo
2023-07-28 8:43 ` [PATCH 3/5] [v2] wifi: mwifiex: cleanup private data structures Dmitry Antipov
2023-07-28 8:43 ` [PATCH 4/5] [v2] wifi: mwifiex: handle possible sscanf() errors Dmitry Antipov
2023-07-28 8:43 ` [PATCH 5/5] [v2] wifi: mwifiex: handle possible mwifiex_write_reg() errors Dmitry Antipov
2023-07-31 9:46 ` [PATCH 1/5] [v2] wifi: mwifiex: fix memory leak in mwifiex_histogram_read() Kalle Valo
2023-07-31 9:55 ` [lvc-project] " Antipov, Dmitriy
2023-07-28 9:29 ` [lvc-project] [PATCH 1/5] " Antipov, Dmitriy
2023-07-31 9:47 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMFyfJrDa5jwI6Ep@google.com \
--to=briannorris@chromium.org \
--cc=dmantipov@yandex.ru \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=lvc-project@linuxtesting.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.