From: Leo Liang <ycliang@andestech.com>
To: Rick Chen <rickchen36@gmail.com>
Cc: Simon Glass <sjg@chromium.org>, Rick Chen <rick@andestech.com>,
<u-boot@lists.denx.de>, <bmeng.cn@gmail.com>
Subject: Re: [PATCH] riscv: Support riscv64 image type
Date: Thu, 27 Jul 2023 01:39:00 +0000 [thread overview]
Message-ID: <ZMHKtFyTPQbu4Ty4@ubuntu01> (raw)
In-Reply-To: <CAN5B=eLs4Zva+qCfm8eB+iY_+XYCPuo5wL7p7QA2O0wCELq5ZA@mail.gmail.com>
Hi Rick,
On Thu, Jul 27, 2023 at 09:27:31AM +0800, Rick Chen wrote:
> > Hi Rick,
> >
> > On Wed, 19 Apr 2023 at 00:56, Rick Chen <rickchen36@gmail.com> wrote:
> > >
> > > Hi Simon,
> > >
> > > > Hi Rick,
> > > >
> > > > On Mon, 10 Apr 2023 at 01:26, Rick Chen <rick@andestech.com> wrote:
> > > > >
> > > > > Allow U-Boot to load 32 or 64 bits RISC-V Kernel Image
> > > > > distinguishly. It helps to avoid someone maybe make a mistake
> > > > > to run 32-bit U-Boot to load 64-bit kernel.
> > > > >
> > > > > Signed-off-by: Rick Chen <rick@andestech.com>
> > > > >
> > > > > ---
> > > > > The patchset is based on Simon's patch:
> > > > > riscv: Add a 64-bit image type
> > > > > ---
> > > > > ---
> > > > > arch/riscv/include/asm/u-boot.h | 4 ++++
> > > > > cmd/booti.c | 2 +-
> > > > > 2 files changed, 5 insertions(+), 1 deletion(-)
> > > >
> > > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > >
> > > > I don't know much about RISC-V, but I assume U-Boot is able to do this
> > > > successfully? Does it not need to switch modes first?
> > >
> > > No, it is not need to switch modes as far as I know.
> > > Here only provide a check mechanism just like arm to see if loader and
> > > OS are match
> > >
> > > But This patch is for bootm flow.
> > > Maybe I still need to check if it is necessary to prepare a patch for
> > > binman flow ?
> > > /arch/riscv/dts/binman.dtsi
> > > arch = "riscv";
> > >
> > > maybe provide another binman64.dtsi for arch="riscv64"
> >
> > Yes I think that is needed too. Are you going to update this patch, or
> > send a second one?
>
> Hi Simon,
>
> OK.
>
> HI Leo,
>
> I am a little busy on other things.Can you help to update this patch ?
>
No problem!
I will send a v2 patch ASAP.
Best regards,
Leo
> Thanks.
> Rick
>
> >
> > Regards,
> > Simon
prev parent reply other threads:[~2023-07-27 1:39 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-10 7:27 [PATCH] riscv: Support riscv64 image type Rick Chen
2023-04-19 1:46 ` Simon Glass
2023-04-19 6:56 ` Rick Chen
2023-07-26 21:33 ` Simon Glass
2023-07-27 1:27 ` Rick Chen
2023-07-27 1:39 ` Leo Liang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMHKtFyTPQbu4Ty4@ubuntu01 \
--to=ycliang@andestech.com \
--cc=bmeng.cn@gmail.com \
--cc=rick@andestech.com \
--cc=rickchen36@gmail.com \
--cc=sjg@chromium.org \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.