From: Andy Shevchenko <andy@kernel.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: j-keerthy@ti.com, linus.walleij@linaro.org, brgl@bgdev.pl,
grygorii.strashko@ti.com, ssantosh@kernel.org,
khilman@kernel.org, linux-gpio@vger.kernel.org,
linux-omap@vger.kernel.org
Subject: Re: [PATCH -next] gpio: Remove redundant dev_err_probe()
Date: Thu, 27 Jul 2023 13:11:44 +0300 [thread overview]
Message-ID: <ZMJC4B9Z2pVRDEOJ@smile.fi.intel.com> (raw)
In-Reply-To: <20230727091446.859984-1-ruanjinjie@huawei.com>
On Thu, Jul 27, 2023 at 05:14:46PM +0800, Ruan Jinjie wrote:
> There is no need to call the dev_err_probe() function directly to print
> a custom message when handling an error from platform_get_irq() function as
> it is going to display an appropriate error message in case of a failure.
Please, split on per-driver basis.
The code wise it's okay, you may add to each patch in v2
Reviewed-by: Andy Shevchenko <andy@kernel.org>
> drivers/gpio/gpio-davinci.c | 2 +-
> drivers/gpio/gpio-omap.c | 2 +-
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-07-27 10:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 9:14 [PATCH -next] gpio: Remove redundant dev_err_probe() Ruan Jinjie
2023-07-27 10:11 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMJC4B9Z2pVRDEOJ@smile.fi.intel.com \
--to=andy@kernel.org \
--cc=brgl@bgdev.pl \
--cc=grygorii.strashko@ti.com \
--cc=j-keerthy@ti.com \
--cc=khilman@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=ssantosh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.