From: Simon Horman <simon.horman@corigine.com>
To: Chen Jiahao <chenjiahao16@huawei.com>
Cc: justin.chen@broadcom.com, florian.fainelli@broadcom.com,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, bcm-kernel-feedback-list@broadcom.com,
netdev@vger.kernel.org
Subject: Re: [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe()
Date: Thu, 27 Jul 2023 15:32:32 +0200 [thread overview]
Message-ID: <ZMJx8JnLPBbsR1Up@corigine.com> (raw)
In-Reply-To: <20230727115551.2655840-1-chenjiahao16@huawei.com>
On Thu, Jul 27, 2023 at 07:55:51PM +0800, Chen Jiahao wrote:
> Refering to platform_get_irq()'s definition, the return value has
nit: Refering -> Referring
> already been checked, error message also been printed via
> dev_err_probe() if ret < 0. Calling dev_err_probe() one more time
> outside platform_get_irq() is obviously redundant.
>
> Removing dev_err_probe() outside platform_get_irq() to clean up
> above problem.
>
> Signed-off-by: Chen Jiahao <chenjiahao16@huawei.com>
Reviewed-by: Simon Horman <simon.horman@corigine.com>
next prev parent reply other threads:[~2023-07-27 13:32 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-27 11:55 [PATCH -next] net: bcmasp: Clean up redundant dev_err_probe() Chen Jiahao
2023-07-27 13:32 ` Simon Horman [this message]
2023-07-28 8:11 ` chenjiahao (C)
2023-07-27 20:46 ` Justin Chen
2023-07-29 1:50 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMJx8JnLPBbsR1Up@corigine.com \
--to=simon.horman@corigine.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=chenjiahao16@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=florian.fainelli@broadcom.com \
--cc=justin.chen@broadcom.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.