From: Sean Christopherson <seanjc@google.com>
To: Aaron Lewis <aaronlewis@google.com>
Cc: kvm@vger.kernel.org, pbonzini@redhat.com, jmattson@google.com
Subject: Re: [PATCH v3 0/5] Add printf and formatted asserts in the guest
Date: Thu, 27 Jul 2023 11:44:25 -0700 [thread overview]
Message-ID: <ZMK7CeDmV4okacLl@google.com> (raw)
In-Reply-To: <CAAAPnDH=42rkUw5noZOFbPYN627+bPiTxfYd5HNfJUT1PBfYjg@mail.gmail.com>
On Thu, Jul 27, 2023, Aaron Lewis wrote:
> >
> > The easiest thing I can think of is to add a second buffer to hold the exp+file+line.
> > Then, test_assert() just needs to skip that particular line of formatting.
Gah, had a brain fart. There's no need to format the expression+file+line in the
guest, we can pass pointers to the expression and file, just like we already do
for the existing guest asserts.
v4 coming soon...
prev parent reply other threads:[~2023-07-27 18:44 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-07 22:45 [PATCH v3 0/5] Add printf and formatted asserts in the guest Aaron Lewis
2023-06-07 22:45 ` [PATCH v3 1/5] KVM: selftests: Add strnlen() to the string overrides Aaron Lewis
2023-06-07 22:45 ` [PATCH v3 2/5] KVM: selftests: Add guest_snprintf() to KVM selftests Aaron Lewis
2023-06-07 22:45 ` [PATCH v3 3/5] KVM: selftests: Add additional pages to the guest to accommodate ucall Aaron Lewis
2023-06-07 22:45 ` [PATCH v3 4/5] KVM: selftests: Add string formatting options to ucall Aaron Lewis
2023-06-07 22:45 ` [PATCH v3 5/5] KVM: selftests: Add a selftest for guest prints and formatted asserts Aaron Lewis
2023-07-26 22:41 ` [PATCH v3 0/5] Add printf and formatted asserts in the guest Sean Christopherson
2023-07-27 3:11 ` JinrongLiang
2023-07-27 19:03 ` Sean Christopherson
2023-07-27 19:21 ` Sean Christopherson
2023-07-28 9:40 ` Jinrong Liang
2023-07-27 12:16 ` Aaron Lewis
2023-07-27 18:44 ` Sean Christopherson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMK7CeDmV4okacLl@google.com \
--to=seanjc@google.com \
--cc=aaronlewis@google.com \
--cc=jmattson@google.com \
--cc=kvm@vger.kernel.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.