From: Tzung-Bi Shih <tzungbi@kernel.org>
To: Guenter Roeck <groeck@google.com>
Cc: rafael@kernel.org, lenb@kernel.org, bleung@chromium.org,
groeck@chromium.org, chrome-platform@lists.linux.dev,
linux-acpi@vger.kernel.org, guillaume.tucker@collabora.com,
denys.f@collabora.com, ricardo.canuelo@collabora.com,
usama.anjum@collabora.com
Subject: Re: [PATCH v2] platform/chrome: chromeos_acpi: support official HID GOOG0016
Date: Mon, 31 Jul 2023 10:50:11 +0800 [thread overview]
Message-ID: <ZMchYw19KmfcChGK@google.com> (raw)
In-Reply-To: <CABXOdTca9hmjWXNATeSkhZAV1PXh1ppt6ENEV23xUpO86ogu_w@mail.gmail.com>
On Fri, Jul 28, 2023 at 08:03:50AM -0700, Guenter Roeck wrote:
> On Thu, Jul 27, 2023 at 11:55 PM Tzung-Bi Shih <tzungbi@kernel.org> wrote:
> > --- a/Documentation/ABI/testing/sysfs-driver-chromeos-acpi
> > +++ b/Documentation/ABI/testing/sysfs-driver-chromeos-acpi
> > @@ -1,4 +1,4 @@
> > -What: /sys/bus/platform/devices/GGL0001:*/BINF.2
> > +What: /sys/bus/platform/devices/GOOG0016:*/BINF.2
>
> Doesn't the description mean that both sysfs directories might be seen
> in the field ?
> If so, replacing one with the other would be wrong.
Fix it in v3
(https://patchwork.kernel.org/project/chrome-platform/patch/20230731024214.908235-1-tzungbi@kernel.org/)
by appending a new line for "GOOG0016".
prev parent reply other threads:[~2023-07-31 2:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 6:54 [PATCH v2] platform/chrome: chromeos_acpi: support official HID GOOG0016 Tzung-Bi Shih
2023-07-28 7:49 ` Muhammad Usama Anjum
2023-07-31 2:49 ` Tzung-Bi Shih
2023-07-28 15:03 ` Guenter Roeck
2023-07-31 2:50 ` Tzung-Bi Shih [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMchYw19KmfcChGK@google.com \
--to=tzungbi@kernel.org \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=denys.f@collabora.com \
--cc=groeck@chromium.org \
--cc=groeck@google.com \
--cc=guillaume.tucker@collabora.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=ricardo.canuelo@collabora.com \
--cc=usama.anjum@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.