From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F188C001DF for ; Mon, 31 Jul 2023 06:05:20 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id B1E5286A0C; Mon, 31 Jul 2023 08:05:18 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 92CAE86A1E; Mon, 31 Jul 2023 08:05:17 +0200 (CEST) Received: from Atcsqr.andestech.com (60-248-80-70.hinet-ip.hinet.net [60.248.80.70]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 257C886A0C for ; Mon, 31 Jul 2023 08:05:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=andestech.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ycliang@andestech.com Received: from mail.andestech.com (ATCPCS16.andestech.com [10.0.1.222]) by Atcsqr.andestech.com with ESMTP id 36V64vvW050704; Mon, 31 Jul 2023 14:04:57 +0800 (+08) (envelope-from ycliang@andestech.com) Received: from ubuntu01 (10.0.12.75) by ATCPCS16.andestech.com (10.0.1.222) with Microsoft SMTP Server id 14.3.498.0; Mon, 31 Jul 2023 14:04:53 +0800 Date: Mon, 31 Jul 2023 06:04:50 +0000 From: Leo Liang To: Heinrich Schuchardt CC: Bin Meng , Subject: Re: [PATCH 1/1] riscv: qemu: imply CONFIG_DM_RNG Message-ID: References: <20230728135415.15055-1-heinrich.schuchardt@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: <20230728135415.15055-1-heinrich.schuchardt@canonical.com> User-Agent: Mutt/2.0.5 (2021-01-21) X-Originating-IP: [10.0.12.75] X-DNSRBL: X-MAIL: Atcsqr.andestech.com 36V64vvW050704 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean On Fri, Jul 28, 2023 at 03:54:15PM +0200, Heinrich Schuchardt wrote: > The EFI_RNG_PROTOCOL is needed for Linux' KASLR. > > QEMU can provide a virtio-rng device to emulate a hardware random number > generator which is supported by our virtio_rng driver. > > Enabling CONFIG_DM_RNG will enable CONFIG_VIRTIO_RNG and > CONFIG_EFI_RNG_PROTOCOL by default too. > > Signed-off-by: Heinrich Schuchardt > --- > board/emulation/qemu-riscv/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/board/emulation/qemu-riscv/Kconfig b/board/emulation/qemu-riscv/Kconfig > index 6114e1b812..21d6160f01 100644 > --- a/board/emulation/qemu-riscv/Kconfig > +++ b/board/emulation/qemu-riscv/Kconfig > @@ -53,6 +53,7 @@ config BOARD_SPECIFIC_OPTIONS # dummy > imply NVME > imply PCI > imply PCIE_ECAM_GENERIC > + imply DM_RNG > imply SCSI > imply DM_SCSI > imply SYS_NS16550 > -- > 2.40.1 > Hi Heinrich, This patch seems to cause CI: test/py/tests/test_efi_selftest.py to fail. (https://source.denx.de/u-boot/custodians/u-boot-riscv/-/jobs/666642) Could you take a look at this and check if anything else needs modification? Best regards, Leo