From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
qemu-devel@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Stefan Weil" <sw@weilnetz.de>,
"Yonggang Luo" <luoyonggang@gmail.com>
Subject: Re: [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang
Date: Mon, 31 Jul 2023 13:57:43 +0100 [thread overview]
Message-ID: <ZMevxyEiwvZXSBIC@redhat.com> (raw)
In-Reply-To: <6ca265d4-0dad-3725-1cd5-84da685bc63a@redhat.com>
On Mon, Jul 31, 2023 at 11:10:58AM +0200, Thomas Huth wrote:
> Anyway, using bitfields in structs for exchanging data with the guest is
> just way too error-prone, as you can see in the discussion about that
> VTD_IR_TableEntry in my other patch. We should maybe advise against
> bitfields in our coding style and point people to registerfields.h instead
> for new code? ... so that we use QEMU_PACKED mainly for legacy code. Would
> it then be OK for you, Peter, to go on with this approach?
The registerfields.h usage doesn't seem to be documented at all from the
quick look I had. IOW, in addition to a mention in coding style, it would
be nice if someone can document the general usage pattern for it.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-07-31 12:59 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 14:27 [RFC PATCH 0/6] Use Clang for compiling in the 64-bit MSYS2 job Thomas Huth
2023-07-28 14:27 ` [RFC PATCH 1/6] gitlab: remove duplication between msys jobs Thomas Huth
2023-07-28 14:27 ` [RFC PATCH 2/6] ui/dbus: fix clang compilation issue Thomas Huth
2023-07-28 14:27 ` [RFC PATCH 3/6] util/oslib-win32: Fix compiling with Clang from MSYS2 Thomas Huth
2023-07-31 14:20 ` Philippe Mathieu-Daudé
2023-07-28 14:27 ` [RFC PATCH 4/6] hw/i386/intel_iommu: Fix VTD_IR_TableEntry for ms_struct layout Thomas Huth
2023-07-28 14:37 ` Daniel P. Berrangé
2023-07-28 16:39 ` Richard Henderson
2023-07-31 8:20 ` Thomas Huth
2023-07-31 20:26 ` Peter Xu
2023-07-31 20:53 ` Michael S. Tsirkin
2023-07-28 14:27 ` [RFC PATCH 5/6] include/qemu/compiler: Fix problem with gcc_struct and Clang Thomas Huth
2023-07-28 15:13 ` Peter Maydell
2023-07-31 9:10 ` Thomas Huth
2023-07-31 9:32 ` Daniel P. Berrangé
2023-07-31 12:04 ` Thomas Huth
2023-08-03 16:29 ` Daniel P. Berrangé
2023-07-31 14:10 ` Philippe Mathieu-Daudé
2023-07-31 17:25 ` Daniel P. Berrangé
2023-08-01 13:29 ` Philippe Mathieu-Daudé
2023-07-31 10:05 ` Peter Maydell
2023-07-31 12:05 ` Thomas Huth
2023-07-31 12:44 ` Daniel P. Berrangé
2023-08-01 13:49 ` Daniel P. Berrangé
2023-08-01 18:31 ` Thomas Huth
2023-07-31 12:57 ` Daniel P. Berrangé [this message]
2023-07-31 14:07 ` Philippe Mathieu-Daudé
2023-07-28 14:27 ` [RFC PATCH 6/6] gitlab-ci.d/windows: Use Clang for compiling in the 64-bit MSYS2 job Thomas Huth
2023-07-31 14:23 ` Philippe Mathieu-Daudé
2023-07-31 14:43 ` Thomas Huth
2023-08-01 13:30 ` Philippe Mathieu-Daudé
2023-08-01 13:35 ` [RFC PATCH 0/6] " Daniel P. Berrangé
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMevxyEiwvZXSBIC@redhat.com \
--to=berrange@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=sw@weilnetz.de \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.