From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2867CC001DC for ; Mon, 31 Jul 2023 16:34:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 7628340B5D; Mon, 31 Jul 2023 16:34:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7628340B5D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1690821244; bh=c+zIW3b4q3pY9WA8MuCBaNm4RFAdFgETp2nra7MBD6M=; h=Date:From:To:References:In-Reply-To:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=etOoGzQfBkPloeBessB5e5vYRHddCLuAhpXva/raUv2UcuT2oBCskAMznH9w8rVLO twcPNk3Xyxc4AHPx7UAB+OqTGEGZldqGphwO/NgXORbDTJODDbLbXIKvFEc00PF46N VRdPRYfJUnr46bYZ8Lvgf4S6kioqSP/NJ5r0VBbbn8PNv4NKqYTtFQsuUsK3Vrsl/R QurDlBPDEiy4PfkY3pI5H76gSllyVcc1zDuVuwum4ZAFuQ1UDxiZF1BZbdd4FEtR18 MiVdPuJed6oh7LHfiX9J+EJSY8YzV6DXMTo+TvV+wXKKXp77kRb1gOC7GIEIYWjgUT dH6AVvFbeHpyw== X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OD8ZaAqJoRjB; Mon, 31 Jul 2023 16:34:03 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp2.osuosl.org (Postfix) with ESMTP id CDFA440B99; Mon, 31 Jul 2023 16:34:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org CDFA440B99 Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 1BD941BF313 for ; Mon, 31 Jul 2023 16:31:05 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id E41A7409E6 for ; Mon, 31 Jul 2023 16:31:04 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org E41A7409E6 X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zggmy4Y9fVEA for ; Mon, 31 Jul 2023 16:31:03 +0000 (UTC) Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by smtp2.osuosl.org (Postfix) with ESMTPS id F10D040135 for ; Mon, 31 Jul 2023 16:31:02 +0000 (UTC) DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org F10D040135 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 27364611BF; Mon, 31 Jul 2023 16:31:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EBDAC433C7; Mon, 31 Jul 2023 16:31:00 +0000 (UTC) Date: Mon, 31 Jul 2023 18:30:58 +0200 From: Simon Horman To: Jedrzej Jagielski Message-ID: References: <20230731135218.10051-1-jedrzej.jagielski@intel.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230731135218.10051-1-jedrzej.jagielski@intel.com> X-Mailman-Approved-At: Mon, 31 Jul 2023 16:34:01 +0000 X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690821061; bh=KAsyPQEGy6Z/bBlXO17Vfwfry3I9OYRD8CJVoXJ2qqo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fzgn2zD/rBDgFeT/2Ydh7vlAuqNqBsm34ECdurZaWHp5OTFRj3uN/bB0dzE95eKzG 3j3vwGiAe8IyCcFF0tHwbzRE/yiptf5T/GHVNPBYI1WZ28nGvwGPb3zL1XMLt8+qkK 0SmgqhekCPQEOTs6EHOxOf7s32cOlFOSMHclmWzufGLH66LDNrvcctkst6MRkARCtj zrCBF8YCSOisDhEavXJKMXp5kNAg+CvXpaxXFV8zZKn5c/HVDRwG3bWRUvVL0k5/UD 6pnXyiWYpTbsWolDYWAzMNWuIChwguu7fVq+OCsbygZCEClE1HQtOvEwuD8h8h3Klj EPTrDxlrcb0UA== X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=fzgn2zD/ Subject: Re: [Intel-wired-lan] [PATCH iwl-next v3] i40e: Clear stats after deleting tc X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Grzegorz Szczurek , netdev@vger.kernel.org, anthony.l.nguyen@intel.com, intel-wired-lan@lists.osuosl.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Mon, Jul 31, 2023 at 03:52:18PM +0200, Jedrzej Jagielski wrote: > From: Grzegorz Szczurek > > There was an issue with ethtool stats that have not been cleared after tc > had been deleted. Stats printed by ethtool -S remained the same despite > qdisc had been removed, what is an unexpected behavior. > Stats should be reset once the qdisc is removed. > > Fix this by resetting stats after deleting tc by calling > i40e_vsi_reset_stats() function after destroying qdisc. > > Steps to reproduce: > > 1) Add ingress rule > tc qdisc add dev ingress > > 2) Create qdisc and filter > tc qdisc add dev root mqprio num_tc 4 map 0 0 0 0 1 2 2 3 queues 2@0 2@2 1@4 1@5 hw 1 mode channel > tc filter add dev protocol ip parent ffff: prio 3 flower dst_ip ip_proto tcp dst_port 8300 skip_sw hw_tc 2 > > 3) Run iperf between client and SUT > iperf3 -s -p 8300 > iperf3 -c -p 8300 > > 4) Check the ethtool stats > ethtool -S | grep packets | column > > 5) Delete filter and qdisc > tc filter del dev parent ffff: > tc qdisc del dev root > > 6) Check the ethtool stats and see that they didn't change > ethtool -S | grep packets | column > > Signed-off-by: Grzegorz Szczurek > Signed-off-by: Jedrzej Jagielski Reviewed-by: Simon Horman _______________________________________________ Intel-wired-lan mailing list Intel-wired-lan@osuosl.org https://lists.osuosl.org/mailman/listinfo/intel-wired-lan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2270A19BD8 for ; Mon, 31 Jul 2023 16:31:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6EBDAC433C7; Mon, 31 Jul 2023 16:31:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690821061; bh=KAsyPQEGy6Z/bBlXO17Vfwfry3I9OYRD8CJVoXJ2qqo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fzgn2zD/rBDgFeT/2Ydh7vlAuqNqBsm34ECdurZaWHp5OTFRj3uN/bB0dzE95eKzG 3j3vwGiAe8IyCcFF0tHwbzRE/yiptf5T/GHVNPBYI1WZ28nGvwGPb3zL1XMLt8+qkK 0SmgqhekCPQEOTs6EHOxOf7s32cOlFOSMHclmWzufGLH66LDNrvcctkst6MRkARCtj zrCBF8YCSOisDhEavXJKMXp5kNAg+CvXpaxXFV8zZKn5c/HVDRwG3bWRUvVL0k5/UD 6pnXyiWYpTbsWolDYWAzMNWuIChwguu7fVq+OCsbygZCEClE1HQtOvEwuD8h8h3Klj EPTrDxlrcb0UA== Date: Mon, 31 Jul 2023 18:30:58 +0200 From: Simon Horman To: Jedrzej Jagielski Cc: intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, anthony.l.nguyen@intel.com, Grzegorz Szczurek Subject: Re: [PATCH iwl-next v3] i40e: Clear stats after deleting tc Message-ID: References: <20230731135218.10051-1-jedrzej.jagielski@intel.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230731135218.10051-1-jedrzej.jagielski@intel.com> On Mon, Jul 31, 2023 at 03:52:18PM +0200, Jedrzej Jagielski wrote: > From: Grzegorz Szczurek > > There was an issue with ethtool stats that have not been cleared after tc > had been deleted. Stats printed by ethtool -S remained the same despite > qdisc had been removed, what is an unexpected behavior. > Stats should be reset once the qdisc is removed. > > Fix this by resetting stats after deleting tc by calling > i40e_vsi_reset_stats() function after destroying qdisc. > > Steps to reproduce: > > 1) Add ingress rule > tc qdisc add dev ingress > > 2) Create qdisc and filter > tc qdisc add dev root mqprio num_tc 4 map 0 0 0 0 1 2 2 3 queues 2@0 2@2 1@4 1@5 hw 1 mode channel > tc filter add dev protocol ip parent ffff: prio 3 flower dst_ip ip_proto tcp dst_port 8300 skip_sw hw_tc 2 > > 3) Run iperf between client and SUT > iperf3 -s -p 8300 > iperf3 -c -p 8300 > > 4) Check the ethtool stats > ethtool -S | grep packets | column > > 5) Delete filter and qdisc > tc filter del dev parent ffff: > tc qdisc del dev root > > 6) Check the ethtool stats and see that they didn't change > ethtool -S | grep packets | column > > Signed-off-by: Grzegorz Szczurek > Signed-off-by: Jedrzej Jagielski Reviewed-by: Simon Horman