From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B10F81DDFF for ; Tue, 1 Aug 2023 10:15:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BDA63C433C7; Tue, 1 Aug 2023 10:15:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1690884906; bh=eJbCYWu/oNoVo12hNU0Y2uGd6cqhYGeLANDV/ZOujYY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=co06mUPRCh1m/vMywunK00wEEqXyC8olboC9SJLjtZla1/p4S93bUsPSI66wDWVLw iV1nPFASixMKSRHOOTGFvxqrHVdT0Zn0tyZVnZ9jedUxsd5mfItxrZp3JbQSosEu0g jRyydGb1vk860PN6BuOC5b2s1GPykgU3ValzOFGGIRtMh2kFGfYcvfzOjG6KI0eDO2 KRTgZgTlHllEQd/Reg9YdaJD1v/Oi7UCo9GYRh9MmIYUdVslxqWR0drih+rWWEgn/D d4Q6SC2xaWgB4PIqQmC0ytw+MfmFqyzw6KdhR9ehFitj+16j7i4DyBfdXPVurCEN4R DPbLfdNR/izdA== Date: Tue, 1 Aug 2023 12:15:01 +0200 From: Simon Horman To: Ruan Jinjie Cc: sgoutham@marvell.com, lcherian@marvell.com, gakula@marvell.com, jerinj@marvell.com, hkelam@marvell.com, sbhatta@marvell.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, richardcochran@gmail.com, netdev@vger.kernel.org Subject: Re: [PATCH -next] octeontx2: Remove unnecessary ternary operators Message-ID: References: <20230801024413.3371379-1-ruanjinjie@huawei.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801024413.3371379-1-ruanjinjie@huawei.com> On Tue, Aug 01, 2023 at 10:44:13AM +0800, Ruan Jinjie wrote: > Ther are a little ternary operators, the true or false judgement nit: Ther -> There > of which is unnecessary in C language semantics. So remove it > to clean Code. The target tree of this patch should be 'net-next'. Subject: [PATCH net-next] ... > Signed-off-by: Ruan Jinjie Otherwise this looks good to me. Reviewed-by: Simon Horman