From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Francois Dugast <francois.dugast@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH v3 0/2] Rename engine to exec_queue
Date: Tue, 1 Aug 2023 06:54:16 -0400 [thread overview]
Message-ID: <ZMjkWGr5VawknYaH@intel.com> (raw)
In-Reply-To: <20230801104842.7-1-francois.dugast@intel.com>
On Tue, Aug 01, 2023 at 10:48:40AM +0000, Francois Dugast wrote:
> This is an attempt to rename engine to exec queue in order to prevent confusion
> between engine and hw engine, as discussed here:
> https://gitlab.freedesktop.org/drm/xe/kernel/-/issues/162
>
> Looking for feedback on potential mixups between engine and hw engine, either
> because an occurrence of hw engine has incorrectly been renamed to exec queue
> or because an occurrence of engine has not been renamed to exec queue.
>
> v2:
> - No longer sent as RFC
> - Fix kernel doc and some comments
>
> v3: Rename xe_engine.[ch] in a separate commit to keep history
good idea!
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
for both patches
>
> Francois Dugast (2):
> drm/xe: Rename xe_engine.[ch] to xe_exec_queue.[ch]
> drm/xe: Rename engine to exec_queue
>
> drivers/gpu/drm/xe/Makefile | 2 +-
> drivers/gpu/drm/xe/tests/xe_migrate.c | 18 +-
> drivers/gpu/drm/xe/xe_bb.c | 26 +-
> drivers/gpu/drm/xe/xe_bb.h | 8 +-
> drivers/gpu/drm/xe/xe_devcoredump.c | 40 +-
> drivers/gpu/drm/xe/xe_devcoredump.h | 6 +-
> drivers/gpu/drm/xe/xe_devcoredump_types.h | 2 +-
> drivers/gpu/drm/xe/xe_device.c | 62 +-
> drivers/gpu/drm/xe/xe_device.h | 8 +-
> drivers/gpu/drm/xe/xe_device_types.h | 4 +-
> drivers/gpu/drm/xe/xe_engine.c | 850 -------------
> drivers/gpu/drm/xe/xe_engine.h | 63 -
> drivers/gpu/drm/xe/xe_exec.c | 62 +-
> drivers/gpu/drm/xe/xe_exec_queue.c | 850 +++++++++++++
> drivers/gpu/drm/xe/xe_exec_queue.h | 63 +
> ...e_engine_types.h => xe_exec_queue_types.h} | 110 +-
> drivers/gpu/drm/xe/xe_execlist.c | 126 +-
> drivers/gpu/drm/xe/xe_execlist_types.h | 8 +-
> drivers/gpu/drm/xe/xe_gt.c | 72 +-
> drivers/gpu/drm/xe/xe_gt_types.h | 6 +-
> drivers/gpu/drm/xe/xe_guc_ads.c | 2 +-
> drivers/gpu/drm/xe/xe_guc_ct.c | 10 +-
> ...gine_types.h => xe_guc_exec_queue_types.h} | 26 +-
> drivers/gpu/drm/xe/xe_guc_fwif.h | 6 +-
> drivers/gpu/drm/xe/xe_guc_submit.c | 1076 ++++++++---------
> drivers/gpu/drm/xe/xe_guc_submit.h | 20 +-
> drivers/gpu/drm/xe/xe_guc_submit_types.h | 20 +-
> drivers/gpu/drm/xe/xe_guc_types.h | 4 +-
> drivers/gpu/drm/xe/xe_lrc.c | 10 +-
> drivers/gpu/drm/xe/xe_lrc.h | 4 +-
> drivers/gpu/drm/xe/xe_migrate.c | 66 +-
> drivers/gpu/drm/xe/xe_migrate.h | 6 +-
> drivers/gpu/drm/xe/xe_mocs.c | 2 +-
> drivers/gpu/drm/xe/xe_mocs.h | 2 +-
> drivers/gpu/drm/xe/xe_preempt_fence.c | 32 +-
> drivers/gpu/drm/xe/xe_preempt_fence.h | 4 +-
> drivers/gpu/drm/xe/xe_preempt_fence_types.h | 7 +-
> drivers/gpu/drm/xe/xe_pt.c | 18 +-
> drivers/gpu/drm/xe/xe_pt.h | 6 +-
> drivers/gpu/drm/xe/xe_query.c | 4 +-
> drivers/gpu/drm/xe/xe_ring_ops.c | 38 +-
> drivers/gpu/drm/xe/xe_sched_job.c | 76 +-
> drivers/gpu/drm/xe/xe_sched_job.h | 4 +-
> drivers/gpu/drm/xe/xe_sched_job_types.h | 6 +-
> drivers/gpu/drm/xe/xe_trace.h | 140 +--
> drivers/gpu/drm/xe/xe_vm.c | 178 +--
> drivers/gpu/drm/xe/xe_vm.h | 4 +-
> drivers/gpu/drm/xe/xe_vm_types.h | 6 +-
> include/uapi/drm/xe_drm.h | 86 +-
> 49 files changed, 2124 insertions(+), 2125 deletions(-)
> delete mode 100644 drivers/gpu/drm/xe/xe_engine.c
> delete mode 100644 drivers/gpu/drm/xe/xe_engine.h
> create mode 100644 drivers/gpu/drm/xe/xe_exec_queue.c
> create mode 100644 drivers/gpu/drm/xe/xe_exec_queue.h
> rename drivers/gpu/drm/xe/{xe_engine_types.h => xe_exec_queue_types.h} (52%)
> rename drivers/gpu/drm/xe/{xe_guc_engine_types.h => xe_guc_exec_queue_types.h} (59%)
>
> --
> 2.34.1
>
next prev parent reply other threads:[~2023-08-01 10:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 10:48 [Intel-xe] [PATCH v3 0/2] Rename engine to exec_queue Francois Dugast
2023-08-01 10:48 ` [Intel-xe] [PATCH v3 1/2] drm/xe: Rename xe_engine.[ch] to xe_exec_queue.[ch] Francois Dugast
2023-08-01 10:48 ` [Intel-xe] [PATCH v3 2/2] drm/xe: Rename engine to exec_queue Francois Dugast
2023-08-01 10:51 ` [Intel-xe] ✓ CI.Patch_applied: success for Rename engine to exec_queue (rev3) Patchwork
2023-08-01 10:51 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-01 10:53 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-01 10:54 ` Rodrigo Vivi [this message]
2023-08-01 10:56 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-01 10:57 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-01 10:58 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-08-01 11:32 ` [Intel-xe] ○ CI.BAT: info " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMjkWGr5VawknYaH@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=francois.dugast@intel.com \
--cc=intel-xe@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.