From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8A73BC001DF for ; Tue, 1 Aug 2023 11:10:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=O+7mKGZ+eOItjWlkWrRFn3p8hR/LJYfF4XwctRQpJNI=; b=IYgTPatz0XvSTC /OJq660nVjqthSBqOJ7DpAcSeuKAQVXo2hs3jsM6KtSMJIWgUNia3MFWTt44b/ky0jy6grugocOyb 5zFCW4+i5ccB0ZIdw5ybxYqBF0XxE9ndogXSpLNKwd0pvAlGvLkIBwwMT+H7xZ5//DNd4hofXohjd KnMNSySnWOTAxTMInZGrTxwoShi6ZLAc6EWeIrbbc7BKdAIdb7cTAcGFrivct//XcpHARCZx6rucb XJ/CHyNemSZuH27oQIXnBwxnmGGpM5aIYgVlHmGH8oT/4HcCNtPaXYiatqfTzdwDvYypGmmkDzcSD AxN6u+NLKdWr87ut/TLg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qQnGH-0023hQ-1t; Tue, 01 Aug 2023 11:09:57 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qQnGF-0023gP-0J for linux-arm-kernel@lists.infradead.org; Tue, 01 Aug 2023 11:09:56 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EACE161515; Tue, 1 Aug 2023 11:09:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20930C433C8; Tue, 1 Aug 2023 11:09:49 +0000 (UTC) Date: Tue, 1 Aug 2023 12:09:47 +0100 From: Catalin Marinas To: Kefeng Wang Cc: Andrew Morton , Will Deacon , Mike Kravetz , Muchun Song , Mina Almasry , kirill@shutemov.name, joel@joelfernandes.org, william.kucharski@oracle.com, kaleshsingh@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com Subject: Re: [PATCH v2 2/2] arm64: hugetlb: enable __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE Message-ID: References: <20230801023145.17026-1-wangkefeng.wang@huawei.com> <20230801023145.17026-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230801023145.17026-3-wangkefeng.wang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230801_040955_193217_1A020626 X-CRM114-Status: GOOD ( 13.71 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Aug 01, 2023 at 10:31:45AM +0800, Kefeng Wang wrote: > +#define __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE > +static inline void flush_hugetlb_tlb_range(struct vm_area_struct *vma, > + unsigned long start, > + unsigned long end) > +{ > + unsigned long stride = huge_page_size(hstate_vma(vma)); > + > + if (stride != PMD_SIZE && stride != PUD_SIZE) > + stride = PAGE_SIZE; > + __flush_tlb_range(vma, start, end, stride, false, 0); We could use some hints here for the tlb_level (2 for pmd, 1 for pud). Regarding the last_level argument to __flush_tlb_range(), I think it needs to stay false since this function is also called on the hugetlb_unshare_pmds() path where the pud is cleared and needs invalidating. That said, maybe you can rewrite it as a switch statement and call flush_pmd_tlb_range() or flush_pud_tlb_range() (just make sure these are defined when CONFIG_HUGETLBFS is enabled). -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE68DC001DF for ; Tue, 1 Aug 2023 11:09:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 6A5158E0012; Tue, 1 Aug 2023 07:09:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 62E3C8E0002; Tue, 1 Aug 2023 07:09:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CEB58E0012; Tue, 1 Aug 2023 07:09:57 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 366908E0002 for ; Tue, 1 Aug 2023 07:09:57 -0400 (EDT) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D068240C90 for ; Tue, 1 Aug 2023 11:09:56 +0000 (UTC) X-FDA: 81075265992.11.8A6C172 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf15.hostedemail.com (Postfix) with ESMTP id E6940A0014 for ; Tue, 1 Aug 2023 11:09:54 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690888195; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ki7VtB/htfjhbg39k2YcdULKNRvpMatY6tXnfypuilA=; b=1dTrDh8/oeNJEjqyyQd82xIAV+n9i84ufrtATI5zcDZQj1JRrw7QfUm8OCzE94T2LSHej7 agz0l37tWVApsVHJqK3jJOxxga5cwM2ghgodiPwmFgFFQuL5NB3K1yvdcYTebkraCG0Chg 94/mldLQIm3+3wqIb10VsrOfG3LOGeI= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf15.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690888195; a=rsa-sha256; cv=none; b=4Q/M8F58Xg+iAflO58h1AZRUyjlRIi7D/ahpuSOkZqBK/Y2vcq4WC2FfdwIKPpuic6MQeU Bt6N1Q7hFzE740HpfRb2pmlXgBAuN9JhAA6X42YeytPmyOpdZkC78nBw6kdbcHw7UUJqZQ pVn0ADha4yVlo+pJgOUYt0gBcemQQGY= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id EACE161515; Tue, 1 Aug 2023 11:09:53 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 20930C433C8; Tue, 1 Aug 2023 11:09:49 +0000 (UTC) Date: Tue, 1 Aug 2023 12:09:47 +0100 From: Catalin Marinas To: Kefeng Wang Cc: Andrew Morton , Will Deacon , Mike Kravetz , Muchun Song , Mina Almasry , kirill@shutemov.name, joel@joelfernandes.org, william.kucharski@oracle.com, kaleshsingh@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com Subject: Re: [PATCH v2 2/2] arm64: hugetlb: enable __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE Message-ID: References: <20230801023145.17026-1-wangkefeng.wang@huawei.com> <20230801023145.17026-3-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230801023145.17026-3-wangkefeng.wang@huawei.com> X-Rspamd-Queue-Id: E6940A0014 X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: wj77p6wmiy5pi9s5mbs4htxxsfckpqs4 X-HE-Tag: 1690888194-475289 X-HE-Meta: U2FsdGVkX1+4rLHsdAmh7ioFT4JZ/4nTxNysIe4HuLvj7P9tlj8WicoJI2U7R6/5+KboHE+J4o7Yu2gFq9dUMBFalKu7SqYPE8KAbBQv0KoYvtAZSXiThOyDXYaWoevRUBl9V9VlniV3+uBbXDl19IrX4SbOO+5mhePrJnOxFND6IB8OzhVaMt5M/GeJN82J/Pvey6xfwN3X3l7cg/bfZqNDpUOWm30Dst4v8hegNdosEwcLab6XhEf9YkvqB/8DrudifisLrlSJyOwq1roYVZ+yELJs0M0PjDnA+WE9qBUnUGJM9uMNTta2Ns2a2NnUmKkN97ZxTaVyF46hMzm7LVQ644ympjJQwM0/z9DFef0TtHxJdKfNSgCQnwmeTLUY4DALzGQTy+3WrXe8zhTfdsPHsxx4cidAq2Hw+HCwz5B0LY4Y3K55OjvDgwAo5Jkm83j6jz4FjZaIy0XivDB3vgNhosoWgqJT7U4eFoDvzwSxhK3uY99WD2keniyY8UtAnbgQlstiHz1dHnkyQdwMlJ+NKi1L/S/AUPzQ5lW+anfH3k0YpGnlbCQ2sp7DZmDwmDPbatXcmKDcQnXc2YhjjKwjLKBT9dtqlln5950lJKoevJA/OFFLM0c3Y/0KQhk5l752h/6bkJMmgFnXik67ly/Lbzcpfms6V8+ybTHoKJ7jHgJDy+SA0P/zXXM5qmtjOQGa5jHjSGWV+ZmID6os2rA0d0ViSgdeO9C5qScMO8I0HtP5Y6KhS7ZIf+ZMv+X2hKrTJjzyEBn/WTmztSbYZrv/z20JJIKIqgZGKKBcWjePHpnS23lI1tizaaKmtCHlWFtuG0yZymtYrFq5JNVO4TYKZnqP5UTS4eBu9dtTB3oz9JBC38ra04YNqMuCSjXYduNgZUqGGIcq/h1FYpV1xvjhKbrrwK0RvQwInwYLyVwWHPPjbc9ffAjYmSFhU0+1TXDQt5NhZYXus8ZEyoR JbrhgKsA T1flqYYkJabP2KLCLW0htkpJJ6rm+x75qLFY36oQ7lyvn30p3xkcmkQSh12YhXkRF7JUc0asBql445AYAi51LtYZTQZHpwssMdzgmGrFYTobWgrxy92e48hQ5SYjHe/+HW2gxWdAFmblTr8sYyd6/rlZZqlQmgm/d/hgsC1oUa3HVewlDGXwAvedBPIM9YnJws1x3dnpSh7Kq1abzmtG7bLn88tCmtelmEyYL9FaES9Af1SQPCMtpd1g9DJNcx59AGVsqUZOz1VOZb9uH8o1x7qgVIrRXZNd0JHr1lHo3LYnmCV3nGFnu+z5oCjwdBh6SR4JVVJcc9Dombm0ju1NOfrdZHHgIVUHkMbJ3k8keRWWwmMLiVUgdFT5vGhrxhjooBCqoIkKN3c1uMlgzj8STtSMmZKg3l/8w9UvKyAtu72n6HzMuGa2ZRsKbNCcw2p/s4C6ETH/XFuTmeE7WyoUqz4IoPA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Aug 01, 2023 at 10:31:45AM +0800, Kefeng Wang wrote: > +#define __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE > +static inline void flush_hugetlb_tlb_range(struct vm_area_struct *vma, > + unsigned long start, > + unsigned long end) > +{ > + unsigned long stride = huge_page_size(hstate_vma(vma)); > + > + if (stride != PMD_SIZE && stride != PUD_SIZE) > + stride = PAGE_SIZE; > + __flush_tlb_range(vma, start, end, stride, false, 0); We could use some hints here for the tlb_level (2 for pmd, 1 for pud). Regarding the last_level argument to __flush_tlb_range(), I think it needs to stay false since this function is also called on the hugetlb_unshare_pmds() path where the pud is cleared and needs invalidating. That said, maybe you can rewrite it as a switch statement and call flush_pmd_tlb_range() or flush_pud_tlb_range() (just make sure these are defined when CONFIG_HUGETLBFS is enabled). -- Catalin