From: Michal Hocko <mhocko@suse.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Petr Mladek <pmladek@suse.com>, kernel test robot <lkp@intel.com>,
Lecopzer Chen <lecopzer.chen@mediatek.com>,
Pingfan Liu <kernelfans@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] watchdog/hardlockup: Avoid large stack frames in watchdog_hardlockup_check()
Date: Wed, 2 Aug 2023 09:27:20 +0200 [thread overview]
Message-ID: <ZMoFWK0uGdneJYVc@dhcp22.suse.cz> (raw)
In-Reply-To: <CAD=FV=Ujmyq-1GAvNJsrp=mj_Vg=9b6fmfMfkHq3+8ZQ5KiaRw@mail.gmail.com>
On Tue 01-08-23 08:41:49, Doug Anderson wrote:
[...]
> Ah, I see what you mean. The one issue I have with your solution is
> that the ordering of the stack crawls is less ideal in the "dump all"
> case when cpu != this_cpu. We really want to see the stack crawl of
> the locked up CPU first and _then_ see the stack crawls of other CPUs.
> With your solution the locked up CPU will be interspersed with all the
> others and will be harder to find in the output (you've got to match
> it up with the "Watchdog detected hard LOCKUP on cpu N" message).
> While that's probably not a huge deal, it's nicer to make the output
> easy to understand for someone trying to parse it...
Is it worth to waste memory for this arguably nicer output? Identifying
the stack of the locked up CPU is trivial.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2023-08-02 7:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 16:17 [PATCH] watchdog/hardlockup: Avoid large stack frames in watchdog_hardlockup_check() Douglas Anderson
2023-08-01 12:58 ` Michal Hocko
2023-08-01 14:16 ` Doug Anderson
2023-08-01 15:26 ` Michal Hocko
2023-08-01 15:41 ` Doug Anderson
2023-08-02 7:27 ` Michal Hocko [this message]
2023-08-02 14:12 ` Doug Anderson
2023-08-02 16:05 ` Michal Hocko
2023-08-03 8:12 ` Petr Mladek
2023-08-03 8:30 ` Michal Hocko
2023-08-03 23:10 ` Doug Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMoFWK0uGdneJYVc@dhcp22.suse.cz \
--to=mhocko@suse.com \
--cc=akpm@linux-foundation.org \
--cc=dianders@chromium.org \
--cc=kernelfans@gmail.com \
--cc=lecopzer.chen@mediatek.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=pmladek@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.