All of lore.kernel.org
 help / color / mirror / Atom feed
From: Cyril Hrubis <chrubis@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/pipe08: Remove the test
Date: Wed, 2 Aug 2023 12:00:43 +0200	[thread overview]
Message-ID: <ZMopSzK0MpPIj3p4@yuki> (raw)
In-Reply-To: <422745784.q2UjYaihZW@localhost>

Hi!
> > Hmm, this one is actually hard to figure out. Indeed the write test
> > implmenents the SIGPIPE case, however it would make more sense to have
> > the SIGPIPE test in syscalls/pipe/ directory instead. I guess that any
> > kernel developer that would like to use LTP for testing changes in
> > pipe() implementation would rather want to have the test under pipe/
> > directory.
> > 
> > Maybe we should keep the pipe08 test and remove the case from the
> > write05 test instead? Or should we keep both?
> 
> Thank you for your feedback. Now I too think we can keep both, but you guys 
> can decide. Please let me know, I can send the patch for pipe08 to convert to 
> new API if we decide to keep it.

I would wote for converting the test into the new API.

-- 
Cyril Hrubis
chrubis@suse.cz

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

      reply	other threads:[~2023-08-02 10:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-19 11:37 [LTP] [PATCH] syscalls/pipe08: Remove the test Avinesh Kumar
2023-07-21  9:32 ` Petr Vorel
2023-07-25 10:39 ` Cyril Hrubis
2023-08-02  9:25   ` Avinesh Kumar
2023-08-02 10:00     ` Cyril Hrubis [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMopSzK0MpPIj3p4@yuki \
    --to=chrubis@suse.cz \
    --cc=akumar@suse.de \
    --cc=ltp@lists.linux.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.