From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 714B5C00528 for ; Wed, 2 Aug 2023 10:42:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mMg305Wk8WXn/O2hUbtF/u1YdqHhiJ0Ziuu3xyhXP7k=; b=jOwC77jAA3mNf+ OgyBKpI2qn/cvHw9NZnsQVIfhrxUY3AMu8hSy/x28Izd5wZ6Z1ZjEQLp7B4zrg9aSmtkXWHblYwDb DQJDux3DwMRMQ3k7iFoDUjRC/8CCxlaujxlvTthPy0YqCnfHykwNcpazdQd2hI88oxPHoRB42ZF9e oOSopeTKK3VeXhDaCBXWON+GbK9P2v0fOhFHFWGl0g5y6YH8iCdrDXhNwbmAkas/VapcWXjejUXPO b84fHz7auHn+q02kP8/DBDtocppNQwmRjdlqYp0cX32ZtS/IAVOz4v44snxhppmOBRtNoO4P3mag2 D8843R6JeNh0Oy1vaWaQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qR9Ie-004cOC-2V; Wed, 02 Aug 2023 10:41:52 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qR9Id-004cNq-0G for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 10:41:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95FBC618F9; Wed, 2 Aug 2023 10:41:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACBB2C433C8; Wed, 2 Aug 2023 10:41:45 +0000 (UTC) Date: Wed, 2 Aug 2023 11:41:43 +0100 From: Catalin Marinas To: Kefeng Wang Cc: Andrew Morton , Will Deacon , Mike Kravetz , Muchun Song , Mina Almasry , kirill@shutemov.name, joel@joelfernandes.org, william.kucharski@oracle.com, kaleshsingh@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com Subject: Re: [PATCH v4] arm64: hugetlb: enable __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE Message-ID: References: <20230801135616.165067-1-wangkefeng.wang@huawei.com> <20230802012731.62512-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20230802012731.62512-1-wangkefeng.wang@huawei.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_034151_157376_2D424D30 X-CRM114-Status: GOOD ( 13.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 02, 2023 at 09:27:31AM +0800, Kefeng Wang wrote: > It is better to use huge page size instead of PAGE_SIZE > for stride when flush hugepage, which reduces the loop > in __flush_tlb_range(). > > Let's support arch's flush_hugetlb_tlb_range(), which is > used in hugetlb_unshare_all_pmds(), move_hugetlb_page_tables() > and hugetlb_change_protection() for now. > > Note, for hugepages based on contiguous bit, it has to be > invalidated individually since the contiguous PTE bit is > just a hint, the hardware may or may not take it into account. > > Signed-off-by: Kefeng Wang Reviewed-by: Catalin Marinas _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5740BC04A94 for ; Wed, 2 Aug 2023 10:41:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A039128014E; Wed, 2 Aug 2023 06:41:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 9B38A280143; Wed, 2 Aug 2023 06:41:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8A24628014E; Wed, 2 Aug 2023 06:41:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 77980280143 for ; Wed, 2 Aug 2023 06:41:51 -0400 (EDT) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 3221FB26D3 for ; Wed, 2 Aug 2023 10:41:51 +0000 (UTC) X-FDA: 81078824022.08.3F6C633 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf17.hostedemail.com (Postfix) with ESMTP id 939FC40010 for ; Wed, 2 Aug 2023 10:41:49 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690972909; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=1GX3YJB2KpLt20flOmKB/nqDnUDXZT50mkcEZHMuymc=; b=nLAfCYFHAxCsDuk0Bzud4G04tVUzjNIU5tWi8rw8CyLEzJJu3MmlIBfQN3APpLTrmFvv6/ QogulJxla33NOVgs00WNO/fa4S+vxmCXTbs3h/U6zf1b51B8jB4RLofb2wr4ZPPxTVEIHf aIcHmDN4ZPFdymjGRE1NOsywvTz/Rfs= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=arm.com (policy=none); spf=pass (imf17.hostedemail.com: domain of cmarinas@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=cmarinas@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690972909; a=rsa-sha256; cv=none; b=t1bZ/DV1BlHjS+ktuhMbUoxc/XsY1s2UaZ+aArDB/6+i3pju1gdgLVxRPYVZdDvYmMKvZL UnniW2J7FRjpI1DYGyf12rivOxbIHzM7JjQhCJD1FgL4Ly364BbHlXTN9v95UyZNfEG/p3 7/RJzWd7eUkrpb4TnzuSRPcx7VFV32A= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 95FBC618F9; Wed, 2 Aug 2023 10:41:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id ACBB2C433C8; Wed, 2 Aug 2023 10:41:45 +0000 (UTC) Date: Wed, 2 Aug 2023 11:41:43 +0100 From: Catalin Marinas To: Kefeng Wang Cc: Andrew Morton , Will Deacon , Mike Kravetz , Muchun Song , Mina Almasry , kirill@shutemov.name, joel@joelfernandes.org, william.kucharski@oracle.com, kaleshsingh@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, 21cnbao@gmail.com Subject: Re: [PATCH v4] arm64: hugetlb: enable __HAVE_ARCH_FLUSH_HUGETLB_TLB_RANGE Message-ID: References: <20230801135616.165067-1-wangkefeng.wang@huawei.com> <20230802012731.62512-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230802012731.62512-1-wangkefeng.wang@huawei.com> X-Rspam-User: X-Stat-Signature: mimzotmdroxkfi5fn6c7z1eo6j1xw1cd X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 939FC40010 X-HE-Tag: 1690972909-300371 X-HE-Meta: U2FsdGVkX18HHs6Yby/JiMv8cMSNCm4vfN7hRF9T7gGDt2KQMrZLU6yx513Rdt+/NId0v7iZ1J3ZzeGAAZU2egOvsmU5A2sgS0elawU6B4eGx+WoVOz3g6KOtMQ6to5DnbMKwPK5lKOMPZR1kHvVvHM0bGjv/TV0sfowkbSGWy6m1HgVAmlPxYe6Ql3zscBnLMtm+VqmHhhuonPX+11fESIplT9w5F/ByVrCn53JQvJAfWzTMOa+tej2RXyqd1InYR6/tKYF63P9m5XLbI7wyFTrjlTCxmDBbP/4wWcjUf86tfYyJXhtMdHTbyH2dbdt6sx2QpufN+e+IXDECwLxoLmwRpXF18gJ5fQAaXz2yIflwbXGvLOVyk8eVmA+rusKnHFJBVeSi7KVwssmT8VqSmtG6PwDgfiAKtA5c4aseNJLtX4G4wgQRytGqYNAgwfUEW3a3LHX01g9wrt5jzi7f3GLIfhCZEKZt+0Km3ABYdq4QA6XAuwkYOE7UBprrLHFQS3bBDjbIpo6MwyhQm+WujSuCS7IpYsp12b9c0T+lQLH2yEkMcxi66+eebXU9cIIiy8Gb2/TXAyqLhdVmr5q8Y6NwrN3dfPYnnnl3fP9/ZyVvjtMlK37MWAybVLex97BkBX3FnCPB1isqlpKLsDvsKJzJf/mlZjDNsiOzL4ggxDc85/vUV1JB2xm4hqHI1mwA6KMnL3KIgfoQpG2xPDMRzQsPTPic8xouZLF5SOxTlmUzC0MLkIb3Hm7onZSajk3m3wEW9iogiBxHj/NL2aI8Gr9OPulsV0o8QKpGS2JtGRm3gB7j1+u+FoTFDX12AkgGULl4dqLhnXO7QcRbzbmKQIRVaqbXgQXC1jLkPLX6KAnm8DmOHcJrp4plLYjheGoS+5M3+95Hffam57vt3ZueJcF9UKjzIWClccV0nhVfCJFVYbHz1Uadc4Ya6M9TkxmEk+74hjocNT6QAn+PKS UbnL02xi ygEZXF1kb+Bc9yLqQEiJqHbdeVHBd4ZNuNHV91RGHy0TBrv91MO81HhtdwlUNkPdCMQAJNgCSEpdSGB8acC3aj4f8gMb90+ev1coW2M4u10aMi3n3IVP1Qrmwn9GdiLF+9o2oAKqvdd0hOh3+2ybcOvZl9vLOK9zEmL8C3b5XExthmcijBL+He9rZVH5X5zzAZbBUBRAfl36tiO9SFPdpRMmk4aZm00NL3gWduCFk3dpzm5cg2fl8/XbunUrltKbfhhDeaYc7raF+kaaYV8zoSAW3YcnepsRJ6v9JyoC2kZhK2HkBzXj1py7fQx8pPc360S0r0W5gbV3JGkqofzJamR98EQr97sMLFlM9YUdiJUsYIDudxvGM5cijWijr7Zhc3VTMP5vB0M7WuiFrTXY4r8sUkDp+U+3MjV3w8jCL77rEkAcpjdYRLegnQvMuCKp9LbtJEg4IoeJU4aKZZE0VV8JheoMbnZYbJkQHKblLF0OEqFoAszacZHJaMhJzhTnoTx5rzhxLYJ+NZuwa/fwBs1Ltpy65S+IFTHRPFaOiqfG0OK8XHCRhgrssHCWrmdKksomv X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Aug 02, 2023 at 09:27:31AM +0800, Kefeng Wang wrote: > It is better to use huge page size instead of PAGE_SIZE > for stride when flush hugepage, which reduces the loop > in __flush_tlb_range(). > > Let's support arch's flush_hugetlb_tlb_range(), which is > used in hugetlb_unshare_all_pmds(), move_hugetlb_page_tables() > and hugetlb_change_protection() for now. > > Note, for hugepages based on contiguous bit, it has to be > invalidated individually since the contiguous PTE bit is > just a hint, the hardware may or may not take it into account. > > Signed-off-by: Kefeng Wang Reviewed-by: Catalin Marinas