From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A2861C001DE for ; Wed, 2 Aug 2023 23:34:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 37B4F10E583; Wed, 2 Aug 2023 23:34:59 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.31]) by gabe.freedesktop.org (Postfix) with ESMTPS id ED3BE10E155 for ; Wed, 2 Aug 2023 23:34:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691019297; x=1722555297; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7efkBciRE71+tn2Z25LoetMi/dJ33maLBxNsWpeV1tE=; b=gmsY1EN1lCyTUmu4O2KALQdOdtKBy9YCwgwZ8cQvvjPjhszwR9GO/PAz MSyExsW0c9fFh3O1ql8b3Q7jV2EPs2oothn/S13a1TytyoTrtiU9G5yq+ N1pxoTu+T7Uo3F+7HUiXxS4YAUZYIBgzEH6/QnnAky2/P8RMjW2//Oorx bJU53kyL1i7eH0/ZxV17GTEXb96HCYOBlfMxQXQc56Xe/P5KtSLcc9t4J QsNytQBUDOdWWRYzeLHlVnhGmX9JuUpbTgqZBtllqVLAFGB8yztWqaa/r ymX5Pq85qTsZLUcgMal2lVLi4dKkCDkIcJr150o0GzdQRXartvErpILAD g==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="433564382" X-IronPort-AV: E=Sophos;i="6.01,250,1684825200"; d="scan'208";a="433564382" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 16:34:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="975862534" X-IronPort-AV: E=Sophos;i="6.01,250,1684825200"; d="scan'208";a="975862534" Received: from mlytkin-mobl2.ger.corp.intel.com (HELO intel.com) ([10.252.38.55]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 16:34:53 -0700 Date: Thu, 3 Aug 2023 01:34:51 +0200 From: Andi Shyti To: Guenter Roeck Message-ID: References: <20230802135241.458855-1-badal.nilawar@intel.com> <20230802135241.458855-2-badal.nilawar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Subject: Re: [Intel-xe] [PATCH v3 1/6] drm/xe/hwmon: Add HWMON infrastructure X-BeenThere: intel-xe@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Xe graphics driver List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-hwmon@vger.kernel.org, intel-xe@lists.freedesktop.org Errors-To: intel-xe-bounces@lists.freedesktop.org Sender: "Intel-xe" Hi Guenter, [...] > > > +static const struct hwmon_channel_info *hwmon_info[] = { > > > + NULL > > > +}; > > > > just: > > > > static const struct hwmon_channel_info *hwmon_info[] = { }; > > > > would do. > > > > What would be the point ? This is just a placeholder, and we need > a NULL entry at the end. right... this series needs to be read from the end to the beginning :) Andi From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6597C00528 for ; Wed, 2 Aug 2023 23:34:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230132AbjHBXe6 (ORCPT ); Wed, 2 Aug 2023 19:34:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229580AbjHBXe5 (ORCPT ); Wed, 2 Aug 2023 19:34:57 -0400 Received: from mgamail.intel.com (unknown [134.134.136.31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D936C2D4B for ; Wed, 2 Aug 2023 16:34:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1691019296; x=1722555296; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=7efkBciRE71+tn2Z25LoetMi/dJ33maLBxNsWpeV1tE=; b=kWY51wZqHJ240RjwB+Mpgni+tigiZY/PR2b/9ZoEhYInVAXWLcH9xGuH SzQgj1HXc5+I+QsaCDrTNIuCex3VXt+vfCZeKzor6RnCyTO0xf/nyyzEZ ilN50a1FTRivFlsOiXRN6dsWa2hzJ7Q0cxhiswxCaDIJTFBx/dOIMJtHL 0mITvaGvdqJEAMxEn9wYe2oFo6CQ5ckNcU65OIjdjKO0c7bZrBpxs4NVH k67Ih0WZ2k8nyHFuiRb7tGTtBb5v3oCVcUUnEy9G60u3TYdCOL2ZPxkFQ 7owuLEMF1Ds9KD2ATiH/27TUF+C/OeJWuVNLw+MOtohCBijQHw5FYwyC6 w==; X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="433564380" X-IronPort-AV: E=Sophos;i="6.01,250,1684825200"; d="scan'208";a="433564380" Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga104.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 16:34:56 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10790"; a="975862534" X-IronPort-AV: E=Sophos;i="6.01,250,1684825200"; d="scan'208";a="975862534" Received: from mlytkin-mobl2.ger.corp.intel.com (HELO intel.com) ([10.252.38.55]) by fmsmga006-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2023 16:34:53 -0700 Date: Thu, 3 Aug 2023 01:34:51 +0200 From: Andi Shyti To: Guenter Roeck Cc: Andi Shyti , Badal Nilawar , intel-xe@lists.freedesktop.org, linux-hwmon@vger.kernel.org, anshuman.gupta@intel.com, ashutosh.dixit@intel.com, riana.tauro@intel.com, matthew.brost@intel.com Subject: Re: [PATCH v3 1/6] drm/xe/hwmon: Add HWMON infrastructure Message-ID: References: <20230802135241.458855-1-badal.nilawar@intel.com> <20230802135241.458855-2-badal.nilawar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-hwmon@vger.kernel.org Hi Guenter, [...] > > > +static const struct hwmon_channel_info *hwmon_info[] = { > > > + NULL > > > +}; > > > > just: > > > > static const struct hwmon_channel_info *hwmon_info[] = { }; > > > > would do. > > > > What would be the point ? This is just a placeholder, and we need > a NULL entry at the end. right... this series needs to be read from the end to the beginning :) Andi