All of lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Zhu Wang <wangzhu9@huawei.com>
Cc: horatiu.vultur@microchip.com, UNGLinuxDriver@microchip.com,
	davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
	pabeni@redhat.com, netdev@vger.kernel.org
Subject: Re: [PATCH -next] net: lan966x: Do not check 0 for platform_get_irq_byname()
Date: Thu, 3 Aug 2023 16:32:48 +0200	[thread overview]
Message-ID: <ZMu6kDiHMD1TjMUW@kernel.org> (raw)
In-Reply-To: <20230803082900.14921-1-wangzhu9@huawei.com>

On Thu, Aug 03, 2023 at 04:29:00PM +0800, Zhu Wang wrote:
> Since platform_get_irq_byname() never returned zero, so it need not to
> check whether it returned zero, it returned -EINVAL or -ENXIO when
> failed, so we replace the return error code with the result it returned.
> 
> Signed-off-by: Zhu Wang <wangzhu9@huawei.com>

For non-bugfix Networking patches, it is appropriate to
designate the target tree as 'net-next' rather than '-next'.
(For bug fixes 'net' is appropriate).

Link: https://docs.kernel.org/process/maintainer-netdev.html

Otherwise, this looks fine to me.

Reviewed-by: Simon Horman <horms@kernel.org>

  reply	other threads:[~2023-08-03 14:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-03  8:29 [PATCH -next] net: lan966x: Do not check 0 for platform_get_irq_byname() Zhu Wang
2023-08-03 14:32 ` Simon Horman [this message]
2023-08-03 19:41 ` Horatiu Vultur
2023-08-04 10:20 ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZMu6kDiHMD1TjMUW@kernel.org \
    --to=horms@kernel.org \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=horatiu.vultur@microchip.com \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=wangzhu9@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.