From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Biju Das <biju.das.jz@bp.renesas.com>
Cc: Wolfram Sang <wsa@kernel.org>,
linux-i2c@vger.kernel.org,
Geert Uytterhoeven <geert+renesas@glider.be>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v5 RESEND 3/4] i2c: i2c-core-of: Convert i2c_of_match_device_sysfs() to non-static
Date: Thu, 3 Aug 2023 15:08:27 +0300 [thread overview]
Message-ID: <ZMuYu7SaMRNFFWVq@smile.fi.intel.com> (raw)
In-Reply-To: <20230803103102.323987-4-biju.das.jz@bp.renesas.com>
On Thu, Aug 03, 2023 at 11:31:01AM +0100, Biju Das wrote:
> Currently i2c_of_match_device_sysfs() is used by i2c_of_match_device().
> Convert this to non-static function for finding match data for the I2C
> sysfs interface using i2c_device_get_match_data() for code reuse.
>
> While at it, fix the below issues:
> 1) Replace 'of_device_id*'->'of_device_id *' in function definition.
> 2) Fix the alignment in the function definition.
> 3) Change the struct i2c_client parameter as const to avoid overriding
> the client pointer.
All makes sense
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-03 12:08 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 10:30 [PATCH v5 RESEND 0/4] Extend device_get_match_data() to struct bus_type Biju Das
2023-08-03 10:30 ` [PATCH v5 RESEND 1/4] drivers: fwnode: " Biju Das
2023-08-03 12:00 ` Andy Shevchenko
2023-08-03 12:02 ` Sakari Ailus
2023-08-03 12:07 ` Andy Shevchenko
2023-08-03 12:13 ` Biju Das
2023-08-03 12:05 ` Biju Das
2023-08-03 12:12 ` Andy Shevchenko
2023-08-03 10:31 ` [PATCH v5 RESEND 2/4] i2c: Add i2c_device_get_match_data() callback Biju Das
2023-08-03 12:06 ` Andy Shevchenko
2023-08-03 13:52 ` Biju Das
2023-08-04 4:05 ` Andy Shevchenko
2023-08-03 10:31 ` [PATCH v5 RESEND 3/4] i2c: i2c-core-of: Convert i2c_of_match_device_sysfs() to non-static Biju Das
2023-08-03 12:08 ` Andy Shevchenko [this message]
2023-08-03 10:31 ` [PATCH v5 RESEND 4/4] i2c: Extend i2c_device_get_match_data() to support i2c sysfs Biju Das
2023-08-03 12:10 ` Andy Shevchenko
2023-08-03 12:13 ` [PATCH v5 RESEND 0/4] Extend device_get_match_data() to struct bus_type Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMuYu7SaMRNFFWVq@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=dmitry.torokhov@gmail.com \
--cc=geert+renesas@glider.be \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.