From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH v1 1/1] math.h: Document abs_diff()
Date: Fri, 4 Aug 2023 08:36:16 +0300 [thread overview]
Message-ID: <ZMyOUAgIRqkz2ett@smile.fi.intel.com> (raw)
In-Reply-To: <a1640e13-75b5-bc3c-74a6-5eaf6d74e7bc@infradead.org>
On Thu, Aug 03, 2023 at 10:23:48PM -0700, Randy Dunlap wrote:
> On 8/3/23 22:09, Andy Shevchenko wrote:
...
> > +/**
> > + * abs_diff - return absolute value of the difference between the arguments
> > + * @a: the first argument
> > + * @b: the second argument
> > + *
> > + * @a and @b has to be of the same type. With this restriction we compare
> Preferably s/has/have/.
Thank you! I fixed it locally, I hope Andrew can update this, but if needed
I will send a v2 with the proposed correction.
> > + * signed to signed and unsigned to unsigned. The result is the subtraction
> > + * the smaller of the two from the bigger, hence result is always a positive
> > + * value.
> > + *
> > + * Return: an absolute value of the difference between the @a and @b.
> > + */
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-04 5:37 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 5:09 [PATCH v1 1/1] math.h: Document abs_diff() Andy Shevchenko
2023-08-04 5:23 ` Randy Dunlap
2023-08-04 5:36 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMyOUAgIRqkz2ett@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=adobriyan@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.