From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Li Zetao <lizetao1@huawei.com>
Cc: gregkh@linuxfoundation.org, jirislaby@kernel.org,
jorge.sanjuangarcia@duagon.com, JoseJavier.Rodriguez@duagon.com,
yangyingliang@huawei.com, linux-serial@vger.kernel.org
Subject: Re: [PATCH -next] 8250_men_mcb: Fix unsigned expression compared with zero
Date: Fri, 4 Aug 2023 08:37:32 +0300 [thread overview]
Message-ID: <ZMyOnBcbIDjNX4Aa@smile.fi.intel.com> (raw)
In-Reply-To: <20230803142053.1308926-1-lizetao1@huawei.com>
On Thu, Aug 03, 2023 at 10:20:53PM +0800, Li Zetao wrote:
> There is a warning reported by coccinelle:
>
> ./drivers/tty/serial/8250/8250_men_mcb.c:226:6-19: WARNING:
> Unsigned expression compared with zero: data -> line [ i ] < 0
>
> The array "line" of serial_8250_men_mcb_data is used to record the
> registered serial port. When register a port failed, it will return
> an error code, but the type of "line" is "unsigned int", causing
> the error code to reverse. Modify the type of "data -> line" to solve
> this problem.
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
--
With Best Regards,
Andy Shevchenko
prev parent reply other threads:[~2023-08-04 5:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-03 14:20 [PATCH -next] 8250_men_mcb: Fix unsigned expression compared with zero Li Zetao
2023-08-04 5:07 ` Jiri Slaby
2023-08-04 6:36 ` Andy Shevchenko
2023-08-04 5:37 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMyOnBcbIDjNX4Aa@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=JoseJavier.Rodriguez@duagon.com \
--cc=gregkh@linuxfoundation.org \
--cc=jirislaby@kernel.org \
--cc=jorge.sanjuangarcia@duagon.com \
--cc=linux-serial@vger.kernel.org \
--cc=lizetao1@huawei.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.