From: Cyril Hrubis <chrubis@suse.cz>
To: Avinesh Kumar <akumar@suse.de>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH] syscalls/pipe08: Rewrite test using new LTP API
Date: Fri, 4 Aug 2023 11:20:03 +0200 [thread overview]
Message-ID: <ZMzCw2RZxQ0aLSAA@yuki> (raw)
In-Reply-To: <20230804053022.22008-1-akumar@suse.de>
Hi!
> +static int pipefd[2];
> +static int sigpipe_cnt;
I've changed this to volatile int in order to avoid miscompilation and
pushed, thanks.
Side note, anything that is changed asynchronously from a signal handler
is better to be declared volatile in order to avoid compiler from
assuming it's value, as the compiler does not understand that execution
flow can jump into a signal handler.
--
Cyril Hrubis
chrubis@suse.cz
--
Mailing list info: https://lists.linux.it/listinfo/ltp
prev parent reply other threads:[~2023-08-04 9:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-04 5:26 [LTP] [PATCH] syscalls/pipe08: Rewrite test using new LTP API Avinesh Kumar
2023-08-04 9:20 ` Cyril Hrubis [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZMzCw2RZxQ0aLSAA@yuki \
--to=chrubis@suse.cz \
--cc=akumar@suse.de \
--cc=ltp@lists.linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.