From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Fri, 18 Aug 2023 16:01:26 -0700 Subject: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() In-Reply-To: References: <20230718234512.1690985-29-seanjc@google.com> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Mon, Aug 07, 2023, Ackerley Tng wrote: > Sean Christopherson writes: > > > Add a selftest to verify the basic functionality of guest_memfd(): > > > > > > Here's one more test: First off, thank you! I greatly appreciate all the selftests work you (and others!) have been doing. For v2, can you please post a standalone patch? My workflow barfs on unrelated, inlined patches. I'm guessing I can get b4 to play nice, but it's easier to just yell at people :-) > >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 > From: Ackerley Tng > Date: Tue, 1 Aug 2023 18:02:50 +0000 > Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for > KVM_CREATE_GUEST_MEMFD > > Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as > non-page-aligned page size and invalid flags, are rejected by the > KVM_CREATE_GUEST_MEMFD with EINVAL > > Signed-off-by: Ackerley Tng > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ > .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index eb93c608a7e0..ad20f11b2d2c 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) > TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); > } > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) > +{ > + int fd; > + > + /* Non-page-aligned page_size */ Instead of adding a comment, use the message from TEST_ASSERT() to communicate that information to the reader *and* to anyone that encounters failures. > + fd = __vm_create_guest_memfd(vm, 1, 0); ioctls() are fast. Rather than hardcode one value, iterate over a range of values, e.g. for (size = 0; size < page_size; size++) { r = __vm_create_guest_memfd(vm, size, 0); TEST_ASSERT(r && errno == EINVAL, "Informative error message...); } > + ASSERT_EQ(errno, EINVAL); > + > + /* Invalid flags */ > + fd = __vm_create_guest_memfd(vm, page_size, 99); > + ASSERT_EQ(fd, -1); > + ASSERT_EQ(errno, EINVAL); And then same thing here. Then you can use the legal flags to determine what is and isn't valid, instead of using a completely arbitrary magic number. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-yb1-f201.google.com (mail-yb1-f201.google.com [209.85.219.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8EDC7174DA for ; Fri, 18 Aug 2023 23:01:29 +0000 (UTC) Received: by mail-yb1-f201.google.com with SMTP id 3f1490d57ef6-d745094c496so1166719276.1 for ; Fri, 18 Aug 2023 16:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=gS9arkhq2BQM5wyG90faWG4pywmMu5sfjHEWd04bKy84agcqatheT6YSVqsnMAhJXs 7Ey6R/IsFpbuJAgflRTfCsGQSeE7z8aCnsHRbxEkKBK/PAH7FMZgZEavx3BeBXM+3P+2 Plq9VhZaRy5PbOx8EDNA03ytcClkYRB9Plt+OD+UltS53ZO5IOuVPHa/Yt8AOkDtjpGf J0ReekJEPtY7ifZaoOCUWVj24ZOCPfNYabKI/jnVy+VGWVTelTn6BvdxHdiQrBc+k/kc BoETN+5H+qyvqSzJ4nWEMxKRREF2ybV9p6gaBfB8lx1V/iAPfjWa3WjZDIbTKQp0bm0Z IJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=LUx9k0lx+Z2Wc/n/fM9hkGmbawwAqKxpfahg6oNJKqopQ8ZjsOaPgplMCi2/nGRP5R p68mI1aViSnjTxh83L/m9vSgREWN+Pzvc9L7jxDwNFslB3+FiPbHyx87f6nyJTMQ7kgn qj8Ol2Uc15swp0Gpf6JnGlPU7nBBrEE2nnH5zEs1JZW3d8KgbyjL1qqQbmi1ElYzj2WO x+4PYYF/ZgTQoRoJ/bU97Zi+SB3zMJNiIZBAlmu0Yg4IYmNF6d1WFpAfpYlTgmxf0boF TZj4tSS1tCIWx45jh23IUclDCduI5RmqA1wsYoR+gN1PGtaRqVXscUf5VfNYMwAwRf3m f20w== X-Gm-Message-State: AOJu0YyAxIn3SiDKTTkHl3qBoZCbUMw/PFiMpBe/SjjdlT9dAmP1yRKm +sv9DuneFVnoW47zDmJ7+Y9xa9gghpc= X-Google-Smtp-Source: AGHT+IHoaUgHi5iMS/0Xt5cvUarFzMCVBDWHJfa8lAvVIAai8wyXyMLBOgyLMJxxiXlZfzlnoz9PoDeIZVI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:a8a:b0:d74:347:1e3 with SMTP id cd10-20020a0569020a8a00b00d74034701e3mr5755ybb.9.1692399688376; Fri, 18 Aug 2023 16:01:28 -0700 (PDT) Date: Fri, 18 Aug 2023 16:01:26 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230718234512.1690985-29-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() From: Sean Christopherson To: Ackerley Tng Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, willy@infradead.org, akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, yu.c.zhang@linux.intel.com, vannapurve@google.com, mail@maciej.szmigiero.name, vbabka@suse.cz, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com Content-Type: text/plain; charset="us-ascii" On Mon, Aug 07, 2023, Ackerley Tng wrote: > Sean Christopherson writes: > > > Add a selftest to verify the basic functionality of guest_memfd(): > > > > > > Here's one more test: First off, thank you! I greatly appreciate all the selftests work you (and others!) have been doing. For v2, can you please post a standalone patch? My workflow barfs on unrelated, inlined patches. I'm guessing I can get b4 to play nice, but it's easier to just yell at people :-) > >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 > From: Ackerley Tng > Date: Tue, 1 Aug 2023 18:02:50 +0000 > Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for > KVM_CREATE_GUEST_MEMFD > > Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as > non-page-aligned page size and invalid flags, are rejected by the > KVM_CREATE_GUEST_MEMFD with EINVAL > > Signed-off-by: Ackerley Tng > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ > .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index eb93c608a7e0..ad20f11b2d2c 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) > TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); > } > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) > +{ > + int fd; > + > + /* Non-page-aligned page_size */ Instead of adding a comment, use the message from TEST_ASSERT() to communicate that information to the reader *and* to anyone that encounters failures. > + fd = __vm_create_guest_memfd(vm, 1, 0); ioctls() are fast. Rather than hardcode one value, iterate over a range of values, e.g. for (size = 0; size < page_size; size++) { r = __vm_create_guest_memfd(vm, size, 0); TEST_ASSERT(r && errno == EINVAL, "Informative error message...); } > + ASSERT_EQ(errno, EINVAL); > + > + /* Invalid flags */ > + fd = __vm_create_guest_memfd(vm, page_size, 99); > + ASSERT_EQ(fd, -1); > + ASSERT_EQ(errno, EINVAL); And then same thing here. Then you can use the legal flags to determine what is and isn't valid, instead of using a completely arbitrary magic number. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 93F6EEE4992 for ; Fri, 18 Aug 2023 23:01:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=EPjxNyW4bduKlAVNVrsGSTymkUrL5OIKl0FRmz7AAhg=; b=thaiqgpO2jbOBVuJofS2LkG8oS cfzobKNOaNW9UD01fLI23k2HmLbpTY/5xhufr0M6K5TQJr6/XsJ8twE3twzkGOc7pPcJnUh0UZS62 d9QrzHdEbyzLi5LU0UaYXKzDHTLRXPYCRIZKPSEXt3tqy5S+JeA7K30cOx1YQlIlQ1/GWAXcWFPuI aDxjaZJOLCQfZDPIlPH/Iu7bfTYkJDCaTyejCmTQ6wDJszF4MeGfXwPwx99WZFNrq+3vsQezWx4HW 4k2AD+31a3Pp4PA2xNKlFIMvzv+FdvVdHmrJ2xN15nJ78vXs7SB4nRtPWCVwyGhFNLyqAqbBaq3ma jgzo1/SQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qX8TJ-00A8Jt-09; Fri, 18 Aug 2023 23:01:37 +0000 Received: from mail-yb1-xb4a.google.com ([2607:f8b0:4864:20::b4a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qX8TF-00A8IZ-1f for linux-riscv@lists.infradead.org; Fri, 18 Aug 2023 23:01:34 +0000 Received: by mail-yb1-xb4a.google.com with SMTP id 3f1490d57ef6-d67a458ff66so1779899276.3 for ; Fri, 18 Aug 2023 16:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=gS9arkhq2BQM5wyG90faWG4pywmMu5sfjHEWd04bKy84agcqatheT6YSVqsnMAhJXs 7Ey6R/IsFpbuJAgflRTfCsGQSeE7z8aCnsHRbxEkKBK/PAH7FMZgZEavx3BeBXM+3P+2 Plq9VhZaRy5PbOx8EDNA03ytcClkYRB9Plt+OD+UltS53ZO5IOuVPHa/Yt8AOkDtjpGf J0ReekJEPtY7ifZaoOCUWVj24ZOCPfNYabKI/jnVy+VGWVTelTn6BvdxHdiQrBc+k/kc BoETN+5H+qyvqSzJ4nWEMxKRREF2ybV9p6gaBfB8lx1V/iAPfjWa3WjZDIbTKQp0bm0Z IJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=CiZYVUC5ylx9gx70EVlbOkYE7TqtbjrkQogmGIhMXKeAIgu1hHo8e8OF7jukSv+ixI XHPihyXLw8Q0uslTI67UY2IB3xX7S8sm8yXhBENOsirKlzejSc+j74+o0RRI++XZD+Mn UNgAAKlRVDOT3mDgueDRO10xvDuJNCBOYwKQ07CuBpXYTlGhMlMarxZ67b7rTSGNvDHM TjLo7i2ELS4Pa5zl0YhAQRn2iNuUYAjRhG/OQrpOkm5FoiPhygTV8mCGn7ZA6Pg1rrof V3mlS8h1kTN3kLlt+PZswub3apYtcx6qlQ5875GVKPd/I9FmmXpypoK3EOX1VwyxNjsN MlvA== X-Gm-Message-State: AOJu0YzL+HXOJV7FBaTapqsJjccg6fcvUM47iUTTeVu70TRQ0XzAY1YY ALA52c2kOYeMyMvUu53927Oyf6AehRA= X-Google-Smtp-Source: AGHT+IHoaUgHi5iMS/0Xt5cvUarFzMCVBDWHJfa8lAvVIAai8wyXyMLBOgyLMJxxiXlZfzlnoz9PoDeIZVI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:a8a:b0:d74:347:1e3 with SMTP id cd10-20020a0569020a8a00b00d74034701e3mr5755ybb.9.1692399688376; Fri, 18 Aug 2023 16:01:28 -0700 (PDT) Date: Fri, 18 Aug 2023 16:01:26 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230718234512.1690985-29-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() From: Sean Christopherson To: Ackerley Tng Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, willy@infradead.org, akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, yu.c.zhang@linux.intel.com, vannapurve@google.com, mail@maciej.szmigiero.name, vbabka@suse.cz, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_160133_555843_D5554835 X-CRM114-Status: GOOD ( 21.80 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org On Mon, Aug 07, 2023, Ackerley Tng wrote: > Sean Christopherson writes: > > > Add a selftest to verify the basic functionality of guest_memfd(): > > > > > > Here's one more test: First off, thank you! I greatly appreciate all the selftests work you (and others!) have been doing. For v2, can you please post a standalone patch? My workflow barfs on unrelated, inlined patches. I'm guessing I can get b4 to play nice, but it's easier to just yell at people :-) > >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 > From: Ackerley Tng > Date: Tue, 1 Aug 2023 18:02:50 +0000 > Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for > KVM_CREATE_GUEST_MEMFD > > Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as > non-page-aligned page size and invalid flags, are rejected by the > KVM_CREATE_GUEST_MEMFD with EINVAL > > Signed-off-by: Ackerley Tng > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ > .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index eb93c608a7e0..ad20f11b2d2c 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) > TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); > } > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) > +{ > + int fd; > + > + /* Non-page-aligned page_size */ Instead of adding a comment, use the message from TEST_ASSERT() to communicate that information to the reader *and* to anyone that encounters failures. > + fd = __vm_create_guest_memfd(vm, 1, 0); ioctls() are fast. Rather than hardcode one value, iterate over a range of values, e.g. for (size = 0; size < page_size; size++) { r = __vm_create_guest_memfd(vm, size, 0); TEST_ASSERT(r && errno == EINVAL, "Informative error message...); } > + ASSERT_EQ(errno, EINVAL); > + > + /* Invalid flags */ > + fd = __vm_create_guest_memfd(vm, page_size, 99); > + ASSERT_EQ(fd, -1); > + ASSERT_EQ(errno, EINVAL); And then same thing here. Then you can use the legal flags to determine what is and isn't valid, instead of using a completely arbitrary magic number. _______________________________________________ linux-riscv mailing list linux-riscv@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-riscv From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 90424EE4992 for ; Fri, 18 Aug 2023 23:02:32 +0000 (UTC) Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=gS9arkhq; dkim-atps=neutral Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4RSHT242dFz3cTD for ; Sat, 19 Aug 2023 09:02:30 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=google.com header.i=@google.com header.a=rsa-sha256 header.s=20221208 header.b=gS9arkhq; dkim-atps=neutral Authentication-Results: lists.ozlabs.org; spf=pass (sender SPF authorized) smtp.mailfrom=flex--seanjc.bounces.google.com (client-ip=2607:f8b0:4864:20::b49; helo=mail-yb1-xb49.google.com; envelope-from=3spjfzaykdouzlhuqjnvvnsl.jvtspubewwj-klcspzaz.vgshiz.vyn@flex--seanjc.bounces.google.com; receiver=lists.ozlabs.org) Received: from mail-yb1-xb49.google.com (mail-yb1-xb49.google.com [IPv6:2607:f8b0:4864:20::b49]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4RSHRz4dNGz2yPq for ; Sat, 19 Aug 2023 09:01:33 +1000 (AEST) Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d745094c496so1166723276.1 for ; Fri, 18 Aug 2023 16:01:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=gS9arkhq2BQM5wyG90faWG4pywmMu5sfjHEWd04bKy84agcqatheT6YSVqsnMAhJXs 7Ey6R/IsFpbuJAgflRTfCsGQSeE7z8aCnsHRbxEkKBK/PAH7FMZgZEavx3BeBXM+3P+2 Plq9VhZaRy5PbOx8EDNA03ytcClkYRB9Plt+OD+UltS53ZO5IOuVPHa/Yt8AOkDtjpGf J0ReekJEPtY7ifZaoOCUWVj24ZOCPfNYabKI/jnVy+VGWVTelTn6BvdxHdiQrBc+k/kc BoETN+5H+qyvqSzJ4nWEMxKRREF2ybV9p6gaBfB8lx1V/iAPfjWa3WjZDIbTKQp0bm0Z IJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=il7euFWf5CQNBLqxn3M+KEc5pJmgyE4dRlHoTekm2Ujvxp7rQlbNTBGLSRqd7x58DD 0FFhZDvdJmE38LXE+p4ZdsIkvW4X34Th68V8Oa04Mhv0LP9ZhH1jgLlzDlEk71MlpM9b 2SLu1QR8M66wZGmCihk5drxGEExGa1KBWhRCOqRwLpBZ2n2pkUdQ3KS8t/BsIcM5zi9C wfwuzWmCwB+lWpUtrEJ3GP+Cv/8nS1LdW2RNDdv+3k69jBz5PEBOx0reE3m0fP/gFzie vtRiXes9NZ240hzoY0cDOThchvOqsVDvcK7QrNYnVIVGUrXFMuVZp+lv0AOBAYtpYcAv i57g== X-Gm-Message-State: AOJu0YyDvMbPjxpE3j7UxtulKXYhSzuZdu5R+1d4Z32rzc3laywB8E3D IRhT/LMutRyLCH/FVbGRI3emby3Y1fo= X-Google-Smtp-Source: AGHT+IHoaUgHi5iMS/0Xt5cvUarFzMCVBDWHJfa8lAvVIAai8wyXyMLBOgyLMJxxiXlZfzlnoz9PoDeIZVI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:a8a:b0:d74:347:1e3 with SMTP id cd10-20020a0569020a8a00b00d74034701e3mr5755ybb.9.1692399688376; Fri, 18 Aug 2023 16:01:28 -0700 (PDT) Date: Fri, 18 Aug 2023 16:01:26 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230718234512.1690985-29-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() From: Sean Christopherson To: Ackerley Tng Content-Type: text/plain; charset="us-ascii" X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kvm@vger.kernel.org, david@redhat.com, yu.c.zhang@linux.intel.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, chao.p.peng@linux.intel.com, linux-riscv@lists.infradead.org, isaku.yamahata@gmail.com, paul@paul-moore.com, maz@kernel.org, chenhuacai@kernel.org, jmorris@namei.org, willy@infradead.org, wei.w.wang@intel.com, tabba@google.com, jarkko@kernel.org, serge@hallyn.com, mail@maciej.szmigiero.name, aou@eecs.berkeley.edu, vbabka@suse.cz, michael.roth@amd.com, paul.walmsley@sifive.com, kvmarm@lists.linux.dev, linux-arm-kernel@lists.infradead.org, qperret@google.com, liam.merwick@oracle.com, linux-mips@vger.kernel.org, oliver.upton@linux.dev, linux-security-module@vger.kernel.org, palmer@dabbelt.com, kvm-riscv@lists.infradead.org, anup@brainfault.org, linux-fsdevel@vger.kernel.org, pbonzini@redhat.com, akpm@linux-foundation.org, vannapurve@google.com, linuxppc-dev@lists.ozlabs.org, kirill.shutemov@linux.intel.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Mon, Aug 07, 2023, Ackerley Tng wrote: > Sean Christopherson writes: > > > Add a selftest to verify the basic functionality of guest_memfd(): > > > > > > Here's one more test: First off, thank you! I greatly appreciate all the selftests work you (and others!) have been doing. For v2, can you please post a standalone patch? My workflow barfs on unrelated, inlined patches. I'm guessing I can get b4 to play nice, but it's easier to just yell at people :-) > >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 > From: Ackerley Tng > Date: Tue, 1 Aug 2023 18:02:50 +0000 > Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for > KVM_CREATE_GUEST_MEMFD > > Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as > non-page-aligned page size and invalid flags, are rejected by the > KVM_CREATE_GUEST_MEMFD with EINVAL > > Signed-off-by: Ackerley Tng > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ > .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index eb93c608a7e0..ad20f11b2d2c 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) > TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); > } > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) > +{ > + int fd; > + > + /* Non-page-aligned page_size */ Instead of adding a comment, use the message from TEST_ASSERT() to communicate that information to the reader *and* to anyone that encounters failures. > + fd = __vm_create_guest_memfd(vm, 1, 0); ioctls() are fast. Rather than hardcode one value, iterate over a range of values, e.g. for (size = 0; size < page_size; size++) { r = __vm_create_guest_memfd(vm, size, 0); TEST_ASSERT(r && errno == EINVAL, "Informative error message...); } > + ASSERT_EQ(errno, EINVAL); > + > + /* Invalid flags */ > + fd = __vm_create_guest_memfd(vm, page_size, 99); > + ASSERT_EQ(fd, -1); > + ASSERT_EQ(errno, EINVAL); And then same thing here. Then you can use the legal flags to determine what is and isn't valid, instead of using a completely arbitrary magic number. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8C5B6EE499E for ; Fri, 18 Aug 2023 23:02:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=AvUHCVHJbiCcoKmRKXXmVV6avks5erU6g98IkVbf+N4=; b=dMB8tj1g5Ait4pFnA8s8CM3JEb 0FjGoV5iULcBUv8gqMbiLUP0ibct0sjOylOcFZiGFTVOoQQ9yLGckuzW9Jp+L0HF1vjvKF760fIqu QC89OPq67PaykG7nDQFu54KOman3F5vIbFDfZtM4q7FuqtSgnspEbwl8PoAB3l1c3m42xoAETukLI 0jiPrcN42c0Wwtch6IzQRCJmqfLiJFn32HNv+I2VCmNSDsVg3W5pfxCCsiXAo1uKVTy3V+KDpNnWv OsCgl1d34MpE0l1Qhri6g9IG3cBVUwE5wgs1p/+CWeOu/VLmdZWPd7XDA+Cz4zh8/Iz1GY75MuxWk Fz63ghpg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qX8TH-00A8JZ-1i; Fri, 18 Aug 2023 23:01:35 +0000 Received: from mail-yb1-xb49.google.com ([2607:f8b0:4864:20::b49]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qX8TE-00A8IX-1D for linux-arm-kernel@lists.infradead.org; Fri, 18 Aug 2023 23:01:33 +0000 Received: by mail-yb1-xb49.google.com with SMTP id 3f1490d57ef6-d67a458ff66so1779900276.3 for ; Fri, 18 Aug 2023 16:01:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=gS9arkhq2BQM5wyG90faWG4pywmMu5sfjHEWd04bKy84agcqatheT6YSVqsnMAhJXs 7Ey6R/IsFpbuJAgflRTfCsGQSeE7z8aCnsHRbxEkKBK/PAH7FMZgZEavx3BeBXM+3P+2 Plq9VhZaRy5PbOx8EDNA03ytcClkYRB9Plt+OD+UltS53ZO5IOuVPHa/Yt8AOkDtjpGf J0ReekJEPtY7ifZaoOCUWVj24ZOCPfNYabKI/jnVy+VGWVTelTn6BvdxHdiQrBc+k/kc BoETN+5H+qyvqSzJ4nWEMxKRREF2ybV9p6gaBfB8lx1V/iAPfjWa3WjZDIbTKQp0bm0Z IJkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692399688; x=1693004488; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=usNReEG1yhZ2OoI1bkcsHZxi8vJT2uNEbLMV9P1BADc=; b=UIY465uTDWFOuNLYNfwrvB6FQfvDlMMfHo+9z+1lYJ+CielsiOw2CxXRXmzeMMpRs5 jaYobLgsIePXpEwen154L78Rl53W1WVgWVazfsAyDsq25kF/1xkBNg+iQa2Wd8fq8H3c 6BQUnoq7CuBy7LIxdVqCO134dRKjGzfR9Q4Qm8D42pOuqjiJ5pATER/wWooZt3NboRG8 q/htDfpm8K5ONvL1W+AJf7/oAETWBI7B4xkyNhEc8ciom49EY5WVfnqiit4E/MYxBL6z QKnqRUPnVOk3acfPSnPi6K6AFMofCVaQ+GfiARBcsvqMJlCGQiv28G7U1jEuIwVFqy93 COVw== X-Gm-Message-State: AOJu0Yy0ECJiCThy8vCGfXrWNOMFt26pitr1xrtr6nh4r0WvkwiKhj4t cXr9Yvm9Qh53KlI6iADdTv7dbh8xbW0= X-Google-Smtp-Source: AGHT+IHoaUgHi5iMS/0Xt5cvUarFzMCVBDWHJfa8lAvVIAai8wyXyMLBOgyLMJxxiXlZfzlnoz9PoDeIZVI= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a05:6902:a8a:b0:d74:347:1e3 with SMTP id cd10-20020a0569020a8a00b00d74034701e3mr5755ybb.9.1692399688376; Fri, 18 Aug 2023 16:01:28 -0700 (PDT) Date: Fri, 18 Aug 2023 16:01:26 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230718234512.1690985-29-seanjc@google.com> Message-ID: Subject: Re: [RFC PATCH v11 28/29] KVM: selftests: Add basic selftest for guest_memfd() From: Sean Christopherson To: Ackerley Tng Cc: pbonzini@redhat.com, maz@kernel.org, oliver.upton@linux.dev, chenhuacai@kernel.org, mpe@ellerman.id.au, anup@brainfault.org, paul.walmsley@sifive.com, palmer@dabbelt.com, aou@eecs.berkeley.edu, willy@infradead.org, akpm@linux-foundation.org, paul@paul-moore.com, jmorris@namei.org, serge@hallyn.com, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-security-module@vger.kernel.org, linux-kernel@vger.kernel.org, chao.p.peng@linux.intel.com, tabba@google.com, jarkko@kernel.org, yu.c.zhang@linux.intel.com, vannapurve@google.com, mail@maciej.szmigiero.name, vbabka@suse.cz, david@redhat.com, qperret@google.com, michael.roth@amd.com, wei.w.wang@intel.com, liam.merwick@oracle.com, isaku.yamahata@gmail.com, kirill.shutemov@linux.intel.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230818_160132_418384_5A15786E X-CRM114-Status: GOOD ( 23.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Aug 07, 2023, Ackerley Tng wrote: > Sean Christopherson writes: > > > Add a selftest to verify the basic functionality of guest_memfd(): > > > > > > Here's one more test: First off, thank you! I greatly appreciate all the selftests work you (and others!) have been doing. For v2, can you please post a standalone patch? My workflow barfs on unrelated, inlined patches. I'm guessing I can get b4 to play nice, but it's easier to just yell at people :-) > >From 72dc6836f01bdd613d64d4c6a4f2af8f2b777ba2 Mon Sep 17 00:00:00 2001 > From: Ackerley Tng > Date: Tue, 1 Aug 2023 18:02:50 +0000 > Subject: [PATCH] KVM: selftests: Add tests - invalid inputs for > KVM_CREATE_GUEST_MEMFD > > Test that invalid inputs for KVM_CREATE_GUEST_MEMFD, such as > non-page-aligned page size and invalid flags, are rejected by the > KVM_CREATE_GUEST_MEMFD with EINVAL > > Signed-off-by: Ackerley Tng > --- > tools/testing/selftests/kvm/guest_memfd_test.c | 17 +++++++++++++++++ > .../selftests/kvm/include/kvm_util_base.h | 11 +++++++++-- > 2 files changed, 26 insertions(+), 2 deletions(-) > > diff --git a/tools/testing/selftests/kvm/guest_memfd_test.c b/tools/testing/selftests/kvm/guest_memfd_test.c > index eb93c608a7e0..ad20f11b2d2c 100644 > --- a/tools/testing/selftests/kvm/guest_memfd_test.c > +++ b/tools/testing/selftests/kvm/guest_memfd_test.c > @@ -90,6 +90,21 @@ static void test_fallocate(int fd, size_t page_size, size_t total_size) > TEST_ASSERT(!ret, "fallocate to restore punched hole should succeed"); > } > > +static void test_create_guest_memfd_invalid(struct kvm_vm *vm, size_t page_size) > +{ > + int fd; > + > + /* Non-page-aligned page_size */ Instead of adding a comment, use the message from TEST_ASSERT() to communicate that information to the reader *and* to anyone that encounters failures. > + fd = __vm_create_guest_memfd(vm, 1, 0); ioctls() are fast. Rather than hardcode one value, iterate over a range of values, e.g. for (size = 0; size < page_size; size++) { r = __vm_create_guest_memfd(vm, size, 0); TEST_ASSERT(r && errno == EINVAL, "Informative error message...); } > + ASSERT_EQ(errno, EINVAL); > + > + /* Invalid flags */ > + fd = __vm_create_guest_memfd(vm, page_size, 99); > + ASSERT_EQ(fd, -1); > + ASSERT_EQ(errno, EINVAL); And then same thing here. Then you can use the legal flags to determine what is and isn't valid, instead of using a completely arbitrary magic number. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel