From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Konstantin Kostiuk <kkostiuk@redhat.com>
Cc: Efim Shevrin <efim.shevrin@virtuozzo.com>,
qemu-devel@nongnu.org, michael.roth@amd.com, pbonzini@redhat.com,
den@openvz.org
Subject: Re: [PATCH] qga: Start qemu-ga service after NetworkManager start
Date: Thu, 17 Aug 2023 11:28:49 +0100 [thread overview]
Message-ID: <ZN32YVFOGSgIATTP@redhat.com> (raw)
In-Reply-To: <CAPMcbCowQoNn4b-Q+wFeT8m2OTFU+PDkDGq8=U--tdeEcDjk6Q@mail.gmail.com>
On Thu, Aug 17, 2023 at 09:15:08AM +0300, Konstantin Kostiuk wrote:
> Hi, Efim
>
> Thanks for your contribution.
>
> I think your patch is a partial solution because other network managers can
> be used
> for example systemd-networkd or dhcpcd. Maybe a better solution is
> After=network.target.
network.target does not imply that any NICs are configured with
an IP address, merely that the networking mgmt daemon(s) are
running. A dep on NetworkManager.service has the same issue.
NetworkManager has started, but this doesn't imply DHCP has
completed
network-online.target has the semantics that an IP is present,
but per my other reply I don't think we should be serializing
QGA startup against network configuration.
With regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2023-08-17 10:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-16 20:04 [PATCH] qga: Start qemu-ga service after NetworkManager start Efim Shevrin via
2023-08-17 6:15 ` Konstantin Kostiuk
2023-08-17 10:28 ` Daniel P. Berrangé [this message]
2023-08-17 10:26 ` Daniel P. Berrangé
2023-08-17 10:47 ` Denis V. Lunev
2023-08-17 11:24 ` Daniel P. Berrangé
2023-08-17 10:53 ` Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZN32YVFOGSgIATTP@redhat.com \
--to=berrange@redhat.com \
--cc=den@openvz.org \
--cc=efim.shevrin@virtuozzo.com \
--cc=kkostiuk@redhat.com \
--cc=michael.roth@amd.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.