From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: Mark Brown <broonie@kernel.org>,
alsa-devel@alsa-project.org,
Andrey Utkin <andrey_utkin@fastmail.com>,
Anton Sviridenko <anton@corp.bluecherry.net>,
Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>,
Banajit Goswami <bgoswami@quicinc.com>,
Bluecherry Maintainers <maintainers@bluecherrydvr.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>,
Ismael Luceno <ismael@iodev.co.uk>,
Lars-Peter Clausen <lars@metafoo.de>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>,
Olivier Moysan <olivier.moysan@foss.st.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
linux-media@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t
Date: Mon, 7 Aug 2023 19:00:07 +0300 [thread overview]
Message-ID: <ZNEVB8ZJah9Y9Bua@smile.fi.intel.com> (raw)
In-Reply-To: <87pm3yj2s5.wl-tiwai@suse.de>
On Mon, Aug 07, 2023 at 05:22:18PM +0200, Takashi Iwai wrote:
> On Tue, 01 Aug 2023 19:51:39 +0200, Andy Shevchenko wrote:
> > On Tue, Aug 01, 2023 at 02:54:45PM +0200, Takashi Iwai wrote:
...
> I rather wonder why it can't be simple strncpy().
This is obvious. To avoid compiler warning about 0 (possible) truncation.
...
> > Taking all remarks into account I would rather go with sockptr.h being
> > untouched for now, just a big
> >
> > /* DO NOT USE, it's obsolete, use uniptr.h instead! */
> >
> > to be added.
>
> Possibly that's a safer choice. But the biggest question is whether
> we want a generic type or not. Let's try to ask it first.
>
> Interestingly, this file doesn't belong to any subsystem in
> MAINTAINERS, so I'm not sure who to be Cc'ed. Chirstoph as the
> original author and net dev, maybe.
Yes, but actually it's fine to just copy and change sockptr.h to say
"that's blablabla for net subsystem" (maybe this is implied by the name?).
In that case we just introduce our copy and can do whatever modifications
we want (see previous reply).
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-07 16:01 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-31 15:46 [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Takashi Iwai
2023-07-31 15:46 ` [PATCH 01/24] ALSA: pcm: Add copy ops with universal sockptr_t Takashi Iwai
2023-07-31 15:46 ` [PATCH 02/24] ALSA: core: Add memory copy helpers between sockptr and iomem Takashi Iwai
2023-07-31 15:46 ` [PATCH 03/24] ALSA: dummy: Convert to generic PCM copy ops Takashi Iwai
2023-07-31 15:46 ` [PATCH 04/24] ALSA: gus: " Takashi Iwai
2023-07-31 15:46 ` [PATCH 05/24] ALSA: emu8000: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 06/24] ALSA: es1938: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 07/24] ALSA: korg1212: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 08/24] ALSA: nm256: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 09/24] ALSA: rme32: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 10/24] ALSA: rme96: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 11/24] ALSA: hdsp: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 12/24] ALSA: rme9652: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 13/24] ALSA: sh: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 14/24] ALSA: xen: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 15/24] ALSA: pcmtest: Update comment about " Takashi Iwai
2023-07-31 15:47 ` [PATCH 16/24] media: solo6x10: Convert to generic " Takashi Iwai
2023-07-31 15:47 ` [PATCH 17/24] ASoC: component: Add " Takashi Iwai
2023-07-31 15:47 ` [PATCH 18/24] ASoC: mediatek: Convert to " Takashi Iwai
2023-07-31 15:47 ` [PATCH 19/24] ASoC: qcom: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 20/24] ASoC: dmaengine: " Takashi Iwai
2023-07-31 15:47 ` [PATCH 21/24] ASoC: dmaengine: Use sockptr_t for process callback, too Takashi Iwai
2023-07-31 15:47 ` [PATCH 22/24] ALSA: doc: Update description for the new PCM copy ops Takashi Iwai
2023-07-31 15:47 ` [PATCH 23/24] ASoC: pcm: Drop obsoleted PCM copy_user ops Takashi Iwai
2023-07-31 15:47 ` [PATCH 24/24] ALSA: pcm: Drop obsoleted PCM copy_user and copy_kernel ops Takashi Iwai
2023-07-31 17:20 ` [PATCH 00/24] ALSA: Generic PCM copy ops using sockptr_t Mark Brown
2023-07-31 19:30 ` Takashi Iwai
2023-07-31 19:40 ` Mark Brown
2023-08-01 12:54 ` Takashi Iwai
2023-08-01 14:04 ` Mark Brown
2023-08-01 17:51 ` Andy Shevchenko
2023-08-07 15:22 ` Takashi Iwai
2023-08-07 16:00 ` Andy Shevchenko [this message]
2023-08-01 13:57 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNEVB8ZJah9Y9Bua@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=andrey_utkin@fastmail.com \
--cc=anton@corp.bluecherry.net \
--cc=arnaud.pouliquen@foss.st.com \
--cc=bgoswami@quicinc.com \
--cc=broonie@kernel.org \
--cc=claudiu.beznea@microchip.com \
--cc=ismael@iodev.co.uk \
--cc=lars@metafoo.de \
--cc=linux-media@vger.kernel.org \
--cc=maintainers@bluecherrydvr.com \
--cc=mchehab@kernel.org \
--cc=oleksandr_andrushchenko@epam.com \
--cc=olivier.moysan@foss.st.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.de \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.