From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Marcus Folkesson <marcus.folkesson@gmail.com>,
Kent Gustavsson <kent@minoris.se>,
Jonathan Cameron <jic23@kernel.org>,
Lars-Peter Clausen <lars@metafoo.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Cosmin Tanislav <demonsingur@gmail.com>,
Arnd Bergmann <arnd@arndb.de>,
ChiYuan Huang <cy_huang@richtek.com>,
Haibo Chen <haibo.chen@nxp.com>,
Ramona Bolboaca <ramona.bolboaca@analog.com>,
Ibrahim Tilki <Ibrahim.Tilki@analog.com>,
ChiaEn Wu <chiaen_wu@richtek.com>,
William Breathitt Gray <william.gray@linaro.org>,
linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 2/2] iio: adc: mcp3911: add support for the whole MCP39xx family
Date: Tue, 8 Aug 2023 16:26:50 +0300 [thread overview]
Message-ID: <ZNJCms2os3mKV7Uh@smile.fi.intel.com> (raw)
In-Reply-To: <74abc9e0-ba9a-d7ec-4f1c-815f8e351701@linaro.org>
On Tue, Aug 08, 2023 at 09:49:43AM +0200, Krzysztof Kozlowski wrote:
> On 08/08/2023 09:22, Marcus Folkesson wrote:
...
> >>> + ret = device_property_read_u32(&adc->spi->dev, "microchip,device-addr", &adc->dev_addr);
> >>
> >> Why not spi->dev? Ditto for other uses like this.
> >
> > After all, I think it is better to stick sith adc->spi-dev to be
> > consistent with the rest of the probe function. Change to spi->dev
> > should probably be a seperate patch.
> > Do you agree?
> >
>
> You can first simplify the usages and then add new family support
> already using spi->dev.
He-he, answered the same :-)
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-08 17:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 7:18 [PATCH v3 1/2] dt-bindings: iio: adc: mcp3911: add support for the whole MCP39xx family Marcus Folkesson
2023-08-07 7:18 ` [PATCH v3 2/2] " Marcus Folkesson
2023-08-07 15:53 ` Andy Shevchenko
2023-08-08 7:22 ` Marcus Folkesson
2023-08-08 7:49 ` Krzysztof Kozlowski
2023-08-08 13:26 ` Andy Shevchenko [this message]
2023-08-08 13:26 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNJCms2os3mKV7Uh@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Ibrahim.Tilki@analog.com \
--cc=arnd@arndb.de \
--cc=chiaen_wu@richtek.com \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=demonsingur@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=haibo.chen@nxp.com \
--cc=jic23@kernel.org \
--cc=kent@minoris.se \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcus.folkesson@gmail.com \
--cc=ramona.bolboaca@analog.com \
--cc=robh+dt@kernel.org \
--cc=william.gray@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.