From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tina Zhang <tina.zhang@intel.com>
Cc: Kevin Tian <kevin.tian@intel.com>,
Lu Baolu <baolu.lu@linux.intel.com>,
Michael Shavit <mshavit@google.com>,
iommu@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] iommu: Add mm_get_pasid() helper function
Date: Tue, 8 Aug 2023 12:02:23 -0300 [thread overview]
Message-ID: <ZNJY/9pwRxIkFEjD@ziepe.ca> (raw)
In-Reply-To: <20230808074944.7825-2-tina.zhang@intel.com>
On Tue, Aug 08, 2023 at 03:49:40PM +0800, Tina Zhang wrote:
> mm_get_pasid() is for getting mm pasid value.
>
> The motivation is to replace mm->pasid with an iommu private data
> structure that is introduced in a later patch.
Maybe we should start out by calling it what it actually is:
'mm_get_enqcmd_pasid()'
We can't actually have multiple SVA domains with different PASIDs
until the places wrongly calling this are removed :\
eg, I would expect this series to also come with removing
'pasid_private' from the Intel driver.
The mmu_notifier should be placed in the singular iommu_domain that is
the SVA domain for the mm. Drivers should not attempt to de-duplicate
this, the core code will do it like you are showing in this series.
Jason
next prev parent reply other threads:[~2023-08-08 15:02 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 7:49 [PATCH 0/5] Share sva domains with all devices bound to a mm Tina Zhang
2023-08-08 7:49 ` [PATCH 1/5] iommu: Add mm_get_pasid() helper function Tina Zhang
2023-08-08 15:02 ` Jason Gunthorpe [this message]
2023-08-09 0:31 ` Baolu Lu
2023-08-09 9:47 ` Tian, Kevin
2023-08-09 12:31 ` Jason Gunthorpe
2023-08-08 7:49 ` [PATCH 2/5] iommu: Call helper function to get assigned pasid value Tina Zhang
2023-08-09 0:21 ` Baolu Lu
2023-08-09 9:49 ` Tian, Kevin
2023-08-09 10:58 ` Baolu Lu
2023-08-09 14:48 ` Jason Gunthorpe
2023-08-10 1:37 ` Baolu Lu
2023-08-10 16:30 ` Jason Gunthorpe
2023-08-09 12:35 ` Jason Gunthorpe
2023-08-10 7:52 ` Tian, Kevin
2023-08-10 16:36 ` Jason Gunthorpe
2023-08-11 3:18 ` Tian, Kevin
2023-08-08 7:49 ` [PATCH 3/5] mm: Add structure to keep sva information Tina Zhang
2023-08-08 7:49 ` [PATCH 4/5] iommu: Support mm PASID 1:n with sva domains Tina Zhang
2023-08-08 15:12 ` Jason Gunthorpe
2023-08-08 15:19 ` Jason Gunthorpe
2023-08-10 2:14 ` Tina Zhang
2023-08-08 7:49 ` [PATCH 5/5] mm: Deprecate pasid field Tina Zhang
2023-08-09 0:18 ` [PATCH 0/5] Share sva domains with all devices bound to a mm Baolu Lu
2023-08-09 9:44 ` Tian, Kevin
2023-08-09 10:51 ` Baolu Lu
2023-08-11 1:06 ` Tina Zhang
2023-08-09 14:46 ` Jason Gunthorpe
2023-08-10 1:23 ` Baolu Lu
2023-08-10 7:44 ` Tian, Kevin
2023-08-09 9:41 ` Tian, Kevin
2023-08-10 1:31 ` Tina Zhang
2023-08-10 7:49 ` Tian, Kevin
2023-08-10 16:27 ` Jason Gunthorpe
2023-08-11 1:12 ` Tina Zhang
2023-08-11 1:07 ` Tina Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNJY/9pwRxIkFEjD@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=baolu.lu@linux.intel.com \
--cc=iommu@lists.linux.dev \
--cc=kevin.tian@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mshavit@google.com \
--cc=tina.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.