From mboxrd@z Thu Jan 1 00:00:00 1970 From: Sean Christopherson Date: Tue, 8 Aug 2023 08:07:43 -0700 Subject: [PATCH v7 02/12] KVM: arm64: Use kvm_arch_flush_remote_tlbs() In-Reply-To: References: <20230722022251.3446223-1-rananta@google.com> <20230722022251.3446223-3-rananta@google.com> <87tttpr6qy.wl-maz@kernel.org> <877cqdqw12.wl-maz@kernel.org> Message-ID: List-Id: To: kvm-riscv@lists.infradead.org MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit On Fri, Aug 04, 2023, Raghavendra Rao Ananta wrote: > On Wed, Aug 2, 2023 at 4:28?PM Raghavendra Rao Ananta > wrote: > > > > Sure, I'll change it to kvm_arch_flush_vm_tlbs() in v8. > > > While working on the renaming, I realized that since this function is > called from kvm_main.c's kvm_flush_remote_tlbs(). Do we want to rename > this and the other kvm_flush_*() functions that the series introduces > to match their kvm_arch_flush_*() counterparts? Hmm, if we're going to rename one arch hook, then yes, I think it makes sense to rename all the common APIs and arch hooks to match. However, x86 is rife with the "remote_tlbs" nomenclature, and renaming the common APIs will just push the inconsistencies into x86. While I 100% agree that the current naming is flawed, I am not willing to end up with x86 being partially converted. I think I'm ok renaming all of x86's many hooks? But I'd definitely want input from more x86 folks, and the size and scope of this series would explode. Unless Marc objects and/or has a better idea, the least awful option is probably to ignore the poor "remote_tlbs" naming and tackle it in a separate series. Sorry for not noticiing this earlier, I didn't realize just how much x86 uses remote_tlbs. > (spiraling more into this, we also have the 'remote_tlb_flush_requests' and > 'remote_tlb_flush' stats) Regardless of what we decide for the APIs, definitely leave the stats alone. The names are ABI. We could preserve the names and changes the struct fields, but that would be a net negative IMO. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f201.google.com (mail-pg1-f201.google.com [209.85.215.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9989212B6C for ; Tue, 8 Aug 2023 15:07:46 +0000 (UTC) Received: by mail-pg1-f201.google.com with SMTP id 41be03b00d2f7-564e1843717so1866519a12.0 for ; Tue, 08 Aug 2023 08:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691507266; x=1692112066; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=BaiJ+rWGolW4ovI22gadBn2AFu8/7ikdaAkBdyz0qCk=; b=ayK3mYp5ZQm5F204c8SfuM/WFFVkRk0fgjxIN5q1r27VDVtngJ+7mGzuMl45HAdfj+ V0WUPOd+87OJ1kHr8JYMh1jq5/tq0s1635UzLBWQvYLHswE1gAXBqE56zdYG8sjZPtDA 7V8ZJPVauL7LNyPcAMrHkgeX4lK3nQuvXLwGO4LTA3Ld1a1174s+Z3Ro0YWwTJ0bmels x1gehns8QavBItnA8zjbhJEYkc9b4ERehz8TcMLkVftVKrJxnEapaV9ia5Kx4INBTTln mT/PFDUjApHcOuvbXA3Z6GkBBZAh+Gz0FHUPQ0QQMlY0jiz3lf4rRwDfnf637apvnFTV /Plg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691507266; x=1692112066; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BaiJ+rWGolW4ovI22gadBn2AFu8/7ikdaAkBdyz0qCk=; b=UAxuqVcNKfhvpkFuD0nuBxqNbvPbQEMr1RZzqsNsFhpWw5dTg+VqVtfwDmFamdSOcM CISTKMomF7XSxVoyF3PrwCfmVsDduXj79H/LZo4lS9VLHuygDBFeZEY6NrfwYMKMT3wa QTdalGdqHXkLLf3twtO/Bnp7WCUlOifNjDdynIqy4GezGLDCgwIDARINBzMx6Fo/JK9U pyswxsykt7t6p0diRvHqczpwaUvYZkTe1/kcM54PHHGDnUSi1p0GQsak31fRB32QHyx0 q+VT4XtkziJDTfeZ2nbdD5aAXpKbeecrG7LsbxDd/Rnuqg2zwg9LNSoJQXGau6tNH1UQ 8h7Q== X-Gm-Message-State: AOJu0YxOBFuFkY4OduWURtMDogR4oSVc/LPBm90pV1PdAjfTBXYZCJuS CEg1MlECXa08Sx35f24eMjYHJdrI0qs= X-Google-Smtp-Source: AGHT+IG5/N2ZE1Ejorc8NLEsKzeCITxV+EG+130yb+21WD/iP5VWmZCCV6UyxFu6UTgxWYvax2jHbb68fQQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:3c11:0:b0:564:179a:d5cb with SMTP id j17-20020a633c11000000b00564179ad5cbmr56114pga.8.1691507265754; Tue, 08 Aug 2023 08:07:45 -0700 (PDT) Date: Tue, 8 Aug 2023 08:07:43 -0700 In-Reply-To: Precedence: bulk X-Mailing-List: kvmarm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20230722022251.3446223-1-rananta@google.com> <20230722022251.3446223-3-rananta@google.com> <87tttpr6qy.wl-maz@kernel.org> <877cqdqw12.wl-maz@kernel.org> Message-ID: Subject: Re: [PATCH v7 02/12] KVM: arm64: Use kvm_arch_flush_remote_tlbs() From: Sean Christopherson To: Raghavendra Rao Ananta Cc: Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Paolo Bonzini , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable On Fri, Aug 04, 2023, Raghavendra Rao Ananta wrote: > On Wed, Aug 2, 2023 at 4:28=E2=80=AFPM Raghavendra Rao Ananta > wrote: > > > > Sure, I'll change it to kvm_arch_flush_vm_tlbs() in v8. > > > While working on the renaming, I realized that since this function is > called from kvm_main.c's kvm_flush_remote_tlbs(). Do we want to rename > this and the other kvm_flush_*() functions that the series introduces > to match their kvm_arch_flush_*() counterparts? Hmm, if we're going to rename one arch hook, then yes, I think it makes sen= se to rename all the common APIs and arch hooks to match. However, x86 is rife with the "remote_tlbs" nomenclature, and renaming the = common APIs will just push the inconsistencies into x86. While I 100% agree that = the current naming is flawed, I am not willing to end up with x86 being partial= ly converted. I think I'm ok renaming all of x86's many hooks? But I'd definitely want i= nput from more x86 folks, and the size and scope of this series would explode. = Unless Marc objects and/or has a better idea, the least awful option is probably t= o ignore the poor "remote_tlbs" naming and tackle it in a separate series. Sorry for not noticiing this earlier, I didn't realize just how much x86 us= es remote_tlbs. > (spiraling more into this, we also have the 'remote_tlb_flush_requests' a= nd > 'remote_tlb_flush' stats) Regardless of what we decide for the APIs, definitely leave the stats alone= . The names are ABI. We could preserve the names and changes the struct fields, = but that would be a net negative IMO. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C2BB1C001DE for ; Tue, 8 Aug 2023 15:08:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=RSFL6atLPjZu2oDls1yy55+c88oMBeG/8ZocgHzhVME=; b=UFR+N2TF9tzdikUyxeepN95CRN HjZmbTrnBzHAvRxfTeRZRARZbUIyAk6L2jq+NWyA8P/WXsyCKz0IorfvhwCRqNgd45396isAYd7ZW zIXsnAOIjP2vtIc7yShqShH2cDV6EFu2V5esYHmeZZfkSfQ6+sBMYxw1801Lb/HPRlFFN/NfSyEmj wsYDj2nIn64UmX0luDOTPn4n9O5SDW5Bp0rGPwkbTGhKp+tLmcov9Fp5JsYftziA66GpjdqmH4dHI 6wrLAJOusJDyNrMq9Sh2dE31J0ygPBsWXjNfUe+QZCeKgDhWgIl1lQT6rKSL0BJ60bDvYFItRlInh b1fJm/jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTOJS-002nTJ-0o; Tue, 08 Aug 2023 15:07:58 +0000 Received: from mail-pg1-x54a.google.com ([2607:f8b0:4864:20::54a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTOJO-002nRV-1P for linux-riscv@lists.infradead.org; Tue, 08 Aug 2023 15:07:56 +0000 Received: by mail-pg1-x54a.google.com with SMTP id 41be03b00d2f7-5646868b9e7so3550308a12.3 for ; Tue, 08 Aug 2023 08:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691507266; x=1692112066; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=BaiJ+rWGolW4ovI22gadBn2AFu8/7ikdaAkBdyz0qCk=; b=ayK3mYp5ZQm5F204c8SfuM/WFFVkRk0fgjxIN5q1r27VDVtngJ+7mGzuMl45HAdfj+ V0WUPOd+87OJ1kHr8JYMh1jq5/tq0s1635UzLBWQvYLHswE1gAXBqE56zdYG8sjZPtDA 7V8ZJPVauL7LNyPcAMrHkgeX4lK3nQuvXLwGO4LTA3Ld1a1174s+Z3Ro0YWwTJ0bmels x1gehns8QavBItnA8zjbhJEYkc9b4ERehz8TcMLkVftVKrJxnEapaV9ia5Kx4INBTTln mT/PFDUjApHcOuvbXA3Z6GkBBZAh+Gz0FHUPQ0QQMlY0jiz3lf4rRwDfnf637apvnFTV /Plg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691507266; x=1692112066; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BaiJ+rWGolW4ovI22gadBn2AFu8/7ikdaAkBdyz0qCk=; b=E5qcXfYxO1i5RuAC9T+dWgAu2sWbKQfLQadBo42qDMKDApAgXNfgNx3qvk9eHkMSuB +l/YNl2GXUJtMiHwElbiybFp1Nt4YDGYlPoE/2wsAhEnZ/WsCCS4Mrsm1S2fK1x6SdoE jxzYwbDM3IvKEwauz7xsm5mo58pz8zdieZcMyYhBh7FlDddhD3uZhO40yabffg8wm3Ac c7EB3e0TXYQ/2CnkhwGdV2aegyqxrCQCmNy8LMIGzjTJYFu9mJ5zbHUV9qLTyVeaw/I0 IAzv/aa0GlzMCZTibYMwSf4dG/WMWHGB54ezoYP3ldoyk4OwzPUGuv2CXvpVBLp+VB8W 2nog== X-Gm-Message-State: AOJu0Ywkd8XeBHnMKivp8dROeUrFRZuBoDZyWRTeNwPUw5ahJMucRCaf YuvnmU0hvaAfzCoEDGhWokFg4oAYQQQ= X-Google-Smtp-Source: AGHT+IG5/N2ZE1Ejorc8NLEsKzeCITxV+EG+130yb+21WD/iP5VWmZCCV6UyxFu6UTgxWYvax2jHbb68fQQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:3c11:0:b0:564:179a:d5cb with SMTP id j17-20020a633c11000000b00564179ad5cbmr56114pga.8.1691507265754; Tue, 08 Aug 2023 08:07:45 -0700 (PDT) Date: Tue, 8 Aug 2023 08:07:43 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230722022251.3446223-1-rananta@google.com> <20230722022251.3446223-3-rananta@google.com> <87tttpr6qy.wl-maz@kernel.org> <877cqdqw12.wl-maz@kernel.org> Message-ID: Subject: Re: [PATCH v7 02/12] KVM: arm64: Use kvm_arch_flush_remote_tlbs() From: Sean Christopherson To: Raghavendra Rao Ananta Cc: Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Paolo Bonzini , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_080754_472701_43CBB463 X-CRM114-Status: GOOD ( 14.77 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBdWcgMDQsIDIwMjMsIFJhZ2hhdmVuZHJhIFJhbyBBbmFudGEgd3JvdGU6Cj4gT24g V2VkLCBBdWcgMiwgMjAyMyBhdCA0OjI44oCvUE0gUmFnaGF2ZW5kcmEgUmFvIEFuYW50YQo+IDxy YW5hbnRhQGdvb2dsZS5jb20+IHdyb3RlOgo+ID4KPiA+IFN1cmUsIEknbGwgY2hhbmdlIGl0IHRv IGt2bV9hcmNoX2ZsdXNoX3ZtX3RsYnMoKSBpbiB2OC4KPiA+Cj4gV2hpbGUgd29ya2luZyBvbiB0 aGUgcmVuYW1pbmcsIEkgcmVhbGl6ZWQgdGhhdCBzaW5jZSB0aGlzIGZ1bmN0aW9uIGlzCj4gY2Fs bGVkIGZyb20ga3ZtX21haW4uYydzIGt2bV9mbHVzaF9yZW1vdGVfdGxicygpLiBEbyB3ZSB3YW50 IHRvIHJlbmFtZQo+IHRoaXMgYW5kIHRoZSBvdGhlciBrdm1fZmx1c2hfKigpIGZ1bmN0aW9ucyB0 aGF0IHRoZSBzZXJpZXMgaW50cm9kdWNlcwo+IHRvIG1hdGNoIHRoZWlyIGt2bV9hcmNoX2ZsdXNo XyooKSBjb3VudGVycGFydHM/CgpIbW0sIGlmIHdlJ3JlIGdvaW5nIHRvIHJlbmFtZSBvbmUgYXJj aCBob29rLCB0aGVuIHllcywgSSB0aGluayBpdCBtYWtlcyBzZW5zZSB0bwpyZW5hbWUgYWxsIHRo ZSBjb21tb24gQVBJcyBhbmQgYXJjaCBob29rcyB0byBtYXRjaC4KCkhvd2V2ZXIsIHg4NiBpcyBy aWZlIHdpdGggdGhlICJyZW1vdGVfdGxicyIgbm9tZW5jbGF0dXJlLCBhbmQgcmVuYW1pbmcgdGhl IGNvbW1vbgpBUElzIHdpbGwganVzdCBwdXNoIHRoZSBpbmNvbnNpc3RlbmNpZXMgaW50byB4ODYu ICBXaGlsZSBJIDEwMCUgYWdyZWUgdGhhdCB0aGUKY3VycmVudCBuYW1pbmcgaXMgZmxhd2VkLCBJ IGFtIG5vdCB3aWxsaW5nIHRvIGVuZCB1cCB3aXRoIHg4NiBiZWluZyBwYXJ0aWFsbHkKY29udmVy dGVkLgoKSSB0aGluayBJJ20gb2sgcmVuYW1pbmcgYWxsIG9mIHg4NidzIG1hbnkgaG9va3M/ICBC dXQgSSdkIGRlZmluaXRlbHkgd2FudCBpbnB1dApmcm9tIG1vcmUgeDg2IGZvbGtzLCBhbmQgdGhl IHNpemUgYW5kIHNjb3BlIG9mIHRoaXMgc2VyaWVzIHdvdWxkIGV4cGxvZGUuICBVbmxlc3MKTWFy YyBvYmplY3RzIGFuZC9vciBoYXMgYSBiZXR0ZXIgaWRlYSwgdGhlIGxlYXN0IGF3ZnVsIG9wdGlv biBpcyBwcm9iYWJseSB0byBpZ25vcmUKdGhlIHBvb3IgInJlbW90ZV90bGJzIiBuYW1pbmcgYW5k IHRhY2tsZSBpdCBpbiBhIHNlcGFyYXRlIHNlcmllcy4KClNvcnJ5IGZvciBub3Qgbm90aWNpaW5n IHRoaXMgZWFybGllciwgSSBkaWRuJ3QgcmVhbGl6ZSBqdXN0IGhvdyBtdWNoIHg4NiB1c2VzCnJl bW90ZV90bGJzLgoKPiAoc3BpcmFsaW5nIG1vcmUgaW50byB0aGlzLCB3ZSBhbHNvIGhhdmUgdGhl ICdyZW1vdGVfdGxiX2ZsdXNoX3JlcXVlc3RzJyBhbmQKPiAncmVtb3RlX3RsYl9mbHVzaCcgc3Rh dHMpCgpSZWdhcmRsZXNzIG9mIHdoYXQgd2UgZGVjaWRlIGZvciB0aGUgQVBJcywgZGVmaW5pdGVs eSBsZWF2ZSB0aGUgc3RhdHMgYWxvbmUuICBUaGUKbmFtZXMgYXJlIEFCSS4gIFdlIGNvdWxkIHBy ZXNlcnZlIHRoZSBuYW1lcyBhbmQgY2hhbmdlcyB0aGUgc3RydWN0IGZpZWxkcywgYnV0IHRoYXQK d291bGQgYmUgYSBuZXQgbmVnYXRpdmUgSU1PLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtcmlzY3YgbWFpbGluZyBsaXN0CmxpbnV4LXJpc2N2 QGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9s aXN0aW5mby9saW51eC1yaXNjdgo= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BA0E3C001B0 for ; Tue, 8 Aug 2023 15:08:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=XVWjH3LVReC4tgY6XFn1AwHsH/VkU1KoAC+x9KdRmB0=; b=Bma8U8pz1DltEHJwPim3PWL+22 T+5Bm3i/C7XhHg8F7BofWnNxPXcHo9LeYXqVtMDKd26bnIPC7cEG9cJ3Cqy32x8X8+U5tYPAWaSQL HRrk1RgesiY4kULrfi9pkPFclIazX5qZ71GKjEUpBRPU4giz91RlFQFUDxzZdwEvdQjokoP98DZr2 kz8D5eFKlw6PhV9uZraefE3XhdwAHozN5Mc9zGGUUtP9ufnQJSZsI20VdH9lHKNHbgoOoOK+pVUHB 5az8qAGY8UTxenh8KYI+HLEkmRaNmeQMMBwsIAzukYmDa1IYkGzLjUjST0CZF56sAy8JqIe6wL5+h EfQ5OQQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qTOJR-002nTA-1W; Tue, 08 Aug 2023 15:07:57 +0000 Received: from mail-pg1-x549.google.com ([2607:f8b0:4864:20::549]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qTOJO-002nRT-0m for linux-arm-kernel@lists.infradead.org; Tue, 08 Aug 2023 15:07:55 +0000 Received: by mail-pg1-x549.google.com with SMTP id 41be03b00d2f7-5637a108d02so3546696a12.2 for ; Tue, 08 Aug 2023 08:07:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691507266; x=1692112066; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:from:to:cc:subject:date:message-id :reply-to; bh=BaiJ+rWGolW4ovI22gadBn2AFu8/7ikdaAkBdyz0qCk=; b=ayK3mYp5ZQm5F204c8SfuM/WFFVkRk0fgjxIN5q1r27VDVtngJ+7mGzuMl45HAdfj+ V0WUPOd+87OJ1kHr8JYMh1jq5/tq0s1635UzLBWQvYLHswE1gAXBqE56zdYG8sjZPtDA 7V8ZJPVauL7LNyPcAMrHkgeX4lK3nQuvXLwGO4LTA3Ld1a1174s+Z3Ro0YWwTJ0bmels x1gehns8QavBItnA8zjbhJEYkc9b4ERehz8TcMLkVftVKrJxnEapaV9ia5Kx4INBTTln mT/PFDUjApHcOuvbXA3Z6GkBBZAh+Gz0FHUPQ0QQMlY0jiz3lf4rRwDfnf637apvnFTV /Plg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691507266; x=1692112066; h=content-transfer-encoding:cc:to:from:subject:message-id:references :mime-version:in-reply-to:date:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=BaiJ+rWGolW4ovI22gadBn2AFu8/7ikdaAkBdyz0qCk=; b=i1zceIUycnBWqQgYaRu3Y5bdKFgxYRF+uhVmyrJgy+danONDcVNVlQyBwswYY2CFHA MQV3jLIDSfaiqB+YI/EJNTThbQ1zj3JNQjQ369rbYESCjYYJ3LO+QaV4R2IrATNfK17w ubqmc8EHRnNpIMDR6iuaOl5Fz9XZx02ItJZoHkRwJkxbQOs/bcYvjmYTRJQbN1HWHRDb tpb5rbF7n/U6fVT3Seb6KsiHLvu2RvyHunLm0Wx3TdUSzeQ2DIFjkD7iW3q5cWOkAHDG 5HOH2yxQkkic8cQs6s0gBjGzSbUnJRE+QZMcSqmkSHtozoeI/JCGiBuJ7/rk9opohq+R qPrw== X-Gm-Message-State: AOJu0YyrEbU9CAH5fo8RUC7BmT/VwZoxzOW3DZXk81Be4utEIAvThb0v SRf8FnmmwmZoS61sDa4IvCXdOzOvyZo= X-Google-Smtp-Source: AGHT+IG5/N2ZE1Ejorc8NLEsKzeCITxV+EG+130yb+21WD/iP5VWmZCCV6UyxFu6UTgxWYvax2jHbb68fQQ= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a63:3c11:0:b0:564:179a:d5cb with SMTP id j17-20020a633c11000000b00564179ad5cbmr56114pga.8.1691507265754; Tue, 08 Aug 2023 08:07:45 -0700 (PDT) Date: Tue, 8 Aug 2023 08:07:43 -0700 In-Reply-To: Mime-Version: 1.0 References: <20230722022251.3446223-1-rananta@google.com> <20230722022251.3446223-3-rananta@google.com> <87tttpr6qy.wl-maz@kernel.org> <877cqdqw12.wl-maz@kernel.org> Message-ID: Subject: Re: [PATCH v7 02/12] KVM: arm64: Use kvm_arch_flush_remote_tlbs() From: Sean Christopherson To: Raghavendra Rao Ananta Cc: Marc Zyngier , Oliver Upton , James Morse , Suzuki K Poulose , Paolo Bonzini , Huacai Chen , Zenghui Yu , Anup Patel , Atish Patra , Jing Zhang , Reiji Watanabe , Colton Lewis , David Matlack , linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-mips@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, kvm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230808_080754_291245_B9D905D3 X-CRM114-Status: GOOD ( 16.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gRnJpLCBBdWcgMDQsIDIwMjMsIFJhZ2hhdmVuZHJhIFJhbyBBbmFudGEgd3JvdGU6Cj4gT24g V2VkLCBBdWcgMiwgMjAyMyBhdCA0OjI44oCvUE0gUmFnaGF2ZW5kcmEgUmFvIEFuYW50YQo+IDxy YW5hbnRhQGdvb2dsZS5jb20+IHdyb3RlOgo+ID4KPiA+IFN1cmUsIEknbGwgY2hhbmdlIGl0IHRv IGt2bV9hcmNoX2ZsdXNoX3ZtX3RsYnMoKSBpbiB2OC4KPiA+Cj4gV2hpbGUgd29ya2luZyBvbiB0 aGUgcmVuYW1pbmcsIEkgcmVhbGl6ZWQgdGhhdCBzaW5jZSB0aGlzIGZ1bmN0aW9uIGlzCj4gY2Fs bGVkIGZyb20ga3ZtX21haW4uYydzIGt2bV9mbHVzaF9yZW1vdGVfdGxicygpLiBEbyB3ZSB3YW50 IHRvIHJlbmFtZQo+IHRoaXMgYW5kIHRoZSBvdGhlciBrdm1fZmx1c2hfKigpIGZ1bmN0aW9ucyB0 aGF0IHRoZSBzZXJpZXMgaW50cm9kdWNlcwo+IHRvIG1hdGNoIHRoZWlyIGt2bV9hcmNoX2ZsdXNo XyooKSBjb3VudGVycGFydHM/CgpIbW0sIGlmIHdlJ3JlIGdvaW5nIHRvIHJlbmFtZSBvbmUgYXJj aCBob29rLCB0aGVuIHllcywgSSB0aGluayBpdCBtYWtlcyBzZW5zZSB0bwpyZW5hbWUgYWxsIHRo ZSBjb21tb24gQVBJcyBhbmQgYXJjaCBob29rcyB0byBtYXRjaC4KCkhvd2V2ZXIsIHg4NiBpcyBy aWZlIHdpdGggdGhlICJyZW1vdGVfdGxicyIgbm9tZW5jbGF0dXJlLCBhbmQgcmVuYW1pbmcgdGhl IGNvbW1vbgpBUElzIHdpbGwganVzdCBwdXNoIHRoZSBpbmNvbnNpc3RlbmNpZXMgaW50byB4ODYu ICBXaGlsZSBJIDEwMCUgYWdyZWUgdGhhdCB0aGUKY3VycmVudCBuYW1pbmcgaXMgZmxhd2VkLCBJ IGFtIG5vdCB3aWxsaW5nIHRvIGVuZCB1cCB3aXRoIHg4NiBiZWluZyBwYXJ0aWFsbHkKY29udmVy dGVkLgoKSSB0aGluayBJJ20gb2sgcmVuYW1pbmcgYWxsIG9mIHg4NidzIG1hbnkgaG9va3M/ICBC dXQgSSdkIGRlZmluaXRlbHkgd2FudCBpbnB1dApmcm9tIG1vcmUgeDg2IGZvbGtzLCBhbmQgdGhl IHNpemUgYW5kIHNjb3BlIG9mIHRoaXMgc2VyaWVzIHdvdWxkIGV4cGxvZGUuICBVbmxlc3MKTWFy YyBvYmplY3RzIGFuZC9vciBoYXMgYSBiZXR0ZXIgaWRlYSwgdGhlIGxlYXN0IGF3ZnVsIG9wdGlv biBpcyBwcm9iYWJseSB0byBpZ25vcmUKdGhlIHBvb3IgInJlbW90ZV90bGJzIiBuYW1pbmcgYW5k IHRhY2tsZSBpdCBpbiBhIHNlcGFyYXRlIHNlcmllcy4KClNvcnJ5IGZvciBub3Qgbm90aWNpaW5n IHRoaXMgZWFybGllciwgSSBkaWRuJ3QgcmVhbGl6ZSBqdXN0IGhvdyBtdWNoIHg4NiB1c2VzCnJl bW90ZV90bGJzLgoKPiAoc3BpcmFsaW5nIG1vcmUgaW50byB0aGlzLCB3ZSBhbHNvIGhhdmUgdGhl ICdyZW1vdGVfdGxiX2ZsdXNoX3JlcXVlc3RzJyBhbmQKPiAncmVtb3RlX3RsYl9mbHVzaCcgc3Rh dHMpCgpSZWdhcmRsZXNzIG9mIHdoYXQgd2UgZGVjaWRlIGZvciB0aGUgQVBJcywgZGVmaW5pdGVs eSBsZWF2ZSB0aGUgc3RhdHMgYWxvbmUuICBUaGUKbmFtZXMgYXJlIEFCSS4gIFdlIGNvdWxkIHBy ZXNlcnZlIHRoZSBuYW1lcyBhbmQgY2hhbmdlcyB0aGUgc3RydWN0IGZpZWxkcywgYnV0IHRoYXQK d291bGQgYmUgYSBuZXQgbmVnYXRpdmUgSU1PLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=