From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Matthew Brost <matthew.brost@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 0/2] DRM scheduler changes for upstream
Date: Tue, 8 Aug 2023 17:38:06 -0400 [thread overview]
Message-ID: <ZNK1vp3Q1lFULBV0@intel.com> (raw)
In-Reply-To: <20230801032748.434509-1-matthew.brost@intel.com>
On Mon, Jul 31, 2023 at 08:27:46PM -0700, Matthew Brost wrote:
> Fix the DRM scheduler changed based on feedback from upstream RFC
> feedback [1].
>
> First patch addresses Boris's feedback [2] to not make the scheduler
> work queue run in a infinite loop, rather have it requeue itself for
> fairness.
>
> Second patch addresse Luben's and Boris's feedback [3] to add a job to
> the pending list before caling run_job() and kicking the TDR after. This
> also includes a bit of restructure of the DRM scheduler helper
> functions that will be broken out into a different patch but squashing
> this into an earlier patch as fixup for easier repo maintainance.
>
> Matt
>
> [1] https://patchwork.freedesktop.org/series/116055/
> [2] https://patchwork.freedesktop.org/patch/530655/?series=116055&rev=1
> [3] https://patchwork.freedesktop.org/patch/530652/?series=116055&rev=1
>
> Matthew Brost (2):
> fixup! drm/sched: Submit job before starting TDR
> fixup! drm/sched: Convert drm scheduler to use a work queue rather
> than kthread
should we merge them now? or should you send them first to the dri-devel
again and only change here after getting the final ack/review there?
Well, having them here ensures the CI on it... so up to you.
Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
> drivers/gpu/drm/scheduler/sched_main.c | 87 +++++++++++++-------------
> 1 file changed, 43 insertions(+), 44 deletions(-)
>
> --
> 2.34.1
>
prev parent reply other threads:[~2023-08-08 21:39 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-01 3:27 [Intel-xe] [PATCH 0/2] DRM scheduler changes for upstream Matthew Brost
2023-08-01 3:27 ` [Intel-xe] [PATCH 1/2] fixup! drm/sched: Submit job before starting TDR Matthew Brost
2023-08-01 3:27 ` [Intel-xe] [PATCH 2/2] fixup! drm/sched: Convert drm scheduler to use a work queue rather than kthread Matthew Brost
2023-08-01 3:30 ` [Intel-xe] ✓ CI.Patch_applied: success for DRM scheduler changes for upstream Patchwork
2023-08-01 3:30 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-01 3:31 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-01 3:35 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-08-01 3:35 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-08-01 3:37 ` [Intel-xe] ✓ CI.checksparse: " Patchwork
2023-08-01 4:11 ` [Intel-xe] ○ CI.BAT: info " Patchwork
2023-08-08 21:38 ` Rodrigo Vivi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNK1vp3Q1lFULBV0@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=matthew.brost@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.