From: Brian Norris <briannorris@chromium.org>
To: Ruan Jinjie <ruanjinjie@huawei.com>
Cc: kvalo@kernel.org, christophe.jaillet@wanadoo.fr,
simon.horman@corigine.com, linux-wireless@vger.kernel.org
Subject: Re: [PATCH -next RESEND] wifi: mwifiex: use is_zero_ether_addr() instead of ether_addr_equal()
Date: Tue, 8 Aug 2023 13:13:56 -0700 [thread overview]
Message-ID: <ZNKiBE3GIi/wQXLB@google.com> (raw)
In-Reply-To: <20230808081023.2303423-1-ruanjinjie@huawei.com>
On Tue, Aug 08, 2023 at 04:10:23PM +0800, Ruan Jinjie wrote:
> Use is_zero_ether_addr() instead of ether_addr_equal()
> to check if the ethernet address is all zeros.
>
> Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com>
Usually you should provide some explanation for a RESEND of a
seemingly-identical patch. Seemingly you just updated the address list?
Anyway, looks fine:
Acked-by: Brian Norris <briannorris@chromium.org>
next prev parent reply other threads:[~2023-08-08 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 8:10 [PATCH -next RESEND] wifi: mwifiex: use is_zero_ether_addr() instead of ether_addr_equal() Ruan Jinjie
2023-08-08 20:13 ` Brian Norris [this message]
2023-08-09 1:26 ` Ruan Jinjie
2023-08-21 15:57 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNKiBE3GIi/wQXLB@google.com \
--to=briannorris@chromium.org \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=ruanjinjie@huawei.com \
--cc=simon.horman@corigine.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.