From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Jani Nikula <jani.nikula@intel.com>
Cc: intel-xe@lists.freedesktop.org
Subject: Re: [Intel-xe] [PATCH 9/9] fixup! drm/i915/display: Remaining changes to make xe compile
Date: Tue, 8 Aug 2023 16:50:57 -0400 [thread overview]
Message-ID: <ZNKqsWeph2qPpnjw@intel.com> (raw)
In-Reply-To: <20230808114535.1600595-9-jani.nikula@intel.com>
On Tue, Aug 08, 2023 at 02:45:35PM +0300, Jani Nikula wrote:
> Unnecessary change, drop it.
>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_vbt_defs.h b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> index 001de8fe4e64..a9f44abfc9fc 100644
> --- a/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> +++ b/drivers/gpu/drm/i915/display/intel_vbt_defs.h
> @@ -30,7 +30,7 @@
> *
> * Please do NOT include anywhere else.
> */
> -#if !defined(_INTEL_BIOS_PRIVATE) && !defined(HDRTEST)
> +#ifndef _INTEL_BIOS_PRIVATE
I believe this is the only one that I cannot verify, but if
the compiler is not complaining I'm happy with it.
For the entire series:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
> #error "intel_vbt_defs.h is private to intel_bios.c"
> #endif
>
> --
> 2.39.2
>
next prev parent reply other threads:[~2023-08-08 20:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 11:45 [Intel-xe] [PATCH 1/9] drm/i915/display: add I915 conditional build to g4x_hdmi.h Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 2/9] drm/i915/display: add I915 conditional build to intel_dvo.h Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 3/9] drm/i915/display: add I915 conditional build to intel_sdvo.h Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 4/9] drm/i915/display: add I915 conditional build to intel_tv.h Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 5/9] drm/i915/display: add I915 conditional build to vlv_dsi_pll.h Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 6/9] fixup! drm/xe/display: Implement display support Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 7/9] " Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 8/9] " Jani Nikula
2023-08-08 11:45 ` [Intel-xe] [PATCH 9/9] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
2023-08-08 20:50 ` Rodrigo Vivi [this message]
2023-08-08 12:02 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/9] drm/i915/display: add I915 conditional build to g4x_hdmi.h Patchwork
2023-08-08 12:02 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-08 12:04 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-08 12:07 ` [Intel-xe] ✗ CI.Build: failure " Patchwork
2023-08-09 12:28 ` [Intel-xe] ✓ CI.Patch_applied: success for series starting with [1/9] drm/i915/display: add I915 conditional build to g4x_hdmi.h (rev2) Patchwork
2023-08-09 12:29 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-08-09 12:30 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-08-09 12:33 ` [Intel-xe] ✗ CI.Build: failure " Patchwork
-- strict thread matches above, loose matches on Subject: below --
2023-04-19 12:39 [Intel-xe] [PATCH 0/9] xe & i915 display integration cleanups Jani Nikula
2023-04-19 12:39 ` [Intel-xe] [PATCH 9/9] fixup! drm/i915/display: Remaining changes to make xe compile Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNKqsWeph2qPpnjw@intel.com \
--to=rodrigo.vivi@intel.com \
--cc=intel-xe@lists.freedesktop.org \
--cc=jani.nikula@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.