From: "Jason A. Donenfeld" <Jason@zx2c4.com>
To: "Limonciello, Mario" <mario.limonciello@amd.com>
Cc: stable@vger.kernel.org, gregkh@linuxfoundation.org,
linux-integrity@vger.kernel.org, jarkko@kernel.org
Subject: Re: AMD fTPM patches for stable
Date: Thu, 10 Aug 2023 01:24:32 +0200 [thread overview]
Message-ID: <ZNQgMF7tOrdBMvK7@zx2c4.com> (raw)
In-Reply-To: <26bcc3ca-0543-43b0-a43b-2d913505e000@amd.com>
On Wed, Aug 09, 2023 at 05:22:02PM -0500, Limonciello, Mario wrote:
>
>
> On 8/9/2023 4:33 PM, Jason A. Donenfeld wrote:
> > Hey Greg,
> >
> > There was recently a bit of a snafoo with a maintainer taking the wrong
> > version of a patch and sending that up to Linus. That patch had
> > incorrect stable@ annotations and had a bug in it. That bug was fixed
> > with a follow up patch. But of course the metadata couldn't be changed
> > easily retroactively.
> >
> > So I'm emailing to ask you to backport these two patches back to 5.5:
> >
> > - 554b841d4703 ("tpm: Disable RNG for all AMD fTPMs")
> > - cacc6e22932f ("tpm: Add a helper for checking hwrng enabled")
> >
> > I know the stable@ tag says 6.1+, but the actual right tags from the
> > newer versioned patch that didn't get picked are:
> >
> > Cc: stable@vger.kernel.org # 5.5+
> > Fixes: b006c439d58d ("hwrng: core - start hwrng kthread also for untrusted sources")
> > Fixes: f1324bbc4011 ("tpm: disable hwrng for fTPM on some AMD designs")
> > Fixes: 3ef193822b25 ("tpm_crb: fix fTPM on AMD Zen+ CPUs")
> > Reported-by: daniil.stas@posteo.net
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217719
> > Reported-by: bitlord0xff@gmail.com
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217212
> > Reviewed-by: Jason A. Donenfeld <Jason@zx2c4.com>
> > Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
> >
> > Let me know if you need any more info.
> >
> > Thanks,
> > Jason
>
> So I had a quick try with the backports to see what happens. 6.1.y and
> 6.4.y apply cleanly no problem.
>
> However 5.15.y (and presumably 5.5.y) have a variety of issues that I
> think no longer make it a stable candidate. I started going down the
> rabbit hole of dependencies and it's massive unless hand modifications
> are done.
>
> Realistically the problem is most severe in 6.1.y because of
> b006c439d58d. I don't know it's worth going back any further.
Okay. Your (AMD's) hardware, so I'm fine deferring to your judgement.
Jason
prev parent reply other threads:[~2023-08-09 23:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 21:33 AMD fTPM patches for stable Jason A. Donenfeld
2023-08-09 22:22 ` Limonciello, Mario
2023-08-09 23:24 ` Jason A. Donenfeld [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNQgMF7tOrdBMvK7@zx2c4.com \
--to=jason@zx2c4.com \
--cc=gregkh@linuxfoundation.org \
--cc=jarkko@kernel.org \
--cc=linux-integrity@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.