From: Andy Shevchenko <andriy.shevchenko@intel.com>
To: Tony Lindgren <tony@atomide.com>
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Dhruva Gole" <d-gole@ti.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"John Ogness" <john.ogness@linutronix.de>,
"Johan Hovold" <johan@kernel.org>,
"Sebastian Andrzej Siewior" <bigeasy@linutronix.de>,
"Vignesh Raghavendra" <vigneshr@ti.com>,
linux-kernel@vger.kernel.org, linux-serial@vger.kernel.org,
"Guenter Roeck" <linux@roeck-us.net>
Subject: Re: [PATCH] serial: core: Fix serial core port id, including multiport devices
Date: Thu, 10 Aug 2023 18:24:13 +0300 [thread overview]
Message-ID: <ZNUBHaDTsAXVNNLZ@smile.fi.intel.com> (raw)
In-Reply-To: <20230810065737.47294-1-tony@atomide.com>
On Thu, Aug 10, 2023 at 09:57:34AM +0300, Tony Lindgren wrote:
> We want to fix the serial core port DEVNAME to use a port id of the
> hardware specific controller port instance instead of the port->line.
>
> For example, the 8250 driver sets up a number of serial8250 ports
> initially that can be inherited by the hardware specific driver. At that
> the port->line no longer decribes the port's relation to the serial core
> controller instance.
>
> Let's fix the issue by assigning port->port_id for each serial core
> controller port instance.
...
> + unsigned int min = 0, max = ~0U;
Shouldn't this be int? The max IIRC will be INT_MAX with this anyway.
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2023-08-10 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-10 6:57 [PATCH] serial: core: Fix serial core port id, including multiport devices Tony Lindgren
2023-08-10 8:36 ` Dhruva Gole
2023-08-10 8:49 ` Tony Lindgren
2023-08-10 15:25 ` Andy Shevchenko
2023-08-10 9:09 ` Dhruva Gole
2023-08-10 15:24 ` Andy Shevchenko [this message]
2023-08-10 15:26 ` Andy Shevchenko
2023-08-11 5:11 ` Tony Lindgren
2023-08-11 9:35 ` Andy Shevchenko
2023-08-11 9:35 ` Andy Shevchenko
2023-08-11 9:38 ` Andy Shevchenko
2023-08-11 10:21 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNUBHaDTsAXVNNLZ@smile.fi.intel.com \
--to=andriy.shevchenko@intel.com \
--cc=bigeasy@linutronix.de \
--cc=d-gole@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=johan@kernel.org \
--cc=john.ogness@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=tony@atomide.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.