From: Jason Gunthorpe <jgg@nvidia.com>
To: Alex Williamson <alex.williamson@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Tian, Kevin" <kevin.tian@intel.com>,
Brett Creeley <bcreeley@amd.com>,
Brett Creeley <brett.creeley@amd.com>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"yishaih@nvidia.com" <yishaih@nvidia.com>,
"shameerali.kolothum.thodi@huawei.com"
<shameerali.kolothum.thodi@huawei.com>,
"horms@kernel.org" <horms@kernel.org>,
"shannon.nelson@amd.com" <shannon.nelson@amd.com>
Subject: Re: [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking
Date: Thu, 10 Aug 2023 15:11:43 -0300 [thread overview]
Message-ID: <ZNUoX77mXBTHJHVJ@nvidia.com> (raw)
In-Reply-To: <20230810115444.21364456.alex.williamson@redhat.com>
On Thu, Aug 10, 2023 at 11:54:44AM -0600, Alex Williamson wrote:
> On Thu, 10 Aug 2023 14:43:04 -0300
> Jason Gunthorpe <jgg@nvidia.com> wrote:
>
> > On Thu, Aug 10, 2023 at 11:40:08AM -0600, Alex Williamson wrote:
> >
> > > PCI Express® Base Specification Revision 6.0.1, pg 1461:
> > >
> > > 9.3.3.11 VF Device ID (Offset 1Ah)
> > >
> > > This field contains the Device ID that should be presented for every VF to the SI.
> > >
> > > VF Device ID may be different from the PF Device ID...
> > >
> > > That? Thanks,
> >
> > NVMe matches using the class code, IIRC there is language requiring
> > the class code to be the same.
>
> Ok, yes:
>
> 7.5.1.1.6 Class Code Register (Offset 09h)
> ...
> The field in a PF and its associated VFs must return the same value
> when read.
>
> Seems limiting, but it's indeed there. We've got a lot of cleanup to
> do if we're going to start rejecting drivers for devices with PCI
> spec violations though ;) Thanks,
Well.. If we defacto say that Linux is endorsing ignoring this part of
the spec then I predict we will see more vendors follow this approach.
Jason
next prev parent reply other threads:[~2023-08-10 18:11 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-07 20:57 [PATCH v14 vfio 0/8] pds-vfio-pci driver Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 1/8] vfio: Commonize combine_ranges for use in other VFIO drivers Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 2/8] vfio/pds: Initial support for pds VFIO driver Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 3/8] pds_core: Require callers of register/unregister to pass PF drvdata Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 4/8] vfio/pds: register with the pds_core PF Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 5/8] vfio/pds: Add VFIO live migration support Brett Creeley
2023-08-08 22:27 ` Alex Williamson
2023-08-09 15:44 ` Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 6/8] vfio/pds: Add support for dirty page tracking Brett Creeley
2023-08-08 22:27 ` Alex Williamson
2023-08-09 15:44 ` Brett Creeley
2023-08-09 17:33 ` Alex Williamson
2023-08-09 18:06 ` Jason Gunthorpe
2023-08-10 2:47 ` Tian, Kevin
2023-08-10 16:47 ` Alex Williamson
2023-08-10 17:19 ` Jason Gunthorpe
2023-08-10 17:40 ` Alex Williamson
2023-08-10 17:43 ` Jason Gunthorpe
2023-08-10 17:54 ` Alex Williamson
2023-08-10 18:11 ` Jason Gunthorpe [this message]
2023-08-11 3:25 ` Tian, Kevin
2023-08-14 18:41 ` Brett Creeley
2023-08-15 2:45 ` Tian, Kevin
2023-08-11 15:53 ` Alex Williamson
2023-08-12 10:49 ` Christoph Hellwig
2023-08-14 22:51 ` Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 7/8] vfio/pds: Add support for firmware recovery Brett Creeley
2023-08-07 20:57 ` [PATCH v14 vfio 8/8] vfio/pds: Add Kconfig and documentation Brett Creeley
2023-08-10 8:32 ` [PATCH v14 vfio 0/8] pds-vfio-pci driver Shameerali Kolothum Thodi
2023-08-15 2:47 ` Tian, Kevin
2023-08-17 17:53 ` Alex Williamson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNUoX77mXBTHJHVJ@nvidia.com \
--to=jgg@nvidia.com \
--cc=alex.williamson@redhat.com \
--cc=bcreeley@amd.com \
--cc=brett.creeley@amd.com \
--cc=hch@lst.de \
--cc=horms@kernel.org \
--cc=kevin.tian@intel.com \
--cc=kvm@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shannon.nelson@amd.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.