From: Brian Norris <briannorris@chromium.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Polaris Pi <pinkperfect2021@gmail.com>,
matthewmwang@chromium.org, kuba@kernel.org, kvalo@kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH v8] wifi: mwifiex: Fix OOB and integer underflow when rx packets
Date: Thu, 10 Aug 2023 16:54:14 -0700 [thread overview]
Message-ID: <ZNV4piNiozRcGRYo@google.com> (raw)
In-Reply-To: <4933455600e633c8cbafc0fc3180a7023894f8c9.camel@sipsolutions.net>
On Thu, Aug 10, 2023 at 09:32:57AM +0200, Johannes Berg wrote:
> On Wed, 2023-08-09 at 21:58 +0000, Polaris Pi wrote:
> > Make sure mwifiex_process_mgmt_packet,
> > mwifiex_process_sta_rx_packet and mwifiex_process_uap_rx_packet,
> > mwifiex_uap_queue_bridged_pkt and mwifiex_process_rx_packet
> > not out-of-bounds access the skb->data buffer.
> >
> > Fixes: 2dbaf751b1de ("mwifiex: report received management frames to cfg80211")
> > Signed-off-by: Polaris Pi <pinkperfect2021@gmail.com>
> > ---
> > V5: Follow chromeos comments: preserve the original flow of mwifiex_process_uap_rx_packet
> > V6: Simplify check in mwifiex_process_uap_rx_packet
> > V7: Fix drop packets issue when auotest V6, now pass manual and auto tests
> > V8: Fix missing return after free skb
> >
>
> Arguably, as Brian also said, that missing return is completely
> unrelated and should perhaps be a separate commit?
I think the key here is that Polaris's buggy patch has already been
applied, so this v8 doesn't really work. He has since submitted a proper
fixup patch that applies appropriately, and I've Ack'd that.
Brian
next prev parent reply other threads:[~2023-08-10 23:54 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-09 21:58 [PATCH v8] wifi: mwifiex: Fix OOB and integer underflow when rx packets Polaris Pi
2023-08-10 7:32 ` Johannes Berg
2023-08-10 8:39 ` [PATCH] wifi: mwifiex: Fix missed return in oob checks failed path Polaris Pi
2023-08-10 23:52 ` Brian Norris
2023-08-21 15:57 ` Kalle Valo
2023-08-10 23:54 ` Brian Norris [this message]
2023-08-11 10:02 ` [PATCH v8] wifi: mwifiex: Fix OOB and integer underflow when rx packets Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZNV4piNiozRcGRYo@google.com \
--to=briannorris@chromium.org \
--cc=johannes@sipsolutions.net \
--cc=kuba@kernel.org \
--cc=kvalo@kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=matthewmwang@chromium.org \
--cc=pinkperfect2021@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.